mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw@amazon.co.uk>
To: Andi Kleen <ak@linux.intel.com>
Cc: Paul Turner <pjt@google.com>, LKML <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linux-foundation.org>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Dave Hansen <dave.hansen@intel.com>,
	tglx@linutronix.de, Kees Cook <keescook@google.com>,
	Rik van Riel <riel@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Jiri Kosina <jikos@kernel.org>,
	gnomes@lxorguk.ukuu.org.uk
Subject: [PATCH v6 06/10] x86/retpoline/xen: Convert Xen hypercall indirect jumps
Date: Sun,  7 Jan 2018 22:11:21 +0000	[thread overview]
Message-ID: <1515363085-4219-7-git-send-email-dwmw@amazon.co.uk> (raw)
In-Reply-To: <1515363085-4219-1-git-send-email-dwmw@amazon.co.uk>

Convert indirect call in Xen hypercall to use non-speculative sequence,
when CONFIG_RETPOLINE is enabled.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Acked-By: Arjan van de Ven <arjan@linux.intel.com>
---
 arch/x86/include/asm/xen/hypercall.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/xen/hypercall.h b/arch/x86/include/asm/xen/hypercall.h
index 7cb282e..393c004 100644
--- a/arch/x86/include/asm/xen/hypercall.h
+++ b/arch/x86/include/asm/xen/hypercall.h
@@ -44,6 +44,7 @@
 #include <asm/page.h>
 #include <asm/pgtable.h>
 #include <asm/smap.h>
+#include <asm/nospec-branch.h>
 
 #include <xen/interface/xen.h>
 #include <xen/interface/sched.h>
@@ -217,9 +218,9 @@ privcmd_call(unsigned call,
 	__HYPERCALL_5ARG(a1, a2, a3, a4, a5);
 
 	stac();
-	asm volatile("call *%[call]"
+	asm volatile(NOSPEC_CALL
 		     : __HYPERCALL_5PARAM
-		     : [call] "a" (&hypercall_page[call])
+		     : [thunk_target] "a" (&hypercall_page[call])
 		     : __HYPERCALL_CLOBBER5);
 	clac();
 
-- 
2.7.4

  parent reply	other threads:[~2018-01-07 22:12 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-07 22:11 [PATCH v6 00/10] Retpoline: Avoid speculative indirect calls in kernel David Woodhouse
2018-01-07 22:11 ` [PATCH v6 01/10] x86/retpoline: Add initial retpoline support David Woodhouse
2018-01-08 10:45   ` Peter Zijlstra
2018-01-08 10:53     ` David Woodhouse
2018-01-08 11:03       ` Peter Zijlstra
2018-01-08 12:45         ` David Woodhouse
2018-01-08 13:42   ` Josh Poimboeuf
2018-01-08 13:46     ` Thomas Gleixner
2018-01-08 13:53       ` Josh Poimboeuf
2018-01-08 14:26         ` David Woodhouse
2018-01-08 21:20           ` Josh Poimboeuf
2018-01-09 12:36       ` Peter Zijlstra
2018-01-09 13:35         ` Thomas Gleixner
2018-01-09 13:40         ` Woodhouse, David
2018-01-07 22:11 ` [PATCH v6 02/10] x86/retpoline/crypto: Convert crypto assembler indirect jumps David Woodhouse
2018-01-08 13:49   ` Josh Poimboeuf
2018-01-07 22:11 ` [PATCH v6 03/10] x86/retpoline/entry: Convert entry " David Woodhouse
2018-01-07 22:11 ` [PATCH v6 04/10] x86/retpoline/ftrace: Convert ftrace " David Woodhouse
2018-01-07 22:11 ` [PATCH v6 05/10] x86/retpoline/hyperv: Convert " David Woodhouse
2018-01-07 22:11 ` David Woodhouse [this message]
2018-01-07 22:11 ` [PATCH v6 07/10] x86/retpoline/checksum32: " David Woodhouse
2018-01-07 22:11 ` [PATCH v6 08/10] x86/retpoline/irq32: " David Woodhouse
2018-01-07 22:11 ` [PATCH v6 09/10] x86/retpoline: Add boot time option to disable retpoline David Woodhouse
2018-01-07 22:11 ` [PATCH v6 10/10] x86/retpoline: Exclude objtool with retpoline David Woodhouse
2018-01-08 10:25   ` Thomas Gleixner
2018-01-08 10:34     ` Woodhouse, David
2018-01-08 13:20       ` Josh Poimboeuf
2018-01-07 22:22 ` [PATCH v6 00/10] Retpoline: Avoid speculative indirect calls in kernel Linus Torvalds
2018-01-08 10:01   ` Thomas Gleixner
2018-01-08 17:54   ` Ingo Molnar
2018-01-08 21:10     ` Thomas Gleixner
2018-01-08 10:34 ` Paul Turner
2018-01-08 10:38   ` Jiri Kosina
2018-01-08 10:45     ` Paul Turner
2018-01-08 10:42   ` Paul Turner
2018-01-08 11:16     ` Andrew Cooper
2018-01-08 11:25       ` Paul Turner
2018-01-08 16:13     ` Alexei Starovoitov
2018-01-10 15:20     ` Woodhouse, David
2018-01-10 15:31       ` Dr. David Alan Gilbert
2018-01-08 10:45   ` David Woodhouse
2018-01-08 10:53     ` Paul Turner
2018-01-08 12:49       ` David Woodhouse
2018-01-08 23:44 ` [PATCH v6 11/10] x86/retpoline: Avoid return buffer underflows on context switch David Woodhouse
2018-01-08 23:56   ` Linus Torvalds
2018-01-08 23:58     ` Woodhouse, David
2018-01-09  0:35       ` Linus Torvalds
2018-01-09  0:42         ` David Woodhouse
2018-01-09  0:48           ` Linus Torvalds
2018-01-09  0:55             ` David Woodhouse
2018-01-09  0:44         ` Andi Kleen
2018-01-09  0:58           ` Linus Torvalds
2018-01-09  1:15             ` Andrew Cooper
2018-01-09  3:27               ` Andy Lutomirski
2018-01-09 13:04                 ` David Woodhouse
2018-01-09 13:10                   ` Peter Zijlstra
2018-01-09 17:53                   ` Kees Cook
2018-01-09 18:09                   ` Linus Torvalds
2018-02-16  8:58                   ` Pavel Machek
2018-01-09  1:16             ` Andi Kleen
2018-01-09  1:21               ` [PATCH v6 11/10] x86/retpoline: Avoid return buffer underflows on context switch II Andi Kleen
2018-01-09  1:23                 ` Woodhouse, David
2018-01-09  1:49                   ` Andi Kleen
2018-01-09  1:53                 ` Paul Turner
2018-01-09  1:18             ` [PATCH v6 11/10] x86/retpoline: Avoid return buffer underflows on context switch Woodhouse, David
2018-01-09  0:06     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1515363085-4219-7-git-send-email-dwmw@amazon.co.uk \
    --to=dwmw@amazon.co.uk \
    --cc=ak@linux.intel.com \
    --cc=dave.hansen@intel.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linux-foundation.org \
    --cc=jikos@kernel.org \
    --cc=keescook@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®