mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: joro@8bytes.org, robh+dt@kernel.org, mark.rutland@arm.com,
	rjw@rjwysocki.net, robin.murphy@arm.com, will.deacon@arm.com,
	robdclark@gmail.com, iommu@lists.linux-foundation.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org
Cc: alex.williamson@redhat.com, gregkh@linuxfoundation.org,
	airlied@linux.ie, sboyd@codeaurora.org, sricharan@codeaurora.org,
	m.szyprowski@samsung.com, architt@codeaurora.org,
	linux-arm-msm@vger.kernel.org, vivek.gautam@codeaurora.org
Subject: [PATCH v7 4/6] iommu/arm-smmu: Add the device_link between masters and smmu
Date: Wed,  7 Feb 2018 16:01:20 +0530	[thread overview]
Message-ID: <1517999482-17317-5-git-send-email-vivek.gautam@codeaurora.org> (raw)
In-Reply-To: <1517999482-17317-1-git-send-email-vivek.gautam@codeaurora.org>

From: Sricharan R <sricharan@codeaurora.org>

Finally add the device link between the master device and
smmu, so that the smmu gets runtime enabled/disabled only when the
master needs it. This is done from add_device callback which gets
called once when the master is added to the smmu.

Signed-off-by: Sricharan R <sricharan@codeaurora.org>
Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
---
 drivers/iommu/arm-smmu.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index c024f69c1682..c7e924d553bd 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -215,6 +215,9 @@ struct arm_smmu_device {
 
 	/* IOMMU core code handle */
 	struct iommu_device		iommu;
+
+	/* runtime PM link to master */
+	struct device_link *link;
 };
 
 enum arm_smmu_context_fmt {
@@ -1425,6 +1428,17 @@ static int arm_smmu_add_device(struct device *dev)
 
 	pm_runtime_put_sync(smmu->dev);
 
+	/*
+	 * Establish the link between smmu and master, so that the
+	 * smmu gets runtime enabled/disabled as per the master's
+	 * needs.
+	 */
+	smmu->link = device_link_add(dev, smmu->dev, DL_FLAG_PM_RUNTIME);
+	if (!smmu->link)
+		dev_warn(smmu->dev,
+			 "Unable to create device link between %s and %s\n",
+			 dev_name(smmu->dev), dev_name(dev));
+
 	return 0;
 
 out_rpm_put:
@@ -1449,6 +1463,8 @@ static void arm_smmu_remove_device(struct device *dev)
 	cfg  = fwspec->iommu_priv;
 	smmu = cfg->smmu;
 
+	device_link_del(smmu->link);
+
 	ret = pm_runtime_get_sync(smmu->dev);
 	if (ret)
 		return;
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

  parent reply	other threads:[~2018-02-07 10:31 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07 10:31 [PATCH v7 0/6] iommu/arm-smmu: Add runtime pm/sleep support Vivek Gautam
2018-02-07 10:31 ` [PATCH v7 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers Vivek Gautam
2018-02-13  7:44   ` Tomasz Figa
2018-02-13 12:00     ` Robin Murphy
2018-02-13 12:54       ` Tomasz Figa
2018-02-13 13:37         ` Robin Murphy
2018-02-07 10:31 ` [PATCH v7 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops Vivek Gautam
2018-02-13  8:03   ` Tomasz Figa
2018-02-13 10:25     ` Vivek Gautam
2018-02-14  3:45       ` Tomasz Figa
2018-02-07 10:31 ` [PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device Vivek Gautam
2018-02-13  8:24   ` Tomasz Figa
2018-02-13 12:57     ` Robin Murphy
2018-02-13 13:52       ` Tomasz Figa
2018-02-14  8:24         ` Vivek Gautam
2018-02-14  8:28     ` Vivek Gautam
2018-02-22 23:52   ` Jordan Crouse
2018-02-23 10:36     ` Vivek Gautam
2018-02-23 15:40       ` [Freedreno] " Jordan Crouse
2018-02-23 17:43         ` Vivek Gautam
2018-02-07 10:31 ` Vivek Gautam [this message]
2018-02-13  8:31   ` [PATCH v7 4/6] iommu/arm-smmu: Add the device_link between masters and smmu Tomasz Figa
2018-02-13 10:14     ` Vivek Gautam
2018-02-07 10:31 ` [PATCH v7 5/6] iommu/arm-smmu: Add support for qcom,smmu-v2 variant Vivek Gautam
2018-02-09 10:57   ` [PATCH v8 " Vivek Gautam
2018-02-13  8:57     ` Tomasz Figa
2018-02-07 10:31 ` [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers Vivek Gautam
2018-02-13  9:10   ` Tomasz Figa
2018-02-13 16:42     ` Jordan Crouse
2018-02-14  3:31       ` Tomasz Figa
2018-02-14 15:48         ` Jordan Crouse
2018-02-14 16:12           ` [Freedreno] " Rob Clark
2018-02-15  4:09             ` Tomasz Figa
2018-02-15 14:14               ` Rob Clark
2018-02-13 18:03     ` Rob Clark
2018-02-14  1:59       ` Tomasz Figa
2018-02-14  2:13         ` Rob Clark
2018-02-14  3:01           ` Tomasz Figa
2018-02-14  4:17             ` Vivek Gautam
2018-02-14  5:38               ` Tomasz Figa
2018-02-14  9:13                 ` Vivek Gautam
2018-02-14  9:16                   ` Tomasz Figa
2018-02-14 10:33                     ` Vivek Gautam
2018-02-14 16:03                       ` Robin Murphy
2018-02-15  3:17                         ` Tomasz Figa
2018-02-15  4:17                           ` Tomasz Figa
2018-02-15 17:14                             ` Robin Murphy
2018-02-16  0:13                               ` Tomasz Figa
2018-02-22  8:13                                 ` Tomasz Figa
2018-02-22 13:30                                   ` [Freedreno] " Rob Clark
2018-02-22 13:45                                 ` Robin Murphy
2018-02-22 14:12                                   ` Tomasz Figa
2018-02-22 17:24                                     ` Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517999482-17317-5-git-send-email-vivek.gautam@codeaurora.org \
    --to=vivek.gautam@codeaurora.org \
    --cc=airlied@linux.ie \
    --cc=alex.williamson@redhat.com \
    --cc=architt@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mark.rutland@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=sboyd@codeaurora.org \
    --cc=sricharan@codeaurora.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®