mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Tomasz Figa <tfiga@chromium.org>,
	Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: "list@263.net:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
	Joerg Roedel <joro@8bytes.org>,
	joro@8bytes.org, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Will Deacon <will.deacon@arm.com>,
	Rob Clark <robdclark@gmail.com>,
	"list@263.net:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
	Joerg Roedel <joro@8bytes.org>,
	iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	dri-devel <dri-devel@lists.freedesktop.org>,
	freedreno@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
	Greg KH <gregkh@linuxfoundation.org>,
	sboyd@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v7 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers
Date: Tue, 13 Feb 2018 12:00:37 +0000	[thread overview]
Message-ID: <65d707c0-76cc-d59e-ff18-1fdd89306900@arm.com> (raw)
In-Reply-To: <CAAFQd5BmroRf-C8dQkvTKHWK1psGnNi1t7g-q=Xce6KjrGTsdw@mail.gmail.com>

On 13/02/18 07:44, Tomasz Figa wrote:
> Hi Vivek,
> 
> On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam
> <vivek.gautam@codeaurora.org> wrote:
>> The device link allows the pm framework to tie the supplier and
>> consumer. So, whenever the consumer is powered-on the supplier
>> is powered-on first.
>>
>> There are however cases in which the consumer wants to power-on
>> the supplier, but not itself.
>> E.g., A Graphics or multimedia driver wants to power-on the SMMU
>> to unmap a buffer and finish the TLB operations without powering
>> on itself.
> 
> This sounds strange to me. If the SMMU is powered down, wouldn't the
> TLB lose its contents as well (and so no flushing needed)?

Depends on implementation details - if runtime PM is actually 
implemented via external clock gating (in the absence of fine-grained 
power domains), then "suspended" TLBs might both retain state and not 
receive invalidation requests, which is really the worst case.

> Other than that, what kind of hardware operations would be needed
> besides just updating the page tables from the CPU?

Domain attach/detach also require updating SMMU hardware state (and 
possibly TLB maintenance), but don't logically require the master device 
itself to be active at the time.

Robin.

  reply	other threads:[~2018-02-13 12:00 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07 10:31 [PATCH v7 0/6] iommu/arm-smmu: Add runtime pm/sleep support Vivek Gautam
2018-02-07 10:31 ` [PATCH v7 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers Vivek Gautam
2018-02-13  7:44   ` Tomasz Figa
2018-02-13 12:00     ` Robin Murphy [this message]
2018-02-13 12:54       ` Tomasz Figa
2018-02-13 13:37         ` Robin Murphy
2018-02-07 10:31 ` [PATCH v7 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops Vivek Gautam
2018-02-13  8:03   ` Tomasz Figa
2018-02-13 10:25     ` Vivek Gautam
2018-02-14  3:45       ` Tomasz Figa
2018-02-07 10:31 ` [PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device Vivek Gautam
2018-02-13  8:24   ` Tomasz Figa
2018-02-13 12:57     ` Robin Murphy
2018-02-13 13:52       ` Tomasz Figa
2018-02-14  8:24         ` Vivek Gautam
2018-02-14  8:28     ` Vivek Gautam
2018-02-22 23:52   ` Jordan Crouse
2018-02-23 10:36     ` Vivek Gautam
2018-02-23 15:40       ` [Freedreno] " Jordan Crouse
2018-02-23 17:43         ` Vivek Gautam
2018-02-07 10:31 ` [PATCH v7 4/6] iommu/arm-smmu: Add the device_link between masters and smmu Vivek Gautam
2018-02-13  8:31   ` Tomasz Figa
2018-02-13 10:14     ` Vivek Gautam
2018-02-07 10:31 ` [PATCH v7 5/6] iommu/arm-smmu: Add support for qcom,smmu-v2 variant Vivek Gautam
2018-02-09 10:57   ` [PATCH v8 " Vivek Gautam
2018-02-13  8:57     ` Tomasz Figa
2018-02-07 10:31 ` [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers Vivek Gautam
2018-02-13  9:10   ` Tomasz Figa
2018-02-13 16:42     ` Jordan Crouse
2018-02-14  3:31       ` Tomasz Figa
2018-02-14 15:48         ` Jordan Crouse
2018-02-14 16:12           ` [Freedreno] " Rob Clark
2018-02-15  4:09             ` Tomasz Figa
2018-02-15 14:14               ` Rob Clark
2018-02-13 18:03     ` Rob Clark
2018-02-14  1:59       ` Tomasz Figa
2018-02-14  2:13         ` Rob Clark
2018-02-14  3:01           ` Tomasz Figa
2018-02-14  4:17             ` Vivek Gautam
2018-02-14  5:38               ` Tomasz Figa
2018-02-14  9:13                 ` Vivek Gautam
2018-02-14  9:16                   ` Tomasz Figa
2018-02-14 10:33                     ` Vivek Gautam
2018-02-14 16:03                       ` Robin Murphy
2018-02-15  3:17                         ` Tomasz Figa
2018-02-15  4:17                           ` Tomasz Figa
2018-02-15 17:14                             ` Robin Murphy
2018-02-16  0:13                               ` Tomasz Figa
2018-02-22  8:13                                 ` Tomasz Figa
2018-02-22 13:30                                   ` [Freedreno] " Rob Clark
2018-02-22 13:45                                 ` Robin Murphy
2018-02-22 14:12                                   ` Tomasz Figa
2018-02-22 17:24                                     ` Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65d707c0-76cc-d59e-ff18-1fdd89306900@arm.com \
    --to=robin.murphy@arm.com \
    --cc=airlied@linux.ie \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=tfiga@chromium.org \
    --cc=vivek.gautam@codeaurora.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®