mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Minor net/core/sock.c security issue?
Date: Fri, 27 Jul 2001 02:56:35 -0700 (PDT)	[thread overview]
Message-ID: <15201.15059.75725.225907@pizda.ninka.net> (raw)
In-Reply-To: <200107242224.CAA00437@mops.inr.ac.ru>
In-Reply-To: <15196.45004.237634.928656@pizda.ninka.net> <200107242224.CAA00437@mops.inr.ac.ru>


Alexey Kuznetsov writes:
 > > 1) have standard inline functions with names that suggest the
 > >    signedness, much like Rusty's netfilter macros.
 > 
 > min/max are macros. I do not know how to make a valid inline
 > for it: cast to long has problems with unsigned longs, cast to unsigned long
 > have the same problems with signedness.

For the time being I've just killed that bogus min define
from sock.c and also open-coded the min/max usage in the
rest of sock.c

This solves the original report, but later I'd like to do
something more satisfactory here.

I mean, grep for "define [min|max]" in just the networking
sources right now, yuck!

Later,
David S. Miller
davem@redhat.com

  parent reply	other threads:[~2001-07-27  9:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-23 22:24 Chris Evans
2001-07-23 23:14 ` David S. Miller
2001-07-24  3:02   ` Albert D. Cahalan
2001-07-24  3:41   ` David S. Miller
2001-07-24  4:55     ` Albert D. Cahalan
2001-07-24 22:24   ` Alexey Kuznetsov
2001-07-27  9:56   ` David S. Miller [this message]
2001-07-27 16:44     ` kuznet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15201.15059.75725.225907@pizda.ninka.net \
    --to=davem@redhat.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®