Re: Minor net/core/sock.c security issue?

[Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>]

Hello!

> 1) Signedness, what you have discovered.
> 
> 2) Arg evaluation.

Damn, I always assumed that min/max are macros and took into account #2,
which was painful sometimes. :-)

The fact that it is defined in sock.h (and the definition is truly
crazy, add #4: it is funny what happens on 64bit archs, when one of args
happens to be long) 


> 1) have standard inline functions with names that suggest the
>    signedness, much like Rusty's netfilter macros.

min/max are macros. I do not know how to make a valid inline
for it: cast to long has problems with unsigned longs, cast to unsigned long
have the same problems with signedness.


Alexey