From: kuznet@ms2.inr.ac.ru
To: davem@redhat.com (David S. Miller)
Cc: linux-kernel@vger.kernel.org
Subject: Re: Minor net/core/sock.c security issue?
Date: Fri, 27 Jul 2001 20:44:19 +0400 (MSK DST) [thread overview]
Message-ID: <200107271644.UAA18916@ms2.inr.ac.ru> (raw)
In-Reply-To: <15201.15059.75725.225907@pizda.ninka.net> from "David S. Miller" at Jul 27, 1 02:56:35 am
Hello!
> For the time being I've just killed that bogus min define
It is not bogus. Bogus one is in sock.h.
Hundred times I discovered that min/max are not defined in some place,
but was lazy to search for header where they are defined. :-)
> I mean, grep for "define [min|max]" in just the networking
> sources right now, yuck!
grep better for min/max. Everywhere min/max are assumed to be shortcut
for (a<b?a:b).
And if you find a place, which relied on that silly inline in sock.h,
I will wonder at first and die of shame the next minute. :-)
Alexey
prev parent reply other threads:[~2001-07-27 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-23 22:24 Chris Evans
2001-07-23 23:14 ` David S. Miller
2001-07-24 3:02 ` Albert D. Cahalan
2001-07-24 3:41 ` David S. Miller
2001-07-24 4:55 ` Albert D. Cahalan
2001-07-24 22:24 ` Alexey Kuznetsov
2001-07-27 9:56 ` David S. Miller
2001-07-27 16:44 ` kuznet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200107271644.UAA18916@ms2.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®