* [PATCH 3/3] drivers/speakup: kobjects : Fixed Coding issues -Debugging
@ 2018-07-05 2:12 Tamir Suliman
2018-07-07 14:05 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Tamir Suliman @ 2018-07-05 2:12 UTC (permalink / raw)
To: w.d.hubbs, speakup, gregkh; +Cc: dhowells, devel, linux-kernel, chris, tsuliman
Updated printk() of i18n messages to include KERN_INFO facility level to improve debuggin.
then later noticed that I forgot to add a space on printk.
Signed-off-by: Tamir Suliman <tsuliman@linuxvaults.com>
---
drivers/staging/speakup/kobjects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index 7e79f99..af664f0 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -740,7 +740,7 @@ static void report_msg_status(int reset, int received, int used,
snprintf(buf + (len - 1), sizeof(buf) - (len - 1),
" with %d reject%s\n",
rejected, rejected > 1 ? "s" : "");
- printk(KERN_INFO "i18n messages rejected\n",buf);
+ printk(KERN_INFO "i18n messages rejected\n", buf);
}
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] drivers/speakup: kobjects : Fixed Coding issues -Debugging
2018-07-05 2:12 [PATCH 3/3] drivers/speakup: kobjects : Fixed Coding issues -Debugging Tamir Suliman
@ 2018-07-07 14:05 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-07-07 14:05 UTC (permalink / raw)
To: Tamir Suliman; +Cc: w.d.hubbs, speakup, dhowells, devel, linux-kernel, chris
On Thu, Jul 05, 2018 at 02:12:20AM +0000, Tamir Suliman wrote:
> Updated printk() of i18n messages to include KERN_INFO facility level to improve debuggin.
> then later noticed that I forgot to add a space on printk.
>
> Signed-off-by: Tamir Suliman <tsuliman@linuxvaults.com>
> ---
> drivers/staging/speakup/kobjects.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 7e79f99..af664f0 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -740,7 +740,7 @@ static void report_msg_status(int reset, int received, int used,
> snprintf(buf + (len - 1), sizeof(buf) - (len - 1),
> " with %d reject%s\n",
> rejected, rejected > 1 ? "s" : "");
> - printk(KERN_INFO "i18n messages rejected\n",buf);
> + printk(KERN_INFO "i18n messages rejected\n", buf);
> }
> }
>
> --
> 1.8.3.1
Where are patches 1 and 2 of this series?
And the changelog text does not match what the text itself does, so I
can't take this as-is :(
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-07 14:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-05 2:12 [PATCH 3/3] drivers/speakup: kobjects : Fixed Coding issues -Debugging Tamir Suliman
2018-07-07 14:05 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®