From: Aubrey Li <aubrey.li@intel.com>
To: tglx@linutronix.de, mingo@redhat.com, peterz@infradead.org,
hpa@zytor.com
Cc: ak@linux.intel.com, tim.c.chen@linux.intel.com,
dave.hansen@intel.com, arjan@linux.intel.com,
aubrey.li@intel.com, linux-kernel@vger.kernel.org,
Aubrey Li <aubrey.li@linux.intel.com>
Subject: [PATCH v3 1/2] x86/fpu: track AVX-512 usage of tasks
Date: Thu, 15 Nov 2018 07:00:06 +0800 [thread overview]
Message-ID: <1542236407-4323-1-git-send-email-aubrey.li@intel.com> (raw)
User space tools which do automated task placement need information
about AVX-512 usage of tasks, because AVX-512 usage could cause core
turbo frequency drop and impact the running task on the sibling CPU.
XSAVE header contains a state-component bitmap, which allows software
to discover the state of the init optimization used by XSAVEOPT and
XSAVES. Set bits in the bitmap denotes the usage of the components.
AVX-512 component has 3 states, only Hi16_ZMM state causes notable
frequency drop. Add per task Hi16_ZMM state tracking to context switch.
The tracking turns on the usage flag immediately, but requires 3
consecutive context switches with no usage to clear it. This decay is
required because of AVX-512 using tasks could set Hi16_ZMM state back
to the init state themselves.
Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>
---
arch/x86/include/asm/fpu/internal.h | 26 ++++++++++++++++++++++++++
arch/x86/include/asm/fpu/types.h | 9 +++++++++
2 files changed, 35 insertions(+)
diff --git a/arch/x86/include/asm/fpu/internal.h b/arch/x86/include/asm/fpu/internal.h
index a38bf5a..f382449 100644
--- a/arch/x86/include/asm/fpu/internal.h
+++ b/arch/x86/include/asm/fpu/internal.h
@@ -275,6 +275,31 @@ static inline void copy_fxregs_to_kernel(struct fpu *fpu)
: "D" (st), "m" (*st), "a" (lmask), "d" (hmask) \
: "memory")
+#define HI16ZMM_STATE_DECAY_COUNT 3
+/*
+ * This function is called during context switch to update Hi16_ZMM state
+ */
+static inline void update_hi16zmm_state(struct fpu *fpu)
+{
+ /*
+ * XSAVE header contains a state-component bitmap(xfeatures),
+ * which allows software to discover the state of the init
+ * optimization used by XSAVEOPT and XSAVES.
+ *
+ * Hi16_ZMM state(one state of AVX-512 component) is tracked here
+ * because its usage could cause notable core turbo frequency drop.
+ *
+ * AVX512-using tasks could set Hi16_ZMM state back to the init
+ * state themselves. Thus, this tracking mechanism can miss.
+ * The decay usage ensures that false-negatives do not immediately
+ * make a task be considered as not using Hi16_ZMM registers.
+ */
+ if (fpu->state.xsave.header.xfeatures & XFEATURE_MASK_Hi16_ZMM)
+ fpu->hi16zmm_usage = HI16ZMM_STATE_DECAY_COUNT;
+ else if (fpu->hi16zmm_usage)
+ fpu->hi16zmm_usage--;
+}
+
/*
* This function is called only during boot time when x86 caps are not set
* up and alternative can not be used yet.
@@ -411,6 +436,7 @@ static inline int copy_fpregs_to_fpstate(struct fpu *fpu)
{
if (likely(use_xsave())) {
copy_xregs_to_kernel(&fpu->state.xsave);
+ update_hi16zmm_state(fpu);
return 1;
}
diff --git a/arch/x86/include/asm/fpu/types.h b/arch/x86/include/asm/fpu/types.h
index 202c539..c0c7577 100644
--- a/arch/x86/include/asm/fpu/types.h
+++ b/arch/x86/include/asm/fpu/types.h
@@ -303,6 +303,15 @@ struct fpu {
unsigned char initialized;
/*
+ * @hi16zmm_usage:
+ *
+ * Records the usage of the upper 16 AVX512 registers: ZMM16-ZMM31.
+ * A value of non-zero is used to indicate whether there is valid
+ * state in these AVX512 registers.
+ */
+ unsigned char hi16zmm_usage;
+
+ /*
* @state:
*
* In-memory copy of all FPU registers that we save/restore
--
2.7.4
next reply other threads:[~2018-11-15 6:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 23:00 Aubrey Li [this message]
2018-11-14 23:00 ` [PATCH v3 2/2] proc: add /proc/<pid>/arch_state Aubrey Li
2018-11-15 15:18 ` Dave Hansen
2018-11-16 0:32 ` Li, Aubrey
2018-11-19 17:39 ` Peter Zijlstra
2018-11-21 1:39 ` Li, Aubrey
2018-11-21 8:19 ` Peter Zijlstra
2018-11-21 9:53 ` Peter Zijlstra
2018-11-21 17:12 ` Palmer Dabbelt
2018-11-22 1:40 ` Li, Aubrey
2018-11-23 17:11 ` Dave Martin
2018-11-15 15:40 ` [PATCH v3 1/2] x86/fpu: track AVX-512 usage of tasks Dave Hansen
2018-11-16 0:21 ` Li, Aubrey
2018-11-16 1:04 ` Dave Hansen
2018-11-16 23:10 ` Dave Hansen
2018-11-17 0:36 ` Li, Aubrey
2018-11-18 14:03 Samuel Neves
2018-11-20 13:20 ` Li, Aubrey
2018-11-20 14:47 ` Samuel Neves
2018-11-26 3:36 ` Li, Aubrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542236407-4323-1-git-send-email-aubrey.li@intel.com \
--to=aubrey.li@intel.com \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®