From: "Li, Aubrey" <aubrey.li@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>, Aubrey Li <aubrey.li@intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
ak@linux.intel.com, tim.c.chen@linux.intel.com,
dave.hansen@intel.com, arjan@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] proc: add /proc/<pid>/arch_state
Date: Wed, 21 Nov 2018 09:39:00 +0800 [thread overview]
Message-ID: <c62acf67-2529-15b1-5325-e0265b0f613d@linux.intel.com> (raw)
In-Reply-To: <20181119173904.GC2131@hirez.programming.kicks-ass.net>
On 2018/11/20 1:39, Peter Zijlstra wrote:
> On Thu, Nov 15, 2018 at 07:00:07AM +0800, Aubrey Li wrote:
>> Add a /proc/<pid>/arch_state interface to expose per-task cpu specific
>> state values.
>>
>> Exposing AVX-512 Hi16_ZMM registers usage is for the user space job
>> scheduler to cluster AVX-512 using tasks together, because these tasks
>> could cause core turbo frequency drop.
>
> I still don't much like the name; how about arch_simd_state ?
My intention is
#cat /proc/<pid>/arch_state
0 1 0
Here, the first "0" denotes simd_state, and the second "1" denotes another
cpu specific feature(may come soon), and can be extended.
But sure I can limit it to simd_state and change the name in the patch.
>Also,
> since we're printing an integer, I still prefer we go print the turbo
> license level. I know level 1 isn't too interesting atm, but consider
> future hardware widening the thing again and us growing level 3 or
> something.
The problem is, FWICT, the bits in XSAVE buffer is not exactly mapped to
the turbo license level, so we can't print turbo license level correctly,
or the first patch need rework for that.
>
> Also; you were going to shop around with the other architectures to see
> what they want/need for this interface. I see nothing on that.
>
I'm open for your suggestion, :)
Thanks,
-Aubrey
next prev parent reply other threads:[~2018-11-21 1:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 23:00 [PATCH v3 1/2] x86/fpu: track AVX-512 usage of tasks Aubrey Li
2018-11-14 23:00 ` [PATCH v3 2/2] proc: add /proc/<pid>/arch_state Aubrey Li
2018-11-15 15:18 ` Dave Hansen
2018-11-16 0:32 ` Li, Aubrey
2018-11-19 17:39 ` Peter Zijlstra
2018-11-21 1:39 ` Li, Aubrey [this message]
2018-11-21 8:19 ` Peter Zijlstra
2018-11-21 9:53 ` Peter Zijlstra
2018-11-21 17:12 ` Palmer Dabbelt
2018-11-22 1:40 ` Li, Aubrey
2018-11-23 17:11 ` Dave Martin
2018-11-15 15:40 ` [PATCH v3 1/2] x86/fpu: track AVX-512 usage of tasks Dave Hansen
2018-11-16 0:21 ` Li, Aubrey
2018-11-16 1:04 ` Dave Hansen
2018-11-16 23:10 ` Dave Hansen
2018-11-17 0:36 ` Li, Aubrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c62acf67-2529-15b1-5325-e0265b0f613d@linux.intel.com \
--to=aubrey.li@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=aubrey.li@intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome