mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Hannes Eder" <hannes@hanneseder.net>
To: "Julia Lawall" <julia@diku.dk>,
	"Jaswinder Singh Rajput" <jaswinder@kernel.org>
Cc: dri-devel@lists.sourceforge.net, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] drivers/gpu/drm: fix sparse warnings: unexport symbols
Date: Sun, 18 Jan 2009 18:42:06 +0100	[thread overview]
Message-ID: <154e089b0901180942o46b80006q5e0d586cb3e1841c@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0901181710000.661@ask.diku.dk>

On Sun, Jan 18, 2009 at 5:11 PM, Julia Lawall <julia@diku.dk> wrote:
> I don't know anything about this specific context, but aren't things in
> general exported so that external modules can use them?  If that is the
> case, grepping over the kernel sources is not sufficient.

Good point, but it indicates that the function does not have a caller
within kernel tree.
Ok, there could be other clients.  So this patch might just be a hint
for the original author or maintainer that there is maybe no need to
export this function.

On Sun, Jan 18, 2009 at 5:18 PM, Jaswinder Singh Rajput
<jaswinder@kernel.org> wrote:
> If it is EXPORTED you cannot make it static. EXPORTED means it can be
> used from a kernel module.

Right, that's why I have made it static and removed the EXPORT_SYMBOL,
all under the assumption that there is _no_ client for this function,
but there may be some outside the kernel tree.  I can not judge this.

Hannes

  reply	other threads:[~2009-01-18 17:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-18 15:28 [PATCH 0/3] drivers/gpu/drm: fix (sparse) warnings Hannes Eder
2009-01-18 15:28 ` [PATCH 1/3] drivers/gpu/drm: fix sparse warnings: make symbols static Hannes Eder
2009-02-27  0:54   ` Hannes Eder
2009-01-18 15:28 ` [PATCH 2/3] drivers/gpu/drm: fix sparse warnings: unexport symbols Hannes Eder
2009-01-18 15:56   ` Jaswinder Singh Rajput
2009-01-18 16:04     ` Hannes Eder
2009-01-18 16:11       ` Julia Lawall
2009-01-18 17:42         ` Hannes Eder [this message]
2009-01-18 16:18       ` Jaswinder Singh Rajput
2009-01-18 15:28 ` [PATCH 3/3] drivers/gpu/drm: comment out dead code Hannes Eder
2009-02-27  0:55   ` Hannes Eder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154e089b0901180942o46b80006q5e0d586cb3e1841c@mail.gmail.com \
    --to=hannes@hanneseder.net \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=jaswinder@kernel.org \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®