mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Eder <hannes@hanneseder.net>
To: dri-devel@lists.sourceforge.net, Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] drivers/gpu/drm: comment out dead code
Date: Fri, 27 Feb 2009 01:55:30 +0100	[thread overview]
Message-ID: <154e089b0902261655j17cf1fc3vaf254d0c2af74616@mail.gmail.com> (raw)
In-Reply-To: <20090118152856.4179.91855.stgit@vmbox.hanneseder.net>

[Added To]

On Sun, Jan 18, 2009 at 4:28 PM, Hannes Eder <hannes@hanneseder.net> wrote:
> The functions:
>
>  drm_crtc_from_fb
>  drm_mode_validate_clocks
>
> are not used, so comment them out.
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
> ---
>  drivers/gpu/drm/drm_crtc.c  |    2 ++
>  drivers/gpu/drm/drm_modes.c |    2 ++
>  2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index d378306..c44bbde 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -254,6 +254,7 @@ void *drm_mode_object_find(struct drm_device *dev, uint32_t id, uint32_t type)
>  }
>  EXPORT_SYMBOL(drm_mode_object_find);
>
> +#ifdef UNUSED
>  /**
>  * drm_crtc_from_fb - find the CRTC structure associated with an fb
>  * @dev: DRM device
> @@ -278,6 +279,7 @@ static struct drm_crtc *drm_crtc_from_fb(struct drm_device *dev,
>        }
>        return NULL;
>  }
> +#endif /* UNUSED */
>
>  /**
>  * drm_framebuffer_init - initialize a framebuffer
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> index c0cfe39..8ebcf51 100644
> --- a/drivers/gpu/drm/drm_modes.c
> +++ b/drivers/gpu/drm/drm_modes.c
> @@ -341,6 +341,7 @@ void drm_mode_validate_size(struct drm_device *dev,
>  }
>  EXPORT_SYMBOL(drm_mode_validate_size);
>
> +#ifdef UNUSED
>  /**
>  * drm_mode_validate_clocks - validate modes against clock limits
>  * @dev: DRM device
> @@ -376,6 +377,7 @@ static void drm_mode_validate_clocks(struct drm_device *dev,
>                        mode->status = MODE_CLOCK_RANGE;
>        }
>  }
> +#endif /* UNUSED */
>
>  /**
>  * drm_mode_prune_invalid - remove invalid modes from mode list
>
>

      reply	other threads:[~2009-02-27  0:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-18 15:28 [PATCH 0/3] drivers/gpu/drm: fix (sparse) warnings Hannes Eder
2009-01-18 15:28 ` [PATCH 1/3] drivers/gpu/drm: fix sparse warnings: make symbols static Hannes Eder
2009-02-27  0:54   ` Hannes Eder
2009-01-18 15:28 ` [PATCH 2/3] drivers/gpu/drm: fix sparse warnings: unexport symbols Hannes Eder
2009-01-18 15:56   ` Jaswinder Singh Rajput
2009-01-18 16:04     ` Hannes Eder
2009-01-18 16:11       ` Julia Lawall
2009-01-18 17:42         ` Hannes Eder
2009-01-18 16:18       ` Jaswinder Singh Rajput
2009-01-18 15:28 ` [PATCH 3/3] drivers/gpu/drm: comment out dead code Hannes Eder
2009-02-27  0:55   ` Hannes Eder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154e089b0902261655j17cf1fc3vaf254d0c2af74616@mail.gmail.com \
    --to=hannes@hanneseder.net \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®