From: Hannes Eder <hannes@hanneseder.net>
To: dri-devel@lists.sourceforge.net
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] drivers/gpu/drm: fix sparse warnings: unexport symbols
Date: Sun, 18 Jan 2009 16:28:48 +0100 [thread overview]
Message-ID: <20090118152848.4179.85741.stgit@vmbox.hanneseder.net> (raw)
In-Reply-To: <20090118152725.4179.40835.stgit@vmbox.hanneseder.net>
Fix this sparse warnings:
drivers/gpu/drm/drm_crtc_helper.c:137:6: warning: symbol 'drm_helper_probe_connector_modes' was not declared. Should it be static?
drivers/gpu/drm/drm_modes.c:360:6: warning: symbol 'drm_mode_validate_clocks' was not declared. Should it be static?
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
drivers/gpu/drm/drm_crtc_helper.c | 6 +++---
drivers/gpu/drm/drm_modes.c | 7 +++----
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index d8a982b..a0b2601 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -134,8 +134,9 @@ void drm_helper_probe_single_connector_modes(struct drm_connector *connector,
}
EXPORT_SYMBOL(drm_helper_probe_single_connector_modes);
-void drm_helper_probe_connector_modes(struct drm_device *dev, uint32_t maxX,
- uint32_t maxY)
+static void drm_helper_probe_connector_modes(struct drm_device *dev,
+ uint32_t maxX,
+ uint32_t maxY)
{
struct drm_connector *connector;
@@ -143,7 +144,6 @@ void drm_helper_probe_connector_modes(struct drm_device *dev, uint32_t maxX,
drm_helper_probe_single_connector_modes(connector, maxX, maxY);
}
}
-EXPORT_SYMBOL(drm_helper_probe_connector_modes);
/**
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 7c36f16..c0cfe39 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -357,9 +357,9 @@ EXPORT_SYMBOL(drm_mode_validate_size);
* sure each mode falls within a given range (defined by @min and @max
* arrays) and sets @mode->status as needed.
*/
-void drm_mode_validate_clocks(struct drm_device *dev,
- struct list_head *mode_list,
- int *min, int *max, int n_ranges)
+static void drm_mode_validate_clocks(struct drm_device *dev,
+ struct list_head *mode_list,
+ int *min, int *max, int n_ranges)
{
struct drm_display_mode *mode;
int i;
@@ -376,7 +376,6 @@ void drm_mode_validate_clocks(struct drm_device *dev,
mode->status = MODE_CLOCK_RANGE;
}
}
-EXPORT_SYMBOL(drm_mode_validate_clocks);
/**
* drm_mode_prune_invalid - remove invalid modes from mode list
next prev parent reply other threads:[~2009-01-18 15:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-18 15:28 [PATCH 0/3] drivers/gpu/drm: fix (sparse) warnings Hannes Eder
2009-01-18 15:28 ` [PATCH 1/3] drivers/gpu/drm: fix sparse warnings: make symbols static Hannes Eder
2009-02-27 0:54 ` Hannes Eder
2009-01-18 15:28 ` Hannes Eder [this message]
2009-01-18 15:56 ` [PATCH 2/3] drivers/gpu/drm: fix sparse warnings: unexport symbols Jaswinder Singh Rajput
2009-01-18 16:04 ` Hannes Eder
2009-01-18 16:11 ` Julia Lawall
2009-01-18 17:42 ` Hannes Eder
2009-01-18 16:18 ` Jaswinder Singh Rajput
2009-01-18 15:28 ` [PATCH 3/3] drivers/gpu/drm: comment out dead code Hannes Eder
2009-02-27 0:55 ` Hannes Eder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090118152848.4179.85741.stgit@vmbox.hanneseder.net \
--to=hannes@hanneseder.net \
--cc=dri-devel@lists.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®