[PATCH] init/main.c: fix sparse warnings: context imbalance

[PATCH] init/main.c: fix sparse warnings: context imbalance

[Hannes Eder]

Impact: Attribute function 'init_post' with __releases(...).

Fix this sparse warnings:
  init/main.c:805:21: warning: context imbalance in 'init_post' - unexpected unlock
  init/main.c:899:9: warning: context imbalance in 'kernel_init' - wrong count at exit

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
 init/main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/init/main.c b/init/main.c
index 82456a9..fe53aa6 100644
--- a/init/main.c
+++ b/init/main.c
@@ -803,6 +803,7 @@ int initmem_now_dynamic;
  * makes it inline to init() and it becomes part of init.text section
  */
 static noinline int init_post(void)
+	__releases(kernel_lock)
 {
 	/* need to finish all async __init code before freeing the memory */
 	async_synchronize_full();

Re: [PATCH] init/main.c: fix sparse warnings: context imbalance

[Stefan Richter]

Hannes Eder wrote:
> Impact: Attribute function 'init_post' with __releases(...).
> 
> Fix this sparse warnings:

It is not a fix, it's merely an annotation.
-- 
Stefan Richter
-=====-==--= --=- =-==-
http://arcgraph.de/sr/

Re: [PATCH] init/main.c: fix sparse warnings: context imbalance

[Hannes Eder]

On Sun, Feb 22, 2009 at 12:30 PM, Stefan Richter
<stefanr@s5r6.in-berlin.de> wrote:
> Hannes Eder wrote:
>> Impact: Attribute function 'init_post' with __releases(...).
>>
>> Fix this sparse warnings:
>
> It is not a fix, it's merely an annotation.

This patch 'better word for fix's a warning reported by sparse. What
better wording would you suggest?

Thanks, -Hannes

Re: [PATCH] init/main.c: fix sparse warnings: context imbalance

[Stefan Richter]

Hannes Eder wrote:
> On Sun, Feb 22, 2009 at 12:30 PM, Stefan Richter
> <stefanr@s5r6.in-berlin.de> wrote:
>> It is not a fix, it's merely an annotation.
> 
> This patch 'better word for fix's a warning reported by sparse. What
> better wording would you suggest?

"annotate init_post() as releasing the BKL" or whatever in the title,
furthermore "Removes the following sparse warnings: ..." in the changelog.
-- 
Stefan Richter
-=====-==--= --=- =-==-
http://arcgraph.de/sr/

Re: [PATCH] init/main.c: fix sparse warnings: context imbalance

[Stefan Richter]

Stefan Richter wrote:
> Hannes Eder wrote:
>> On Sun, Feb 22, 2009 at 12:30 PM, Stefan Richter
>> <stefanr@s5r6.in-berlin.de> wrote:
>>> It is not a fix, it's merely an annotation.
>> This patch 'better word for fix's a warning reported by sparse. What
>> better wording would you suggest?
> 
> "annotate init_post() as releasing the BKL" or whatever in the title,
> furthermore "Removes the following sparse warnings: ..." in the changelog.

PS:  In some sense it is indeed a "fix" for the high-level problem that
sparse can't guess whether the context imbalance is correct or not.  The
original warning from sparse was correct in itself.  Your annotation
enables sparse to warn if problems outside the scope of the single
function occur (I guess).  So it's more a maintainabiliy improvement
than a fix.
-- 
Stefan Richter
-=====-==--= --=- =-==-
http://arcgraph.de/sr/

[PATCH v2] init/main.c: annotate 'init_post' with '__releases(kernel_lock)'

[Hannes Eder]

This fixes the following sparse warnings:
  init/main.c:805:21: warning: context imbalance in 'init_post' - unexpected unlock
  init/main.c:899:9: warning: context imbalance in 'kernel_init' - wrong count at exit

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
 init/main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/init/main.c b/init/main.c
index 82456a9..fe53aa6 100644
--- a/init/main.c
+++ b/init/main.c
@@ -803,6 +803,7 @@ int initmem_now_dynamic;
  * makes it inline to init() and it becomes part of init.text section
  */
 static noinline int init_post(void)
+	__releases(kernel_lock)
 {
 	/* need to finish all async __init code before freeing the memory */
 	async_synchronize_full();