From: John Garry <john.garry@huawei.com>
To: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>
Cc: <linuxarm@huawei.com>, <linux-kernel@vger.kernel.org>,
<linux-scsi@vger.kernel.org>,
Xiang Chen <chenxiang66@hisilicon.com>,
"John Garry" <john.garry@huawei.com>
Subject: [PATCH 1/6] scsi: hisi_sas: Change return variable type in phy_up_v3_hw()
Date: Thu, 28 Feb 2019 22:50:57 +0800 [thread overview]
Message-ID: <1551365462-128193-2-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1551365462-128193-1-git-send-email-john.garry@huawei.com>
From: Xiang Chen <chenxiang66@hisilicon.com>
According to the tool fortify, phy_up_v3_hw() returns signed
value, while it should return an unsigned value.
So change variable "res" from int to irq_return_t.
Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: John Garry <john.garry@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
index 00738d0673fe..151a102c4cc7 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
@@ -1344,7 +1344,8 @@ static void prep_abort_v3_hw(struct hisi_hba *hisi_hba,
static irqreturn_t phy_up_v3_hw(int phy_no, struct hisi_hba *hisi_hba)
{
- int i, res;
+ int i;
+ irqreturn_t res;
u32 context, port_id, link_rate;
struct hisi_sas_phy *phy = &hisi_hba->phy[phy_no];
struct asd_sas_phy *sas_phy = &phy->sas_phy;
--
2.17.1
next prev parent reply other threads:[~2019-02-28 14:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 14:50 [PATCH 0/6] hisi_sas: Some misc patches John Garry
2019-02-28 14:50 ` John Garry [this message]
2019-02-28 14:50 ` [PATCH 2/6] scsi: hisi_sas: Fix a timeout race of driver internal and SMP IO John Garry
2019-02-28 14:50 ` [PATCH 3/6] scsi: hisi_sas: print PHY RX errors count for later revision of v3 hw John Garry
2019-02-28 14:51 ` [PATCH 4/6] scsi: hisi_sas: Set PHY linkrate when disconnected John Garry
2019-02-28 14:51 ` [PATCH 5/6] scsi: hisi_sas: Send HARD RESET to clear the previous affiliation of STP target port John Garry
2019-02-28 14:51 ` [PATCH 6/6] scsi: hisi_sas: Change SERDES_CFG init value to increase reliability of HiLink John Garry
2019-03-07 0:27 ` [PATCH 0/6] hisi_sas: Some misc patches Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551365462-128193-2-git-send-email-john.garry@huawei.com \
--to=john.garry@huawei.com \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®