From: Fenghua Yu <fenghua.yu@intel.com>
To: "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>, "H Peter Anvin" <hpa@zytor.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Ashok Raj" <ashok.raj@intel.com>,
"Tony Luck" <tony.luck@intel.com>,
"Ravi V Shankar" <ravi.v.shankar@intel.com>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
"x86" <x86@kernel.org>, Fenghua Yu <fenghua.yu@intel.com>
Subject: [PATCH v4 4/5] x86/umwait: Add sysfs interface to control umwait maximum time
Date: Fri, 7 Jun 2019 15:00:36 -0700 [thread overview]
Message-ID: <1559944837-149589-5-git-send-email-fenghua.yu@intel.com> (raw)
In-Reply-To: <1559944837-149589-1-git-send-email-fenghua.yu@intel.com>
IA32_UMWAIT_CONTROL[31:2] determines the maximum time in TSC-quanta
that processor can stay in C0.1 or C0.2. A zero value means no maximum
time.
Each instruction sets its own deadline in the instruction's implicit
input EDX:EAX value. The instruction wakes up if the time-stamp counter
reaches or exceeds the specified deadline, or the umwait maximum time
expires, or a store happens in the monitored address range in umwait.
Users can write an unsigned 32-bit number to
/sys/devices/system/cpu/umwait_control/max_time to change the default
value. Note that a value of zero means there is no limit. Low order
two bits must be zero.
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Ashok Raj <ashok.raj@intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
---
arch/x86/power/umwait.c | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/arch/x86/power/umwait.c b/arch/x86/power/umwait.c
index 9c176f3e59b6..7fa381e3fd4e 100644
--- a/arch/x86/power/umwait.c
+++ b/arch/x86/power/umwait.c
@@ -104,8 +104,47 @@ static ssize_t enable_c02_store(struct device *dev,
}
static DEVICE_ATTR_RW(enable_c02);
+static ssize_t
+max_time_show(struct device *kobj, struct device_attribute *attr, char *buf)
+{
+ return sprintf(buf, "%u\n", get_umwait_control_max_time());
+}
+
+static ssize_t max_time_store(struct device *kobj,
+ struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ u32 max_time;
+ int ret;
+
+ ret = kstrtou32(buf, 0, &max_time);
+ if (ret)
+ return ret;
+
+ /* bits[1:0] must be zero */
+ if (max_time & ~MSR_IA32_UMWAIT_CONTROL_MAX_TIME)
+ return -EINVAL;
+
+ mutex_lock(&umwait_lock);
+
+ if (max_time == get_umwait_control_max_time())
+ goto out_unlock;
+
+ umwait_control_cached = max_time | get_umwait_control_c02();
+
+ /* Update umwait max time on all CPUs */
+ on_each_cpu(umwait_control_msr_update, NULL, 1);
+
+out_unlock:
+ mutex_unlock(&umwait_lock);
+
+ return count;
+}
+static DEVICE_ATTR_RW(max_time);
+
static struct attribute *umwait_attrs[] = {
&dev_attr_enable_c02.attr,
+ &dev_attr_max_time.attr,
NULL
};
--
2.19.1
next prev parent reply other threads:[~2019-06-07 22:10 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 22:00 [PATCH v4 0/5] x86/umwait: Enable user wait instructions Fenghua Yu
2019-06-07 22:00 ` [PATCH v4 1/5] x86/cpufeatures: Enumerate " Fenghua Yu
2019-06-07 22:00 ` [PATCH v4 2/5] x86/umwait: Initialize umwait control values Fenghua Yu
2019-06-08 22:52 ` Andy Lutomirski
2019-06-10 4:13 ` Fenghua Yu
2019-06-10 4:27 ` Andy Lutomirski
2019-06-11 20:46 ` Thomas Gleixner
2019-06-17 20:46 ` Fenghua Yu
2019-06-18 5:43 ` Thomas Gleixner
2019-06-11 8:50 ` Peter Zijlstra
2019-06-11 17:04 ` Fenghua Yu
2019-06-07 22:00 ` [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state Fenghua Yu
2019-06-08 22:50 ` Andy Lutomirski
2019-06-10 3:53 ` Fenghua Yu
2019-06-10 4:24 ` Andy Lutomirski
2019-06-10 6:02 ` Fenghua Yu
2019-06-10 13:41 ` Andy Lutomirski
2019-06-17 20:27 ` Fenghua Yu
2019-06-17 23:02 ` Andy Lutomirski
2019-06-17 23:11 ` Fenghua Yu
2019-06-17 23:41 ` Andy Lutomirski
2019-06-18 0:00 ` Fenghua Yu
2019-06-18 0:19 ` Andy Lutomirski
2019-06-18 2:32 ` Fenghua Yu
2019-06-08 22:52 ` Andy Lutomirski
2019-06-10 4:04 ` Fenghua Yu
2019-06-10 4:26 ` Andy Lutomirski
2019-06-17 22:48 ` Fenghua Yu
2019-06-17 22:59 ` Andy Lutomirski
2019-06-17 22:51 ` Fenghua Yu
2019-06-11 8:54 ` Peter Zijlstra
2019-06-11 16:04 ` Andy Lutomirski
2019-06-11 17:27 ` Peter Zijlstra
2019-06-17 15:14 ` Andy Lutomirski
2019-06-17 18:11 ` Fenghua Yu
2019-06-07 22:00 ` Fenghua Yu [this message]
2019-06-07 22:00 ` [PATCH v4 5/5] x86/umwait: Document umwait control sysfs interfaces Fenghua Yu
2019-06-11 9:01 ` [PATCH v4 0/5] x86/umwait: Enable user wait instructions Peter Zijlstra
2019-06-11 17:37 ` Fenghua Yu
2019-06-17 14:19 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559944837-149589-5-git-send-email-fenghua.yu@intel.com \
--to=fenghua.yu@intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome