From: Thomas Gleixner <tglx@linutronix.de>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, H Peter Anvin <hpa@zytor.com>,
Ashok Raj <ashok.raj@intel.com>, Tony Luck <tony.luck@intel.com>,
Ravi V Shankar <ravi.v.shankar@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH v4 2/5] x86/umwait: Initialize umwait control values
Date: Tue, 18 Jun 2019 07:43:48 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1906180741440.1963@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190617204619.GC217081@romley-ivt3.sc.intel.com>
On Mon, 17 Jun 2019, Fenghua Yu wrote:
> On Tue, Jun 11, 2019 at 10:46:55PM +0200, Thomas Gleixner wrote:
> > On Sun, 9 Jun 2019, Fenghua Yu wrote:
> > > > Sounds good, but:
> > > >
> > > > > +#define MSR_IA32_UMWAIT_CONTROL_C02 BIT(0)
> > > >
> > > > > +static u32 umwait_control_cached = 100000;
> > > >
> > > > The code seems to disagree.
> > >
> > > The definition of bit[0] is: C0.2 is disabled when bit[0]=1. So
> > > 100000 means C0.2 is enabled (and max time is 100000).
> >
> > which is totally non obvious. If you have to encode the control bit, then
> > please make it explicit, i.e. mask out the disable bit in the initializer.
>
> Is this right?
>
> static u32 umwait_control_cached = 100000 & ~MSR_IA32_UMWAIT_CONTROL_C02_DISABLED;
Works, but looks pretty odd. I'd rather create an explicit initializer
macro, something like:
UMWAIT_CTRL_VAL(100000, UMWAIT_DISABLED);
Hmm?
Thanks,
tglx
next prev parent reply other threads:[~2019-06-18 7:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 22:00 [PATCH v4 0/5] x86/umwait: Enable user wait instructions Fenghua Yu
2019-06-07 22:00 ` [PATCH v4 1/5] x86/cpufeatures: Enumerate " Fenghua Yu
2019-06-07 22:00 ` [PATCH v4 2/5] x86/umwait: Initialize umwait control values Fenghua Yu
2019-06-08 22:52 ` Andy Lutomirski
2019-06-10 4:13 ` Fenghua Yu
2019-06-10 4:27 ` Andy Lutomirski
2019-06-11 20:46 ` Thomas Gleixner
2019-06-17 20:46 ` Fenghua Yu
2019-06-18 5:43 ` Thomas Gleixner [this message]
2019-06-11 8:50 ` Peter Zijlstra
2019-06-11 17:04 ` Fenghua Yu
2019-06-07 22:00 ` [PATCH v4 3/5] x86/umwait: Add sysfs interface to control umwait C0.2 state Fenghua Yu
2019-06-08 22:50 ` Andy Lutomirski
2019-06-10 3:53 ` Fenghua Yu
2019-06-10 4:24 ` Andy Lutomirski
2019-06-10 6:02 ` Fenghua Yu
2019-06-10 13:41 ` Andy Lutomirski
2019-06-17 20:27 ` Fenghua Yu
2019-06-17 23:02 ` Andy Lutomirski
2019-06-17 23:11 ` Fenghua Yu
2019-06-17 23:41 ` Andy Lutomirski
2019-06-18 0:00 ` Fenghua Yu
2019-06-18 0:19 ` Andy Lutomirski
2019-06-18 2:32 ` Fenghua Yu
2019-06-08 22:52 ` Andy Lutomirski
2019-06-10 4:04 ` Fenghua Yu
2019-06-10 4:26 ` Andy Lutomirski
2019-06-17 22:48 ` Fenghua Yu
2019-06-17 22:59 ` Andy Lutomirski
2019-06-17 22:51 ` Fenghua Yu
2019-06-11 8:54 ` Peter Zijlstra
2019-06-11 16:04 ` Andy Lutomirski
2019-06-11 17:27 ` Peter Zijlstra
2019-06-17 15:14 ` Andy Lutomirski
2019-06-17 18:11 ` Fenghua Yu
2019-06-07 22:00 ` [PATCH v4 4/5] x86/umwait: Add sysfs interface to control umwait maximum time Fenghua Yu
2019-06-07 22:00 ` [PATCH v4 5/5] x86/umwait: Document umwait control sysfs interfaces Fenghua Yu
2019-06-11 9:01 ` [PATCH v4 0/5] x86/umwait: Enable user wait instructions Peter Zijlstra
2019-06-11 17:37 ` Fenghua Yu
2019-06-17 14:19 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1906180741440.1963@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®