* [PATCH] ACPI: SRAT: report non-volatile memory in debug
@ 2013-01-09 0:15 Davidlohr Bueso
2013-01-09 0:34 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Davidlohr Bueso @ 2013-01-09 0:15 UTC (permalink / raw)
To: Len Brown, Rafael J. Wysocki; +Cc: linux-acpi, linux-kernel
Just as with the other memory affinity flags, report
non-volatile memory with ACPI debug.
Signed-off-by: Davidlohr Bueso <davidlohr.bueso@hp.com>
---
drivers/acpi/numa.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
index cb31298..68077ac 100644
--- a/drivers/acpi/numa.c
+++ b/drivers/acpi/numa.c
@@ -116,12 +116,14 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
struct acpi_srat_mem_affinity *p =
(struct acpi_srat_mem_affinity *)header;
ACPI_DEBUG_PRINT((ACPI_DB_INFO,
- "SRAT Memory (0x%lx length 0x%lx) in proximity domain %d %s%s\n",
+ "SRAT Memory (0x%lx length 0x%lx) in proximity domain %d %s%s%s\n",
(unsigned long)p->base_address,
(unsigned long)p->length,
p->proximity_domain,
(p->flags & ACPI_SRAT_MEM_ENABLED)?
"enabled" : "disabled",
+ (p->flags & ACPI_SRAT_MEM_NON_VOLATILE)?
+ " non-volatile" : "",
(p->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)?
" hot-pluggable" : ""));
}
--
1.7.11.7
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI: SRAT: report non-volatile memory in debug
2013-01-09 0:15 [PATCH] ACPI: SRAT: report non-volatile memory in debug Davidlohr Bueso
@ 2013-01-09 0:34 ` Rafael J. Wysocki
2013-01-09 0:29 ` Davidlohr Bueso
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2013-01-09 0:34 UTC (permalink / raw)
To: Davidlohr Bueso; +Cc: Len Brown, linux-acpi, linux-kernel
On Tuesday, January 08, 2013 04:15:56 PM Davidlohr Bueso wrote:
> Just as with the other memory affinity flags, report
> non-volatile memory with ACPI debug.
Looks kind of good, but ->
> Signed-off-by: Davidlohr Bueso <davidlohr.bueso@hp.com>
> ---
> drivers/acpi/numa.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
> index cb31298..68077ac 100644
> --- a/drivers/acpi/numa.c
> +++ b/drivers/acpi/numa.c
> @@ -116,12 +116,14 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
> struct acpi_srat_mem_affinity *p =
> (struct acpi_srat_mem_affinity *)header;
> ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> - "SRAT Memory (0x%lx length 0x%lx) in proximity domain %d %s%s\n",
> + "SRAT Memory (0x%lx length 0x%lx) in proximity domain %d %s%s%s\n",
> (unsigned long)p->base_address,
> (unsigned long)p->length,
> p->proximity_domain,
> (p->flags & ACPI_SRAT_MEM_ENABLED)?
> "enabled" : "disabled",
> + (p->flags & ACPI_SRAT_MEM_NON_VOLATILE)?
> + " non-volatile" : "",
-> why did you put non-volatile before hot-pluggable?
> (p->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)?
> " hot-pluggable" : ""));
> }
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI: SRAT: report non-volatile memory in debug
2013-01-09 0:34 ` Rafael J. Wysocki
@ 2013-01-09 0:29 ` Davidlohr Bueso
2013-01-09 20:57 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Davidlohr Bueso @ 2013-01-09 0:29 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Len Brown, linux-acpi, linux-kernel
On Wed, 2013-01-09 at 01:34 +0100, Rafael J. Wysocki wrote:
> On Tuesday, January 08, 2013 04:15:56 PM Davidlohr Bueso wrote:
> > Just as with the other memory affinity flags, report
> > non-volatile memory with ACPI debug.
>
> Looks kind of good, but ->
>
> > Signed-off-by: Davidlohr Bueso <davidlohr.bueso@hp.com>
> > ---
> > drivers/acpi/numa.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
> > index cb31298..68077ac 100644
> > --- a/drivers/acpi/numa.c
> > +++ b/drivers/acpi/numa.c
> > @@ -116,12 +116,14 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
> > struct acpi_srat_mem_affinity *p =
> > (struct acpi_srat_mem_affinity *)header;
> > ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> > - "SRAT Memory (0x%lx length 0x%lx) in proximity domain %d %s%s\n",
> > + "SRAT Memory (0x%lx length 0x%lx) in proximity domain %d %s%s%s\n",
> > (unsigned long)p->base_address,
> > (unsigned long)p->length,
> > p->proximity_domain,
> > (p->flags & ACPI_SRAT_MEM_ENABLED)?
> > "enabled" : "disabled",
> > + (p->flags & ACPI_SRAT_MEM_NON_VOLATILE)?
> > + " non-volatile" : "",
>
> -> why did you put non-volatile before hot-pluggable?
No particular reason. Should I send a v2 with non-volatile at the end?
>
> > (p->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)?
> > " hot-pluggable" : ""));
> > }
>
> Rafael
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI: SRAT: report non-volatile memory in debug
2013-01-09 0:29 ` Davidlohr Bueso
@ 2013-01-09 20:57 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2013-01-09 20:57 UTC (permalink / raw)
To: Davidlohr Bueso; +Cc: Len Brown, linux-acpi, linux-kernel
On Tuesday, January 08, 2013 04:29:35 PM Davidlohr Bueso wrote:
> On Wed, 2013-01-09 at 01:34 +0100, Rafael J. Wysocki wrote:
> > On Tuesday, January 08, 2013 04:15:56 PM Davidlohr Bueso wrote:
> > > Just as with the other memory affinity flags, report
> > > non-volatile memory with ACPI debug.
> >
> > Looks kind of good, but ->
> >
> > > Signed-off-by: Davidlohr Bueso <davidlohr.bueso@hp.com>
> > > ---
> > > drivers/acpi/numa.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
> > > index cb31298..68077ac 100644
> > > --- a/drivers/acpi/numa.c
> > > +++ b/drivers/acpi/numa.c
> > > @@ -116,12 +116,14 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
> > > struct acpi_srat_mem_affinity *p =
> > > (struct acpi_srat_mem_affinity *)header;
> > > ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> > > - "SRAT Memory (0x%lx length 0x%lx) in proximity domain %d %s%s\n",
> > > + "SRAT Memory (0x%lx length 0x%lx) in proximity domain %d %s%s%s\n",
> > > (unsigned long)p->base_address,
> > > (unsigned long)p->length,
> > > p->proximity_domain,
> > > (p->flags & ACPI_SRAT_MEM_ENABLED)?
> > > "enabled" : "disabled",
> > > + (p->flags & ACPI_SRAT_MEM_NON_VOLATILE)?
> > > + " non-volatile" : "",
> >
> > -> why did you put non-volatile before hot-pluggable?
>
> No particular reason. Should I send a v2 with non-volatile at the end?
Yes, please.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-09 20:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-09 0:15 [PATCH] ACPI: SRAT: report non-volatile memory in debug Davidlohr Bueso
2013-01-09 0:34 ` Rafael J. Wysocki
2013-01-09 0:29 ` Davidlohr Bueso
2013-01-09 20:57 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®