* [PATCH] tools/bootconfig: Makefile: Create destination directory
@ 2020-03-16 15:49 Adriana Kobylak
2020-03-17 13:15 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Adriana Kobylak @ 2020-03-16 15:49 UTC (permalink / raw)
To: mhiramat; +Cc: linux-kernel, anoo
From: Adriana Kobylak <anoo@us.ibm.com>
The DESTDIR path may not be available to the caller, such as
compiling the bootconfig tool from a Yocto native recipe. Have
the Makefile create the directory instead.
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
---
tools/bootconfig/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/bootconfig/Makefile b/tools/bootconfig/Makefile
index a6146ac..470b6f0 100644
--- a/tools/bootconfig/Makefile
+++ b/tools/bootconfig/Makefile
@@ -14,6 +14,7 @@ bootconfig: ../../lib/bootconfig.c main.c $(HEADER)
$(CC) $(filter %.c,$^) $(CFLAGS) -o $@
install: $(PROGS)
+ install -d $(DESTDIR)$(bindir)
install bootconfig $(DESTDIR)$(bindir)
test: bootconfig
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tools/bootconfig: Makefile: Create destination directory
2020-03-16 15:49 [PATCH] tools/bootconfig: Makefile: Create destination directory Adriana Kobylak
@ 2020-03-17 13:15 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2020-03-17 13:15 UTC (permalink / raw)
To: Adriana Kobylak, Steven Rostedt; +Cc: linux-kernel, anoo
On Mon, 16 Mar 2020 10:49:26 -0500
Adriana Kobylak <anoo@linux.ibm.com> wrote:
> From: Adriana Kobylak <anoo@us.ibm.com>
>
> The DESTDIR path may not be available to the caller, such as
> compiling the bootconfig tool from a Yocto native recipe. Have
> the Makefile create the directory instead.
OK, this looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
>
> Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
> ---
> tools/bootconfig/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/bootconfig/Makefile b/tools/bootconfig/Makefile
> index a6146ac..470b6f0 100644
> --- a/tools/bootconfig/Makefile
> +++ b/tools/bootconfig/Makefile
> @@ -14,6 +14,7 @@ bootconfig: ../../lib/bootconfig.c main.c $(HEADER)
> $(CC) $(filter %.c,$^) $(CFLAGS) -o $@
>
> install: $(PROGS)
> + install -d $(DESTDIR)$(bindir)
> install bootconfig $(DESTDIR)$(bindir)
>
> test: bootconfig
> --
> 1.8.3.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-17 13:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-16 15:49 [PATCH] tools/bootconfig: Makefile: Create destination directory Adriana Kobylak
2020-03-17 13:15 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®