mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Hughes <hughsient@gmail.com>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: gnome-power-manager-list@gnome.org,
	acpi4asus-user@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	Corentin Chary <corentin.chary@gmail.com>,
	Darren Salt <linux@youmustbejoking.demon.co.uk>
Subject: Re: [gpm] [PATCH 2.6.29] eeepc-laptop: report brightness control  events via the input layer
Date: Tue, 16 Jun 2009 09:33:22 +0100	[thread overview]
Message-ID: <15e53e180906160133j7055536cqe5b9515704fd4d94@mail.gmail.com> (raw)
In-Reply-To: <61b223ba0906150109r3a69e98aq949c7f2df5563c6e@mail.gmail.com>

On Mon, Jun 15, 2009 at 9:09 AM, Alan
Jenkins<alan-jenkins@tuffmail.co.uk> wrote:
> So during step iii) I think you see the firmware
> increase the brightness, then g-p-m decrease the brightness, and then
> g-p-m catches up and the brightness increases again.

Sorry for not responding sooner, been moving house.

I don't think the kernel driver should modify the brightness itself,
as that's applying policy. Is this is left to userspace then we can
put on policy such as "don't allow brightness to be set below 30%" or
"automatically set the brightness using a ambient light sensor, and
use the brightness keys to set ambient thresholds".

Doing this policy in the driver is the wrong thing to do IMO.

Richard.

  parent reply	other threads:[~2009-06-16  8:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-03 17:57 Darren Salt
2009-04-04  4:18 ` Matthew Garrett
2009-04-04  8:33   ` Corentin Chary
2009-04-04 12:20     ` Darren Salt
2009-04-04 12:35       ` Corentin Chary
2009-04-04 22:10         ` Darren Salt
2009-04-05  8:22           ` Corentin Chary
2009-06-08 15:24   ` Alan Jenkins
2009-06-13  8:55     ` Corentin Chary
2009-06-13  9:33       ` Alan Jenkins
2009-06-13 10:06         ` Corentin Chary
2009-06-13 12:55           ` Darren Salt
2009-06-13 17:51             ` Alan Jenkins
2009-06-14 19:26               ` Corentin Chary
2009-06-15  8:09                 ` Alan Jenkins
2009-06-15  8:12                   ` Alan Jenkins
2009-06-16  8:33                   ` Richard Hughes [this message]
2009-06-16  8:34                     ` [gpm] " Alan Jenkins
2009-06-16  8:47                       ` Richard Hughes
2009-06-16  9:44                         ` Corentin Chary
2009-06-16 10:04                           ` Richard Hughes
2009-06-18 13:33                             ` Alan Jenkins
2009-06-18 22:44                               ` Corentin Chary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15e53e180906160133j7055536cqe5b9515704fd4d94@mail.gmail.com \
    --to=hughsient@gmail.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=alan-jenkins@tuffmail.co.uk \
    --cc=corentin.chary@gmail.com \
    --cc=gnome-power-manager-list@gnome.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@youmustbejoking.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®