From: Corentin Chary <corentin.chary@gmail.com>
To: Corentin Chary <corentin.chary@gmail.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
linux-kernel@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
Darren Salt <linux@youmustbejoking.demon.co.uk>
Subject: Re: [PATCH 2.6.29] eeepc-laptop: report brightness control events via the input layer
Date: Sat, 4 Apr 2009 14:35:26 +0200 [thread overview]
Message-ID: <71cd59b00904040535t51f0e8bew34b487e0a3703f7e@mail.gmail.com> (raw)
In-Reply-To: <504C2315A8%linux@youmustbejoking.demon.co.uk>
>> How can brn be -2?
> If notify_brn() wasn't called, it will be.
Oh, yeah, I miss the if() before notify_brn()
>> And why -2?
> Because notify_brn() won't return it (and if it ever does, it needs to be
> fixed). (Yes, I know, "magic numbers" and all that...)
Maybe a negative known error code could be used here
--
Corentin Chary
http://xf.iksaif.net
next prev parent reply other threads:[~2009-04-04 12:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-03 17:57 Darren Salt
2009-04-04 4:18 ` Matthew Garrett
2009-04-04 8:33 ` Corentin Chary
2009-04-04 12:20 ` Darren Salt
2009-04-04 12:35 ` Corentin Chary [this message]
2009-04-04 22:10 ` Darren Salt
2009-04-05 8:22 ` Corentin Chary
2009-06-08 15:24 ` Alan Jenkins
2009-06-13 8:55 ` Corentin Chary
2009-06-13 9:33 ` Alan Jenkins
2009-06-13 10:06 ` Corentin Chary
2009-06-13 12:55 ` Darren Salt
2009-06-13 17:51 ` Alan Jenkins
2009-06-14 19:26 ` Corentin Chary
2009-06-15 8:09 ` Alan Jenkins
2009-06-15 8:12 ` Alan Jenkins
2009-06-16 8:33 ` [gpm] " Richard Hughes
2009-06-16 8:34 ` Alan Jenkins
2009-06-16 8:47 ` Richard Hughes
2009-06-16 9:44 ` Corentin Chary
2009-06-16 10:04 ` Richard Hughes
2009-06-18 13:33 ` Alan Jenkins
2009-06-18 22:44 ` Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71cd59b00904040535t51f0e8bew34b487e0a3703f7e@mail.gmail.com \
--to=corentin.chary@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@youmustbejoking.demon.co.uk \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®