mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ASoC: mmp-sspa: clear transmit phase bit for non-stereo formats
@ 2020-11-06 14:59 Kyle Russell
  2020-11-18 20:59 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Kyle Russell @ 2020-11-06 14:59 UTC (permalink / raw)
  To: broonie
  Cc: lkundrak, Kyle Russell, Daniel Mack, Haojian Zhuang,
	Robert Jarzmik, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
	linux-arm-kernel, alsa-devel, linux-kernel

The transmit phase register value is never cleared during hw params.
So once hw params sets this bit to handle a two channel format, it
remains configured for dual-phase, which is not desirable for mono
playback.

Signed-off-by: Kyle Russell <bkylerussell@gmail.com>
---
 sound/soc/pxa/mmp-sspa.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/pxa/mmp-sspa.c b/sound/soc/pxa/mmp-sspa.c
index 4255851c71c1..52d4d8ace1c3 100644
--- a/sound/soc/pxa/mmp-sspa.c
+++ b/sound/soc/pxa/mmp-sspa.c
@@ -239,6 +239,7 @@ static int mmp_sspa_hw_params(struct snd_pcm_substream *substream,
 		return -EINVAL;
 	}
 
+	sspa_ctrl &= ~SSPA_CTL_XPH;
 	if (dev->of_node || params_channels(params) == 2)
 		sspa_ctrl |= SSPA_CTL_XPH;
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-18 21:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 14:59 [PATCH] ASoC: mmp-sspa: clear transmit phase bit for non-stereo formats Kyle Russell
2020-11-18 20:59 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®