mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ASoC: mmp-sspa: clear transmit phase bit for non-stereo formats
@ 2020-11-06 14:59 Kyle Russell
  2020-11-18 20:59 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Kyle Russell @ 2020-11-06 14:59 UTC (permalink / raw)
  To: broonie
  Cc: lkundrak, Kyle Russell, Daniel Mack, Haojian Zhuang,
	Robert Jarzmik, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
	linux-arm-kernel, alsa-devel, linux-kernel

The transmit phase register value is never cleared during hw params.
So once hw params sets this bit to handle a two channel format, it
remains configured for dual-phase, which is not desirable for mono
playback.

Signed-off-by: Kyle Russell <bkylerussell@gmail.com>
---
 sound/soc/pxa/mmp-sspa.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/pxa/mmp-sspa.c b/sound/soc/pxa/mmp-sspa.c
index 4255851c71c1..52d4d8ace1c3 100644
--- a/sound/soc/pxa/mmp-sspa.c
+++ b/sound/soc/pxa/mmp-sspa.c
@@ -239,6 +239,7 @@ static int mmp_sspa_hw_params(struct snd_pcm_substream *substream,
 		return -EINVAL;
 	}
 
+	sspa_ctrl &= ~SSPA_CTL_XPH;
 	if (dev->of_node || params_channels(params) == 2)
 		sspa_ctrl |= SSPA_CTL_XPH;
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: mmp-sspa: clear transmit phase bit for non-stereo formats
  2020-11-06 14:59 [PATCH] ASoC: mmp-sspa: clear transmit phase bit for non-stereo formats Kyle Russell
@ 2020-11-18 20:59 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2020-11-18 20:59 UTC (permalink / raw)
  To: Kyle Russell
  Cc: Takashi Iwai, Liam Girdwood, Daniel Mack, linux-kernel,
	Haojian Zhuang, lkundrak, Robert Jarzmik, linux-arm-kernel,
	alsa-devel

On Fri, 6 Nov 2020 09:59:05 -0500, Kyle Russell wrote:
> The transmit phase register value is never cleared during hw params.
> So once hw params sets this bit to handle a two channel format, it
> remains configured for dual-phase, which is not desirable for mono
> playback.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: mmp-sspa: clear transmit phase bit for non-stereo formats
      commit: b88b31f4fa0abcd698045362d4aefcddc50cba59

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-18 21:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 14:59 [PATCH] ASoC: mmp-sspa: clear transmit phase bit for non-stereo formats Kyle Russell
2020-11-18 20:59 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®