[PATCH] Gracely handle GPE dispatch failure

[PATCH] Gracely handle GPE dispatch failure

[H.J. Lu]

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

When GPE dispatch fails due to missing handler, kernel issues

ACPI Error: No handler for Region
ACPI Error: Region EmbeddedControl
ACPI Error: Method parse/execution failed
ACPI Exception: AE_NOT_EXIST, while evaluating GPE method

and goes ahead enable GPE anyway.  After that, kernel goes into an
infinite loop:

ACPI Error: No handler for Region
ACPI Error: Region EmbeddedControl
ACPI Error: Method parse/execution failed
ACPI Exception: AE_NOT_EXIST, while evaluating GPE method

and repeat.  This patch avoids the infinite loop by not enabling GPE if
GPE dispatch fails.


-- 
H.J.

[-- Attachment #2: 0001-Gracely-handle-GPE-dispatch-failure.patch --]
[-- Type: text/x-patch, Size: 1309 bytes --]

From e892b19f5100427b8c89a74186b90675141ceaab Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Sat, 12 Nov 2011 11:03:38 -0800
Subject: [PATCH] Gracely handle GPE dispatch failure

When GPE dispatch fails due to missing handler, kernel issues

ACPI Error: No handler for Region
ACPI Error: Region EmbeddedControl
ACPI Error: Method parse/execution failed
ACPI Exception: AE_NOT_EXIST, while evaluating GPE method

and goes ahead enable GPE anyway.  After that, kernel goes into an
infinite loop:

ACPI Error: No handler for Region
ACPI Error: Region EmbeddedControl
ACPI Error: Method parse/execution failed
ACPI Exception: AE_NOT_EXIST, while evaluating GPE method

and repeat.  This patch avoids the infinite loop by not enabling GPE if
GPE dispatch fails.

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
---
 drivers/acpi/acpica/evgpe.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/acpica/evgpe.c b/drivers/acpi/acpica/evgpe.c
index 5ed064e..ca1ec02 100644
--- a/drivers/acpi/acpica/evgpe.c
+++ b/drivers/acpi/acpica/evgpe.c
@@ -589,6 +589,7 @@ static void ACPI_SYSTEM_XFACE acpi_ev_asynch_execute_gpe_method(void *context)
 					acpi_ut_get_node_name(gpe_event_info->
 							      dispatch.
 							      method_node)));
+			return_VOID;
 		}
 		break;
 
-- 
1.9.3

Re: [PATCH] Gracely handle GPE dispatch failure

[Rafael J. Wysocki]

On Thursday, April 16, 2015 04:37:45 PM H.J. Lu wrote:
> When GPE dispatch fails due to missing handler, kernel issues
> 
> ACPI Error: No handler for Region
> ACPI Error: Region EmbeddedControl
> ACPI Error: Method parse/execution failed
> ACPI Exception: AE_NOT_EXIST, while evaluating GPE method
> 
> and goes ahead enable GPE anyway.  After that, kernel goes into an
> infinite loop:
> 
> ACPI Error: No handler for Region
> ACPI Error: Region EmbeddedControl
> ACPI Error: Method parse/execution failed
> ACPI Exception: AE_NOT_EXIST, while evaluating GPE method
> 
> and repeat.  This patch avoids the infinite loop by not enabling GPE if
> GPE dispatch fails.

First, please send patches inline not in attachements.

Second, please CC this one to linux-acpi@vger.kernel.org and to the ACPICA
maintainers as per the information in the MAINTAINERS file.

Thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.