* [PATCH] Gracely handle GPE dispatch failure
@ 2015-04-16 23:37 H.J. Lu
2015-04-17 1:02 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2015-04-16 23:37 UTC (permalink / raw)
To: LKML
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
When GPE dispatch fails due to missing handler, kernel issues
ACPI Error: No handler for Region
ACPI Error: Region EmbeddedControl
ACPI Error: Method parse/execution failed
ACPI Exception: AE_NOT_EXIST, while evaluating GPE method
and goes ahead enable GPE anyway. After that, kernel goes into an
infinite loop:
ACPI Error: No handler for Region
ACPI Error: Region EmbeddedControl
ACPI Error: Method parse/execution failed
ACPI Exception: AE_NOT_EXIST, while evaluating GPE method
and repeat. This patch avoids the infinite loop by not enabling GPE if
GPE dispatch fails.
--
H.J.
[-- Attachment #2: 0001-Gracely-handle-GPE-dispatch-failure.patch --]
[-- Type: text/x-patch, Size: 1309 bytes --]
From e892b19f5100427b8c89a74186b90675141ceaab Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Sat, 12 Nov 2011 11:03:38 -0800
Subject: [PATCH] Gracely handle GPE dispatch failure
When GPE dispatch fails due to missing handler, kernel issues
ACPI Error: No handler for Region
ACPI Error: Region EmbeddedControl
ACPI Error: Method parse/execution failed
ACPI Exception: AE_NOT_EXIST, while evaluating GPE method
and goes ahead enable GPE anyway. After that, kernel goes into an
infinite loop:
ACPI Error: No handler for Region
ACPI Error: Region EmbeddedControl
ACPI Error: Method parse/execution failed
ACPI Exception: AE_NOT_EXIST, while evaluating GPE method
and repeat. This patch avoids the infinite loop by not enabling GPE if
GPE dispatch fails.
Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
---
drivers/acpi/acpica/evgpe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/acpica/evgpe.c b/drivers/acpi/acpica/evgpe.c
index 5ed064e..ca1ec02 100644
--- a/drivers/acpi/acpica/evgpe.c
+++ b/drivers/acpi/acpica/evgpe.c
@@ -589,6 +589,7 @@ static void ACPI_SYSTEM_XFACE acpi_ev_asynch_execute_gpe_method(void *context)
acpi_ut_get_node_name(gpe_event_info->
dispatch.
method_node)));
+ return_VOID;
}
break;
--
1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Gracely handle GPE dispatch failure
2015-04-16 23:37 [PATCH] Gracely handle GPE dispatch failure H.J. Lu
@ 2015-04-17 1:02 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2015-04-17 1:02 UTC (permalink / raw)
To: H.J. Lu; +Cc: LKML, ACPI Devel Maling List
On Thursday, April 16, 2015 04:37:45 PM H.J. Lu wrote:
> When GPE dispatch fails due to missing handler, kernel issues
>
> ACPI Error: No handler for Region
> ACPI Error: Region EmbeddedControl
> ACPI Error: Method parse/execution failed
> ACPI Exception: AE_NOT_EXIST, while evaluating GPE method
>
> and goes ahead enable GPE anyway. After that, kernel goes into an
> infinite loop:
>
> ACPI Error: No handler for Region
> ACPI Error: Region EmbeddedControl
> ACPI Error: Method parse/execution failed
> ACPI Exception: AE_NOT_EXIST, while evaluating GPE method
>
> and repeat. This patch avoids the infinite loop by not enabling GPE if
> GPE dispatch fails.
First, please send patches inline not in attachements.
Second, please CC this one to linux-acpi@vger.kernel.org and to the ACPICA
maintainers as per the information in the MAINTAINERS file.
Thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-17 0:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-16 23:37 [PATCH] Gracely handle GPE dispatch failure H.J. Lu
2015-04-17 1:02 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®