* [PATCH] mac80211: Remove redundant assignment to ret
@ 2021-04-30 9:21 Yang Li
2021-04-30 11:36 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-04-30 9:21 UTC (permalink / raw)
To: johannes
Cc: davem, kuba, nathan, ndesaulniers, linux-wireless, netdev,
linux-kernel, clang-built-linux, Yang Li
Variable 'ret' is set to -ENODEV but this value is never read as it
is overwritten with a new value later on, hence it is a redundant
assignment and can be removed.
Clean up the following clang-analyzer warning:
net/mac80211/debugfs_netdev.c:60:2: warning: Value stored to 'ret' is
never read [clang-analyzer-deadcode.DeadStores]
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
net/mac80211/debugfs_netdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/mac80211/debugfs_netdev.c b/net/mac80211/debugfs_netdev.c
index 0ad3860..f7aac89 100644
--- a/net/mac80211/debugfs_netdev.c
+++ b/net/mac80211/debugfs_netdev.c
@@ -57,7 +57,6 @@ static ssize_t ieee80211_if_write(
return -EFAULT;
buf[count] = '\0';
- ret = -ENODEV;
rtnl_lock();
ret = (*write)(sdata, buf, count);
rtnl_unlock();
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mac80211: Remove redundant assignment to ret
2021-04-30 9:21 [PATCH] mac80211: Remove redundant assignment to ret Yang Li
@ 2021-04-30 11:36 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2021-04-30 11:36 UTC (permalink / raw)
To: Yang Li
Cc: davem, kuba, nathan, ndesaulniers, linux-wireless, netdev,
linux-kernel, clang-built-linux
On Fri, 2021-04-30 at 17:21 +0800, Yang Li wrote:
> Variable 'ret' is set to -ENODEV but this value is never read as it
> is overwritten with a new value later on, hence it is a redundant
> assignment and can be removed.
>
> Clean up the following clang-analyzer warning:
>
> net/mac80211/debugfs_netdev.c:60:2: warning: Value stored to 'ret' is
> never read [clang-analyzer-deadcode.DeadStores]
Can you just turn that warning off?
It's really quite pointless to churn the tree for effectively nothing.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-30 11:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-30 9:21 [PATCH] mac80211: Remove redundant assignment to ret Yang Li
2021-04-30 11:36 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®