mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Sohil Mehta <sohil.mehta@intel.com>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-hwmon@vger.kernel.org
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
	Zhang Rui <rui.zhang@intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] hwmon: (coretemp) Replace x86_model checks with VFM ones
Date: Thu, 28 Aug 2025 14:18:46 -0700	[thread overview]
Message-ID: <16286fa2-3949-4aca-bc52-4090eb96d305@intel.com> (raw)
In-Reply-To: <20250828201729.1145420-1-sohil.mehta@intel.com>

On 8/28/25 13:17, Sohil Mehta wrote:
> 
> Add a code comment to reflect that none of the CPUs in Family 5 or
> Family 15 set X86_FEATURE_DTHERM. The VFM checks do not impact these
> CPUs since the driver does not load on them.
> 
> Missing-signoff: Dave Hansen <dave.hansen@linux.intel.com>
> Signed-off-by: Sohil Mehta <sohil.mehta@intel.com>

Thanks for picking this back up from whatever dark hole I left it in! ;)

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>

I assume the hwmon folks will pick this up. If not, it's certainly
x86-ish enough for it to go through tip.

Oh, and do we want to cc:stable@ on this? Could this end up biting
anybody running an old kernel on the model 18/19 hardware?

  reply	other threads:[~2025-08-28 21:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28 20:17 Sohil Mehta
2025-08-28 21:18 ` Dave Hansen [this message]
2025-08-28 21:43   ` Sohil Mehta
2025-08-28 21:47   ` Guenter Roeck
2025-08-28 21:42 ` Guenter Roeck
2025-08-28 21:45   ` Sohil Mehta
2025-08-28 21:51     ` Dave Hansen
2025-08-28 22:33       ` Sohil Mehta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16286fa2-3949-4aca-bc52-4090eb96d305@intel.com \
    --to=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=ricardo.neri-calderon@linux.intel.com \
    --cc=rui.zhang@intel.com \
    --cc=sohil.mehta@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®