Re: [PATCH v3] hwmon: (coretemp) Replace x86_model checks with VFM ones

[Guenter Roeck <linux@roeck-us.net>]

On 8/28/25 14:18, Dave Hansen wrote:
> On 8/28/25 13:17, Sohil Mehta wrote:
>>
>> Add a code comment to reflect that none of the CPUs in Family 5 or
>> Family 15 set X86_FEATURE_DTHERM. The VFM checks do not impact these
>> CPUs since the driver does not load on them.
>>
>> Missing-signoff: Dave Hansen <dave.hansen@linux.intel.com>
>> Signed-off-by: Sohil Mehta <sohil.mehta@intel.com>
> 
> Thanks for picking this back up from whatever dark hole I left it in! ;)
> 
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
> 
> I assume the hwmon folks will pick this up. If not, it's certainly
> x86-ish enough for it to go through tip.
> 
Already done, but if you want to take it through some other branch
let me know and I'll drop it.

> Oh, and do we want to cc:stable@ on this? Could this end up biting
> anybody running an old kernel on the model 18/19 hardware?

It doesn't really bite, it will just not instantiate the driver.
I have no idea if those old kernels would run with the new hardware
in the first place. You tell me...

Personally I'd rather wait until someone complains.

Guenter