mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sohil Mehta <sohil.mehta@intel.com>
To: Dave Hansen <dave.hansen@intel.com>, Guenter Roeck <linux@roeck-us.net>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	<linux-hwmon@vger.kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
	Zhang Rui <rui.zhang@intel.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] hwmon: (coretemp) Replace x86_model checks with VFM ones
Date: Thu, 28 Aug 2025 15:33:10 -0700	[thread overview]
Message-ID: <51537b9e-46a8-4dd1-93fb-bb14ea15e6a2@intel.com> (raw)
In-Reply-To: <fa0f4052-22cd-47cc-95ea-ffe1c3a5a52a@intel.com>

On 8/28/2025 2:51 PM, Dave Hansen wrote:
> Let's just wait until Guenter sends it upstream. Once it hits Linus's
> tree, you can ask for it to be in stable if we decide it's a good idea.
> 

Sure, sounds good.

> I asked if it was necessary because I'm not positive it's a good idea.
> 

The model numbers in play are around 14, 15, 23. In some cases, the
model number is used to determine if a sysfs attribute should be
created. So, for lower model numbers, the TTARGET attr probably won't be
created.

	if (c->x86_model > 0xe && c->x86_model != 0x1c)
		if (get_ttarget(tdata, &pdev->dev) >= 0)
			tdata->attr_size++;

	/* Create sysfs interfaces */
	err = create_core_attrs(tdata, pdata->hwmon_dev);

In some other cases, the temperature adjustment would vary slightly.
But, nothing scary for now.

> So, let's actually look at what it would mean in practice to have it hit
> stable@ or not. Just spent 10 minutes looking at it.

Yeah, I am fine with deciding based on the severity of the practical impact.

      reply	other threads:[~2025-08-28 22:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28 20:17 Sohil Mehta
2025-08-28 21:18 ` Dave Hansen
2025-08-28 21:43   ` Sohil Mehta
2025-08-28 21:47   ` Guenter Roeck
2025-08-28 21:42 ` Guenter Roeck
2025-08-28 21:45   ` Sohil Mehta
2025-08-28 21:51     ` Dave Hansen
2025-08-28 22:33       ` Sohil Mehta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51537b9e-46a8-4dd1-93fb-bb14ea15e6a2@intel.com \
    --to=sohil.mehta@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=ricardo.neri-calderon@linux.intel.com \
    --cc=rui.zhang@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®