mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Chen-Yu Tsai <wens@csie.org>,
	Andre Przywara <andre.przywara@arm.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maxime Ripard <mripard@kernel.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, Samuel Holland <samuel@sholland.org>,
	Rob Herring <robh@kernel.org>, Icenowy Zheng <icenowy@aosc.io>,
	Ondrej Jirman <megous@megous.com>,
	Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: (subset) [PATCH v10 03/18] rtc: sun6i: Fix time overflow handling
Date: Tue,  8 Mar 2022 22:21:05 +0100	[thread overview]
Message-ID: <164677445867.88674.16740426287923298243.b4-ty@bootlin.com> (raw)
In-Reply-To: <20220211122643.1343315-4-andre.przywara@arm.com>

On Fri, 11 Feb 2022 12:26:28 +0000, Andre Przywara wrote:
> Using "unsigned long" for UNIX timestamps is never a good idea, and
> comparing the value of such a variable against U32_MAX does not do
> anything useful on 32-bit systems.
> 
> Use the proper time64_t type when dealing with timestamps, and avoid
> cutting down the time range unnecessarily. This also fixes the flawed
> check for the alarm time being too far into the future.
> 
> [...]

Applied, thanks!

[03/18] rtc: sun6i: Fix time overflow handling
        commit: 25c9815569cefd4f719c6c1266fe897e57642278

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>

  parent reply	other threads:[~2022-03-08 21:21 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11 12:26 [PATCH v10 00/18] arm64: sunxi: Initial Allwinner H616 SoC support Andre Przywara
2022-02-11 12:26 ` [PATCH v10 01/18] clk: sunxi-ng: h616-r: Add RTC gate clock Andre Przywara
2022-02-23  3:22   ` Samuel Holland
2022-04-24 23:36     ` Andre Przywara
2022-04-25  0:05       ` Samuel Holland
2022-04-27 19:24         ` Andre Przywara
2022-02-11 12:26 ` [PATCH v10 02/18] clk: sunxi-ng: h616: Add PLL derived 32KHz clock Andre Przywara
2022-02-23  3:28   ` Samuel Holland
2022-02-11 12:26 ` [PATCH v10 03/18] rtc: sun6i: Fix time overflow handling Andre Przywara
2022-02-22 10:58   ` Andre Przywara
2022-03-08 21:21   ` Alexandre Belloni [this message]
2022-02-11 12:26 ` [PATCH v10 04/18] rtc: sun6i: Add support for linear day storage Andre Przywara
2022-03-08 21:28   ` (subset) " Alexandre Belloni
2022-02-11 12:26 ` [PATCH v10 05/18] rtc: sun6i: Add support for broken-down alarm registers Andre Przywara
2022-03-08 21:28   ` (subset) " Alexandre Belloni
2022-02-11 12:26 ` [PATCH v10 06/18] rtc: sun6i: Add Allwinner H616 support Andre Przywara
2022-03-08 21:28   ` (subset) " Alexandre Belloni
2022-02-11 12:26 ` [PATCH v10 07/18] arm64: dts: allwinner: Add Allwinner H616 .dtsi file Andre Przywara
2022-02-11 12:26 ` [PATCH v10 08/18] dt-bindings: arm: sunxi: Add two H616 board compatible strings Andre Przywara
2022-02-23  3:38   ` Samuel Holland
2022-02-11 12:26 ` [PATCH v10 09/18] arm64: dts: allwinner: h616: Add OrangePi Zero 2 board support Andre Przywara
2022-02-11 12:26 ` [PATCH v10 10/18] arm64: dts: allwinner: h616: Add X96 Mate TV box support Andre Przywara
2022-02-11 12:26 ` [PATCH v10 11/18] dt-bindings: usb: Add H616 compatible string Andre Przywara
2022-02-17 23:38   ` Rob Herring
2022-02-11 12:26 ` [PATCH v10 12/18] phy: sun4i-usb: Rework HCI PHY (aka. "pmu_unk1") handling Andre Przywara
2022-02-23  3:42   ` Samuel Holland
2022-02-11 12:26 ` [PATCH v10 13/18] phy: sun4i-usb: Allow reset line to be shared Andre Przywara
2022-02-23  3:44   ` Samuel Holland
2022-02-23  3:50     ` Samuel Holland
2022-02-11 12:26 ` [PATCH v10 14/18] phy: sun4i-usb: Introduce port2 SIDDQ quirk Andre Przywara
2022-02-23  3:57   ` Samuel Holland
2022-02-11 12:26 ` [PATCH v10 15/18] phy: sun4i-usb: Add support for the H616 USB PHY Andre Przywara
2022-02-23  3:58   ` Samuel Holland
2022-02-11 12:26 ` [PATCH v10 16/18] arm64: dts: allwinner: h616: Add USB nodes Andre Przywara
2022-02-11 12:26 ` [PATCH v10 17/18] arm64: dts: allwinner: h616: OrangePi Zero 2: " Andre Przywara
2022-02-11 12:26 ` [PATCH v10 18/18] arm64: dts: allwinner: h616: X96 Mate: " Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164677445867.88674.16740426287923298243.b4-ty@bootlin.com \
    --to=alexandre.belloni@bootlin.com \
    --cc=a.zummo@towertech.it \
    --cc=andre.przywara@arm.com \
    --cc=icenowy@aosc.io \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=megous@megous.com \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®