mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
To: <linux-remoteproc@vger.kernel.org>, <agross@kernel.org>,
	<bjorn.andersson@linaro.org>, <lgirdwood@gmail.com>,
	<broonie@kernel.org>, <robh+dt@kernel.org>,
	<quic_plai@quicinc.com>, <bgoswami@quicinc.com>, <perex@perex.cz>,
	<tiwai@suse.com>, <srinivas.kandagatla@linaro.org>,
	<quic_rohkumar@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <swboyd@chromium.org>,
	<judyhsiao@chromium.org>, <devicetree@vger.kernel.org>
Cc: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Subject: [PATCH v6 8/8] remoteproc: qcom: Update QDSP6 out-of-reset timeout value
Date: Thu, 8 Sep 2022 18:53:42 +0530	[thread overview]
Message-ID: <1662643422-14909-9-git-send-email-quic_srivasam@quicinc.com> (raw)
In-Reply-To: <1662643422-14909-1-git-send-email-quic_srivasam@quicinc.com>

Update QDSP6 out-of-reset timeout value to 1 second, as sometimes
ADSP boot failing on SC7280 based platforms with existing value.
Also add few micro seconds sleep after enabling boot core
start register.

Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
 drivers/remoteproc/qcom_q6v5_adsp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
index e55d593..4414e23 100644
--- a/drivers/remoteproc/qcom_q6v5_adsp.c
+++ b/drivers/remoteproc/qcom_q6v5_adsp.c
@@ -34,7 +34,7 @@
 /* time out value */
 #define ACK_TIMEOUT			1000
 #define ACK_TIMEOUT_US			1000000
-#define BOOT_FSM_TIMEOUT		10000
+#define BOOT_FSM_TIMEOUT		1000000
 /* mask values */
 #define EVB_MASK			GENMASK(27, 4)
 /*QDSP6SS register offsets*/
@@ -422,13 +422,14 @@ static int adsp_start(struct rproc *rproc)
 
 	/* De-assert QDSP6 stop core. QDSP6 will execute after out of reset */
 	writel(LPASS_BOOT_CORE_START, adsp->qdsp6ss_base + CORE_START_REG);
+	usleep_range(100, 110);
 
 	/* Trigger boot FSM to start QDSP6 */
 	writel(LPASS_BOOT_CMD_START, adsp->qdsp6ss_base + BOOT_CMD_REG);
 
 	/* Wait for core to come out of reset */
 	ret = readl_poll_timeout(adsp->qdsp6ss_base + BOOT_STATUS_REG,
-			val, (val & BIT(0)) != 0, 10, BOOT_FSM_TIMEOUT);
+			val, (val & BIT(0)) != 0, 100, BOOT_FSM_TIMEOUT);
 	if (ret) {
 		dev_err(adsp->dev, "failed to bootup adsp\n");
 		goto disable_adsp_clks;
-- 
2.7.4


  parent reply	other threads:[~2022-09-08 13:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08 13:23 [PATCH v6 0/8] Update ADSP pil loader for SC7280 platform Srinivasa Rao Mandadapu
2022-09-08 13:23 ` [PATCH v6 1/8] dt-bindings: remoteproc: qcom: Add SC7280 ADSP support Srinivasa Rao Mandadapu
2022-09-11 22:52   ` Stephen Boyd
2022-09-14  8:58   ` Sibi Sankar
2022-09-19 14:04     ` Srinivasa Rao Mandadapu
2022-09-08 13:23 ` [PATCH v6 2/8] remoteproc: qcom: Add flag in adsp private data structure Srinivasa Rao Mandadapu
2022-09-14  9:06   ` Sibi Sankar
2022-09-19 14:05     ` Srinivasa Rao Mandadapu
2022-09-08 13:23 ` [PATCH v6 3/8] remoteproc: qcom: Add compatible name for SC7280 ADSP Srinivasa Rao Mandadapu
2022-09-11 22:53   ` Stephen Boyd
2022-09-14  9:22   ` Sibi Sankar
2022-09-19 14:11     ` Srinivasa Rao Mandadapu
2022-09-08 13:23 ` [PATCH v6 4/8] remoteproc: qcom: Update rproc parse firmware callback Srinivasa Rao Mandadapu
2022-09-11 22:55   ` Stephen Boyd
2022-09-19 13:57     ` Srinivasa Rao Mandadapu
2022-09-14  9:35   ` Sibi Sankar
2022-09-19 14:15     ` Srinivasa Rao Mandadapu
2022-09-08 13:23 ` [PATCH v6 5/8] remoteproc: qcom: Replace hard coded values with macros Srinivasa Rao Mandadapu
2022-09-14  9:37   ` Sibi Sankar
2022-09-08 13:23 ` [PATCH v6 6/8] remoteproc: qcom: Add efuse evb selection control Srinivasa Rao Mandadapu
2022-09-11 22:57   ` Stephen Boyd
2022-09-14  9:42   ` Sibi Sankar
2022-09-08 13:23 ` [PATCH v6 7/8] remoteproc: qcom: Add support for memory sandbox Srinivasa Rao Mandadapu
2022-09-11 23:01   ` Stephen Boyd
2022-09-19 13:59     ` Srinivasa Rao Mandadapu
2022-09-14 10:10   ` Sibi Sankar
2022-09-19 14:19     ` Srinivasa Rao Mandadapu
2022-09-08 13:23 ` Srinivasa Rao Mandadapu [this message]
2022-09-14  9:45   ` [PATCH v6 8/8] remoteproc: qcom: Update QDSP6 out-of-reset timeout value Sibi Sankar
2022-09-19 14:20     ` Srinivasa Rao Mandadapu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1662643422-14909-9-git-send-email-quic_srivasam@quicinc.com \
    --to=quic_srivasam@quicinc.com \
    --cc=agross@kernel.org \
    --cc=bgoswami@quicinc.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=judyhsiao@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=quic_plai@quicinc.com \
    --cc=quic_rohkumar@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=swboyd@chromium.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®