From: Jens Axboe <axboe@kernel.dk>
To: Khazhismel Kumykov <khazhy@chromium.org>,
Paolo Valente <paolo.valente@linaro.org>
Cc: Khazhismel Kumykov <khazhy@google.com>,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>,
linux-block@vger.kernel.org, Yu Kuai <yukuai1@huaweicloud.com>
Subject: Re: [PATCH 1/2] bfq: fix waker_bfqq inconsistency crash
Date: Wed, 09 Nov 2022 12:47:01 -0700 [thread overview]
Message-ID: <166802322145.66062.9011104820940557467.b4-ty@kernel.dk> (raw)
In-Reply-To: <20221108181030.1611703-1-khazhy@google.com>
On Tue, 8 Nov 2022 10:10:29 -0800, Khazhismel Kumykov wrote:
> This fixes crashes in bfq_add_bfqq_busy due to waker_bfqq being NULL,
> but woken_list_node still being hashed. This would happen when
> bfq_init_rq() expects a brand new allocated queue to be returned from
> bfq_get_bfqq_handle_split() and unconditionally updates waker_bfqq
> without resetting woken_list_node. Since we can always return oom_bfqq
> when attempting to allocate, we cannot assume waker_bfqq starts as NULL.
>
> [...]
Applied, thanks!
[1/2] bfq: fix waker_bfqq inconsistency crash
commit: a1795c2ccb1e4c49220d2a0d381540024d71647c
[2/2] bfq: ignore oom_bfqq in bfq_check_waker
commit: 99771d73ff4539f2337b84917f4792abf0d8931b
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-11-09 19:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 1:39 [RFC PATCH] " Khazhismel Kumykov
2022-11-03 2:55 ` Yu Kuai
2022-11-03 3:05 ` Khazhy Kumykov
2022-11-03 3:51 ` Yu Kuai
2022-11-03 8:47 ` Jan Kara
2022-11-04 21:25 ` Khazhy Kumykov
2022-11-07 13:26 ` Jan Kara
2022-11-08 18:10 ` [PATCH 1/2] " Khazhismel Kumykov
2022-11-08 18:10 ` [PATCH 2/2] bfq: ignore oom_bfqq in bfq_check_waker Khazhismel Kumykov
2022-11-09 11:14 ` Jan Kara
2022-11-09 11:15 ` [PATCH 1/2] bfq: fix waker_bfqq inconsistency crash Jan Kara
2022-11-09 19:47 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166802322145.66062.9011104820940557467.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=khazhy@chromium.org \
--cc=khazhy@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®