From: Khazhismel Kumykov <khazhy@chromium.org>
To: Paolo Valente <paolo.valente@linaro.org>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Yu Kuai <yukuai1@huaweicloud.com>, Jan Kara <jack@suse.cz>,
Khazhismel Kumykov <khazhy@google.com>
Subject: [PATCH 2/2] bfq: ignore oom_bfqq in bfq_check_waker
Date: Tue, 8 Nov 2022 10:10:30 -0800 [thread overview]
Message-ID: <20221108181030.1611703-2-khazhy@google.com> (raw)
In-Reply-To: <20221108181030.1611703-1-khazhy@google.com>
oom_bfqq is just a fallback bfqq, so shouldn't be used with waker
detection.
Suggested-by: Jan Kara <jack@suse.cz>
Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
---
block/bfq-iosched.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index ca04ec868c40..267baf84870f 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -2135,7 +2135,9 @@ static void bfq_check_waker(struct bfq_data *bfqd, struct bfq_queue *bfqq,
if (!bfqd->last_completed_rq_bfqq ||
bfqd->last_completed_rq_bfqq == bfqq ||
bfq_bfqq_has_short_ttime(bfqq) ||
- now_ns - bfqd->last_completion >= 4 * NSEC_PER_MSEC)
+ now_ns - bfqd->last_completion >= 4 * NSEC_PER_MSEC ||
+ bfqd->last_completed_rq_bfqq == &bfqd->oom_bfqq ||
+ bfqq == &bfqd->oom_bfqq)
return;
/*
--
2.38.1.431.g37b22c650d-goog
next prev parent reply other threads:[~2022-11-08 18:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 1:39 [RFC PATCH] bfq: fix waker_bfqq inconsistency crash Khazhismel Kumykov
2022-11-03 2:55 ` Yu Kuai
2022-11-03 3:05 ` Khazhy Kumykov
2022-11-03 3:51 ` Yu Kuai
2022-11-03 8:47 ` Jan Kara
2022-11-04 21:25 ` Khazhy Kumykov
2022-11-07 13:26 ` Jan Kara
2022-11-08 18:10 ` [PATCH 1/2] " Khazhismel Kumykov
2022-11-08 18:10 ` Khazhismel Kumykov [this message]
2022-11-09 11:14 ` [PATCH 2/2] bfq: ignore oom_bfqq in bfq_check_waker Jan Kara
2022-11-09 11:15 ` [PATCH 1/2] bfq: fix waker_bfqq inconsistency crash Jan Kara
2022-11-09 19:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108181030.1611703-2-khazhy@google.com \
--to=khazhy@chromium.org \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=khazhy@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®