mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Babu Moger" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Babu Moger <babu.moger@amd.com>,
	"Borislav Petkov (AMD)" <bp@alien8.de>,
	Reinette Chatre <reinette.chatre@intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: x86/cache] x86/resctrl: Add interface to read mbm_local_bytes_config
Date: Tue, 24 Jan 2023 09:26:36 -0000	[thread overview]
Message-ID: <167455239634.4906.11848181129312661544.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20230113152039.770054-11-babu.moger@amd.com>

The following commit has been merged into the x86/cache branch of tip:

Commit-ID:     73afb2d3ce2d7e0f9eee14e3f2b53d2bbfefd9c8
Gitweb:        https://git.kernel.org/tip/73afb2d3ce2d7e0f9eee14e3f2b53d2bbfefd9c8
Author:        Babu Moger <babu.moger@amd.com>
AuthorDate:    Fri, 13 Jan 2023 09:20:36 -06:00
Committer:     Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Mon, 23 Jan 2023 17:40:27 +01:00

x86/resctrl: Add interface to read mbm_local_bytes_config

The event configuration can be viewed by the user by reading the configuration
file /sys/fs/resctrl/info/L3_MON/mbm_local_bytes_config.  The event
configuration settings are domain specific and will affect all the CPUs in the
domain.

Following are the types of events supported:

  ====  ===========================================================
  Bits   Description
  ====  ===========================================================
  6      Dirty Victims from the QOS domain to all types of memory
  5      Reads to slow memory in the non-local NUMA domain
  4      Reads to slow memory in the local NUMA domain
  3      Non-temporal writes to non-local NUMA domain
  2      Non-temporal writes to local NUMA domain
  1      Reads to memory in the non-local NUMA domain
  0      Reads to memory in the local NUMA domain
  ====  ===========================================================

By default, the mbm_local_bytes_config is set to 0x15 to count all the local
event types.

For example:

  $cat /sys/fs/resctrl/info/L3_MON/mbm_local_bytes_config
  0=0x15;1=0x15;2=0x15;3=0x15

In this case, the event mbm_local_bytes is configured with 0x15 on
domains 0 to 3.

Signed-off-by: Babu Moger <babu.moger@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Link: https://lore.kernel.org/r/20230113152039.770054-11-babu.moger@amd.com
---
 arch/x86/kernel/cpu/resctrl/monitor.c  |  4 +++-
 arch/x86/kernel/cpu/resctrl/rdtgroup.c | 16 ++++++++++++++++
 2 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
index 0ff45e3..28c6500 100644
--- a/arch/x86/kernel/cpu/resctrl/monitor.c
+++ b/arch/x86/kernel/cpu/resctrl/monitor.c
@@ -805,8 +805,10 @@ int __init rdt_get_mon_l3_config(struct rdt_resource *r)
 			mbm_total_event.configurable = true;
 			mbm_config_rftype_init("mbm_total_bytes_config");
 		}
-		if (rdt_cpu_has(X86_FEATURE_CQM_MBM_LOCAL))
+		if (rdt_cpu_has(X86_FEATURE_CQM_MBM_LOCAL)) {
 			mbm_local_event.configurable = true;
+			mbm_config_rftype_init("mbm_local_bytes_config");
+		}
 	}
 
 	l3_mon_evt_init(r);
diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
index cd4e668..ad3c701 100644
--- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
+++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
@@ -1507,6 +1507,16 @@ static int mbm_total_bytes_config_show(struct kernfs_open_file *of,
 	return 0;
 }
 
+static int mbm_local_bytes_config_show(struct kernfs_open_file *of,
+				       struct seq_file *seq, void *v)
+{
+	struct rdt_resource *r = of->kn->parent->priv;
+
+	mbm_config_show(seq, r, QOS_L3_MBM_LOCAL_EVENT_ID);
+
+	return 0;
+}
+
 /* rdtgroup information files for one cache resource. */
 static struct rftype res_common_files[] = {
 	{
@@ -1612,6 +1622,12 @@ static struct rftype res_common_files[] = {
 		.seq_show	= mbm_total_bytes_config_show,
 	},
 	{
+		.name		= "mbm_local_bytes_config",
+		.mode		= 0444,
+		.kf_ops		= &rdtgroup_kf_single_ops,
+		.seq_show	= mbm_local_bytes_config_show,
+	},
+	{
 		.name		= "cpus",
 		.mode		= 0644,
 		.kf_ops		= &rdtgroup_kf_single_ops,

  reply	other threads:[~2023-01-24  9:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 15:20 [PATCH v12 00/13] x86/resctrl: Support for AMD QoS new features Babu Moger
2023-01-13 15:20 ` [PATCH v12 01/13] x86/resctrl: Replace smp_call_function_many() with on_each_cpu_mask() Babu Moger
2023-01-24  9:26   ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 02/13] x86/cpufeatures: Add Slow Memory Bandwidth Allocation feature flag Babu Moger
2023-01-24  9:26   ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 03/13] x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA Babu Moger
2023-01-24  9:26   ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 04/13] x86/cpufeatures: Add Bandwidth Monitoring Event Configuration feature flag Babu Moger
2023-01-24  9:26   ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 05/13] x86/resctrl: Include new features in command line options Babu Moger
2023-01-24  9:26   ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 06/13] x86/resctrl: Detect and configure Slow Memory Bandwidth Allocation Babu Moger
2023-01-24  9:26   ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 07/13] x86/resctrl: Add __init attribute to rdt_get_mon_l3_config() Babu Moger
2023-01-24  9:26   ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 08/13] x86/resctrl: Support monitor configuration Babu Moger
2023-01-24  9:26   ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 09/13] x86/resctrl: Add interface to read mbm_total_bytes_config Babu Moger
2023-01-24  9:26   ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 10/13] x86/resctrl: Add interface to read mbm_local_bytes_config Babu Moger
2023-01-24  9:26   ` tip-bot2 for Babu Moger [this message]
2023-01-13 15:20 ` [PATCH v12 11/13] x86/resctrl: Add interface to write mbm_total_bytes_config Babu Moger
2023-01-24  9:26   ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 12/13] x86/resctrl: Add interface to write mbm_local_bytes_config Babu Moger
2023-01-24  9:26   ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 13/13] Documentation/x86: Update resctrl.rst for new features Babu Moger
2023-01-17 22:11   ` Reinette Chatre
2023-01-24  9:26   ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-17 22:16 ` [PATCH v12 00/13] x86/resctrl: Support for AMD QoS " Reinette Chatre
2023-01-18 16:36   ` Moger, Babu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167455239634.4906.11848181129312661544.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®