From: "tip-bot2 for Babu Moger" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Babu Moger <babu.moger@amd.com>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
Reinette Chatre <reinette.chatre@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: x86/cache] x86/resctrl: Add __init attribute to rdt_get_mon_l3_config()
Date: Tue, 24 Jan 2023 09:26:37 -0000 [thread overview]
Message-ID: <167455239706.4906.14594774721679630568.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20230113152039.770054-8-babu.moger@amd.com>
The following commit has been merged into the x86/cache branch of tip:
Commit-ID: bd334c86b5d70e5d1c6169991802e62c828d6f38
Gitweb: https://git.kernel.org/tip/bd334c86b5d70e5d1c6169991802e62c828d6f38
Author: Babu Moger <babu.moger@amd.com>
AuthorDate: Fri, 13 Jan 2023 09:20:33 -06:00
Committer: Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Mon, 23 Jan 2023 17:40:11 +01:00
x86/resctrl: Add __init attribute to rdt_get_mon_l3_config()
In an upcoming change, rdt_get_mon_l3_config() needs to call rdt_cpu_has() to
query the monitor related features. It cannot be called right now because
rdt_cpu_has() has the __init attribute but rdt_get_mon_l3_config() doesn't.
Add the __init attribute to rdt_get_mon_l3_config() that is only called by
get_rdt_mon_resources() that already has the __init attribute. Also make
rdt_cpu_has() available to by rdt_get_mon_l3_config() via the internal header
file.
Signed-off-by: Babu Moger <babu.moger@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Link: https://lore.kernel.org/r/20230113152039.770054-8-babu.moger@amd.com
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
---
arch/x86/kernel/cpu/resctrl/core.c | 2 +-
arch/x86/kernel/cpu/resctrl/internal.h | 1 +
arch/x86/kernel/cpu/resctrl/monitor.c | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
index b4fc851..030d3b4 100644
--- a/arch/x86/kernel/cpu/resctrl/core.c
+++ b/arch/x86/kernel/cpu/resctrl/core.c
@@ -728,7 +728,7 @@ static int __init set_rdt_options(char *str)
}
__setup("rdt", set_rdt_options);
-static bool __init rdt_cpu_has(int flag)
+bool __init rdt_cpu_has(int flag)
{
bool ret = boot_cpu_has(flag);
struct rdt_options *o;
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index fdbbf66..f16b8bc 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -512,6 +512,7 @@ void closid_free(int closid);
int alloc_rmid(void);
void free_rmid(u32 rmid);
int rdt_get_mon_l3_config(struct rdt_resource *r);
+bool __init rdt_cpu_has(int flag);
void mon_event_count(void *info);
int rdtgroup_mondata_show(struct seq_file *m, void *arg);
void mon_event_read(struct rmid_read *rr, struct rdt_resource *r,
diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
index 77538ab..5665ab9 100644
--- a/arch/x86/kernel/cpu/resctrl/monitor.c
+++ b/arch/x86/kernel/cpu/resctrl/monitor.c
@@ -763,7 +763,7 @@ static void l3_mon_evt_init(struct rdt_resource *r)
list_add_tail(&mbm_local_event.list, &r->evt_list);
}
-int rdt_get_mon_l3_config(struct rdt_resource *r)
+int __init rdt_get_mon_l3_config(struct rdt_resource *r)
{
unsigned int mbm_offset = boot_cpu_data.x86_cache_mbm_width_offset;
struct rdt_hw_resource *hw_res = resctrl_to_arch_res(r);
next prev parent reply other threads:[~2023-01-24 9:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 15:20 [PATCH v12 00/13] x86/resctrl: Support for AMD QoS new features Babu Moger
2023-01-13 15:20 ` [PATCH v12 01/13] x86/resctrl: Replace smp_call_function_many() with on_each_cpu_mask() Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 02/13] x86/cpufeatures: Add Slow Memory Bandwidth Allocation feature flag Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 03/13] x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 04/13] x86/cpufeatures: Add Bandwidth Monitoring Event Configuration feature flag Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 05/13] x86/resctrl: Include new features in command line options Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 06/13] x86/resctrl: Detect and configure Slow Memory Bandwidth Allocation Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 07/13] x86/resctrl: Add __init attribute to rdt_get_mon_l3_config() Babu Moger
2023-01-24 9:26 ` tip-bot2 for Babu Moger [this message]
2023-01-13 15:20 ` [PATCH v12 08/13] x86/resctrl: Support monitor configuration Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 09/13] x86/resctrl: Add interface to read mbm_total_bytes_config Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 10/13] x86/resctrl: Add interface to read mbm_local_bytes_config Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 11/13] x86/resctrl: Add interface to write mbm_total_bytes_config Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 12/13] x86/resctrl: Add interface to write mbm_local_bytes_config Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 13/13] Documentation/x86: Update resctrl.rst for new features Babu Moger
2023-01-17 22:11 ` Reinette Chatre
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-17 22:16 ` [PATCH v12 00/13] x86/resctrl: Support for AMD QoS " Reinette Chatre
2023-01-18 16:36 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167455239706.4906.14594774721679630568.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®