From: "Moger, Babu" <babu.moger@amd.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de
Cc: fenghua.yu@intel.com, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, paulmck@kernel.org,
akpm@linux-foundation.org, quic_neeraju@quicinc.com,
rdunlap@infradead.org, damien.lemoal@opensource.wdc.com,
songmuchun@bytedance.com, peterz@infradead.org,
jpoimboe@kernel.org, pbonzini@redhat.com,
chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
jmattson@google.com, daniel.sneddon@linux.intel.com,
sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
bagasdotme@gmail.com, eranian@google.com,
christophe.leroy@csgroup.eu, jarkko@kernel.org,
adrian.hunter@intel.com, quic_jiles@quicinc.com,
peternewman@google.com
Subject: Re: [PATCH v12 00/13] x86/resctrl: Support for AMD QoS new features
Date: Wed, 18 Jan 2023 10:36:05 -0600 [thread overview]
Message-ID: <6e3ddaa0-f221-3f90-1f86-07d1879fd222@amd.com> (raw)
In-Reply-To: <9e43dd11-38b3-fe0c-0929-8b454591813a@intel.com>
On 1/17/23 16:16, Reinette Chatre wrote:
> Hi Babu,
>
> On 1/13/2023 7:20 AM, Babu Moger wrote:
>> New AMD processors can now support following QoS features.
>>
>> 1. Slow Memory Bandwidth Allocation (SMBA)
>> With this feature, the QOS enforcement policies can be applied
>> to the external slow memory connected to the host. QOS enforcement
>> is accomplished by assigning a Class Of Service (COS) to a processor
>> and specifying allocations or limits for that COS for each resource
>> to be allocated.
>>
>> Currently, CXL.memory is the only supported "slow" memory device. With
>> the support of SMBA feature the hardware enables bandwidth allocation
>> on the slow memory devices.
>>
>> 2. Bandwidth Monitoring Event Configuration (BMEC)
>> The bandwidth monitoring events mbm_total_event and mbm_local_event
>> are set to count all the total and local reads/writes respectively.
>> With the introduction of slow memory, the two counters are not enough
>> to count all the different types are memory events. With the feature
>> BMEC, the users have the option to configure mbm_total_event and
>> mbm_local_event to count the specific type of events.
>>
>> Following are the bitmaps of events supported.
>> Bits Description
>> 6 Dirty Victims from the QOS domain to all types of memory
>> 5 Reads to slow memory in the non-local NUMA domain
>> 4 Reads to slow memory in the local NUMA domain
>> 3 Non-temporal writes to non-local NUMA domain
>> 2 Non-temporal writes to local NUMA domain
>> 1 Reads to memory in the non-local NUMA domain
>> 0 Reads to memory in the local NUMA domain
>>
>> This series adds support for these features. Also added a minor cleanup(PATCH 1).
>>
>> Feature description is available in the specification, "AMD64 Technology Platform Quality of Service Extensions, Revision: 1.03 Publication # 56375
>> Revision: 1.03 Issue Date: February 2022".
>>
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537
>> Link: https://www.amd.com/en/support/tech-docs/amd64-technology-platform-quality-service-extensions
> This series looks good to me. I added my "Reviewed-by" tag to patch 13/13. All
> the other patches in this series already have my "Reviewed-by" tag.
Thank you very much.
Babu Moger
prev parent reply other threads:[~2023-01-18 16:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 15:20 Babu Moger
2023-01-13 15:20 ` [PATCH v12 01/13] x86/resctrl: Replace smp_call_function_many() with on_each_cpu_mask() Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 02/13] x86/cpufeatures: Add Slow Memory Bandwidth Allocation feature flag Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 03/13] x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 04/13] x86/cpufeatures: Add Bandwidth Monitoring Event Configuration feature flag Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 05/13] x86/resctrl: Include new features in command line options Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 06/13] x86/resctrl: Detect and configure Slow Memory Bandwidth Allocation Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 07/13] x86/resctrl: Add __init attribute to rdt_get_mon_l3_config() Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 08/13] x86/resctrl: Support monitor configuration Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 09/13] x86/resctrl: Add interface to read mbm_total_bytes_config Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 10/13] x86/resctrl: Add interface to read mbm_local_bytes_config Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 11/13] x86/resctrl: Add interface to write mbm_total_bytes_config Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 12/13] x86/resctrl: Add interface to write mbm_local_bytes_config Babu Moger
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-13 15:20 ` [PATCH v12 13/13] Documentation/x86: Update resctrl.rst for new features Babu Moger
2023-01-17 22:11 ` Reinette Chatre
2023-01-24 9:26 ` [tip: x86/cache] " tip-bot2 for Babu Moger
2023-01-17 22:16 ` [PATCH v12 00/13] x86/resctrl: Support for AMD QoS " Reinette Chatre
2023-01-18 16:36 ` Moger, Babu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e3ddaa0-f221-3f90-1f86-07d1879fd222@amd.com \
--to=babu.moger@amd.com \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jarkko@kernel.org \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=quic_jiles@quicinc.com \
--cc=quic_neeraju@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=sandipan.das@amd.com \
--cc=songmuchun@bytedance.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®