[PATCH] drivers: nfc: nfcsim: remove return value check of `dev_dir`

[PATCH] drivers: nfc: nfcsim: remove return value check of `dev_dir`

[Jianuo Kuang]

Smatch complains that:
nfcsim_debugfs_init_dev() warn: 'dev_dir' is an error pointer or valid

According to the documentation of the debugfs_create_dir() function,
there is no need to check the return value of this function.
Just delete the dead code.

Fixes: f9ac6273e5b8 ("NFC: nfcsim: Add support for sysfs control entry")
Signed-off-by: Jianuo Kuang <u202110722@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
---
 drivers/nfc/nfcsim.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/nfc/nfcsim.c b/drivers/nfc/nfcsim.c
index 85bf8d586c70..44eeb17ae48d 100644
--- a/drivers/nfc/nfcsim.c
+++ b/drivers/nfc/nfcsim.c
@@ -367,11 +367,6 @@ static void nfcsim_debugfs_init_dev(struct nfcsim *dev)
 	}
 
 	dev_dir = debugfs_create_dir(devname, nfcsim_debugfs_root);
-	if (!dev_dir) {
-		NFCSIM_ERR(dev, "Could not create debugfs entries for nfc%d\n",
-			   idx);
-		return;
-	}
 
 	debugfs_create_u8("dropframe", 0664, dev_dir, &dev->dropframe);
 }
-- 
2.25.1

Re: [PATCH] drivers: nfc: nfcsim: remove return value check of `dev_dir`

[Krzysztof Kozlowski]

On 24/04/2023 04:41, Jianuo Kuang wrote:
> Smatch complains that:
> nfcsim_debugfs_init_dev() warn: 'dev_dir' is an error pointer or valid
> 
> According to the documentation of the debugfs_create_dir() function,
> there is no need to check the return value of this function.
> Just delete the dead code.
> 
> Fixes: f9ac6273e5b8 ("NFC: nfcsim: Add support for sysfs control entry")
> Signed-off-by: Jianuo Kuang <u202110722@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH] drivers: nfc: nfcsim: remove return value check of `dev_dir`

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 24 Apr 2023 10:41:40 +0800 you wrote:
> Smatch complains that:
> nfcsim_debugfs_init_dev() warn: 'dev_dir' is an error pointer or valid
> 
> According to the documentation of the debugfs_create_dir() function,
> there is no need to check the return value of this function.
> Just delete the dead code.
> 
> [...]

Here is the summary with links:
  - drivers: nfc: nfcsim: remove return value check of `dev_dir`
    https://git.kernel.org/netdev/net-next/c/e515c330d7e2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html