* [PATCH] string: kunit: add missing MODULE_DESCRIPTION() macros
@ 2024-05-31 23:07 Jeff Johnson
2024-06-20 16:45 ` Jeff Johnson
2024-06-20 18:57 ` Kees Cook
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Johnson @ 2024-05-31 23:07 UTC (permalink / raw)
To: Andrew Morton, Kees Cook, Andy Shevchenko
Cc: linux-hardening, linux-kernel, kernel-janitors, Jeff Johnson
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/string_kunit.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/string_helpers_kunit.o
Add the missing invocation of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
lib/string_helpers_kunit.c | 1 +
lib/string_kunit.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/string_helpers_kunit.c b/lib/string_helpers_kunit.c
index f88e39fd68d6..c853046183d2 100644
--- a/lib/string_helpers_kunit.c
+++ b/lib/string_helpers_kunit.c
@@ -625,4 +625,5 @@ static struct kunit_suite string_helpers_test_suite = {
kunit_test_suites(&string_helpers_test_suite);
+MODULE_DESCRIPTION("Test cases for string helpers module");
MODULE_LICENSE("Dual BSD/GPL");
diff --git a/lib/string_kunit.c b/lib/string_kunit.c
index 2a812decf14b..c919e3293da6 100644
--- a/lib/string_kunit.c
+++ b/lib/string_kunit.c
@@ -633,4 +633,5 @@ static struct kunit_suite string_test_suite = {
kunit_test_suites(&string_test_suite);
+MODULE_DESCRIPTION("Test cases for string functions");
MODULE_LICENSE("GPL v2");
---
base-commit: b050496579632f86ee1ef7e7501906db579f3457
change-id: 20240531-md-lib-string-d987d813b344
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] string: kunit: add missing MODULE_DESCRIPTION() macros
2024-05-31 23:07 [PATCH] string: kunit: add missing MODULE_DESCRIPTION() macros Jeff Johnson
@ 2024-06-20 16:45 ` Jeff Johnson
2024-06-20 18:57 ` Kees Cook
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Johnson @ 2024-06-20 16:45 UTC (permalink / raw)
To: Andrew Morton, Kees Cook, Andy Shevchenko
Cc: linux-hardening, linux-kernel, kernel-janitors
On 5/31/2024 4:07 PM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/string_kunit.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/string_helpers_kunit.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> lib/string_helpers_kunit.c | 1 +
> lib/string_kunit.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/lib/string_helpers_kunit.c b/lib/string_helpers_kunit.c
> index f88e39fd68d6..c853046183d2 100644
> --- a/lib/string_helpers_kunit.c
> +++ b/lib/string_helpers_kunit.c
> @@ -625,4 +625,5 @@ static struct kunit_suite string_helpers_test_suite = {
>
> kunit_test_suites(&string_helpers_test_suite);
>
> +MODULE_DESCRIPTION("Test cases for string helpers module");
> MODULE_LICENSE("Dual BSD/GPL");
> diff --git a/lib/string_kunit.c b/lib/string_kunit.c
> index 2a812decf14b..c919e3293da6 100644
> --- a/lib/string_kunit.c
> +++ b/lib/string_kunit.c
> @@ -633,4 +633,5 @@ static struct kunit_suite string_test_suite = {
>
> kunit_test_suites(&string_test_suite);
>
> +MODULE_DESCRIPTION("Test cases for string functions");
> MODULE_LICENSE("GPL v2");
>
> ---
> base-commit: b050496579632f86ee1ef7e7501906db579f3457
> change-id: 20240531-md-lib-string-d987d813b344
>
I don't see this in linux-next yet so following up to see if anything else is
needed to get this merged.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] string: kunit: add missing MODULE_DESCRIPTION() macros
2024-05-31 23:07 [PATCH] string: kunit: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-20 16:45 ` Jeff Johnson
@ 2024-06-20 18:57 ` Kees Cook
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2024-06-20 18:57 UTC (permalink / raw)
To: Andrew Morton, Andy Shevchenko, Kees Cook, Jeff Johnson
Cc: linux-hardening, linux-kernel, kernel-janitors
On Fri, 31 May 2024 16:07:26 -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/string_kunit.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/string_helpers_kunit.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
>
> [...]
Applied to for-next/hardening, thanks!
[1/1] string: kunit: add missing MODULE_DESCRIPTION() macros
https://git.kernel.org/kees/c/e3890eadadad
Take care,
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-20 18:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-31 23:07 [PATCH] string: kunit: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-20 16:45 ` Jeff Johnson
2024-06-20 18:57 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®