mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Dahl <ada@thorsis.com>
To: nicolas.ferre@microchip.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>,
	stable@vger.kernel.org, Ahmad Fatoum <a.fatoum@pengutronix.de>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: at91-sama5d27_som1: fix phy address to 7
Date: Tue, 23 Mar 2021 11:45:55 +0100 (CET)	[thread overview]
Message-ID: <1732882030.11903.1616496356027@seven.thorsis.com> (raw)
In-Reply-To: <20210217113808.21804-1-nicolas.ferre@microchip.com>

Hei hei,

I could not get ethernet to work on SAMA5D27-SOM1-EK1 with kernels v5.10 and v5.11 built by a recent ptxdist based DistroKit BSP, while it used to work with an older v4.19 kernel. Just applying this patch to the tree made ethernet working again, thus:

Tested-by: Alexander Dahl <ada@thorsis.com>

Not sure why it worked with that older kernel, though.

I added Ahmad to Cc, he added board support to DistroKit for that board, and might want to know. And I added the devicetree list to Cc, I wondered why the patch was not there and get_maintainers.pl proposed it.

Thanks for fixing this and greetings
Alex

> nicolas.ferre@microchip.com hat am 17.02.2021 12:38 geschrieben:
> 
>  
> From: Claudiu Beznea <claudiu.beznea@microchip.com>
> 
> Fix the phy address to 7 for Ethernet PHY on SAMA5D27 SOM1. No
> connection established if phy address 0 is used.
> 
> The board uses the 24 pins version of the KSZ8081RNA part, KSZ8081RNA
> pin 16 REFCLK as PHYAD bit [2] has weak internal pull-down.  But at
> reset, connected to PD09 of the MPU it's connected with an internal
> pull-up forming PHYAD[2:0] = 7.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> Fixes: 2f61929eb10a ("ARM: dts: at91: at91-sama5d27_som1: fix PHY ID")
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: <stable@vger.kernel.org> # 4.14+
> ---
>  arch/arm/boot/dts/at91-sama5d27_som1.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d27_som1.dtsi b/arch/arm/boot/dts/at91-sama5d27_som1.dtsi
> index 1b1163858b1d..e3251f3e3eaa 100644
> --- a/arch/arm/boot/dts/at91-sama5d27_som1.dtsi
> +++ b/arch/arm/boot/dts/at91-sama5d27_som1.dtsi
> @@ -84,8 +84,8 @@ macb0: ethernet@f8008000 {
>  				pinctrl-0 = <&pinctrl_macb0_default>;
>  				phy-mode = "rmii";
>  
> -				ethernet-phy@0 {
> -					reg = <0x0>;
> +				ethernet-phy@7 {
> +					reg = <0x7>;
>  					interrupt-parent = <&pioA>;
>  					interrupts = <PIN_PD31 IRQ_TYPE_LEVEL_LOW>;
>  					pinctrl-names = "default";
> -- 
> 2.30.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-23 10:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 11:38 nicolas.ferre
2021-03-23 10:45 ` Alexander Dahl [this message]
2021-03-23 10:55   ` Ahmad Fatoum
2021-03-23 11:17     ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1732882030.11903.1616496356027@seven.thorsis.com \
    --to=ada@thorsis.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®