[PATCH v2] platform/x86/tuxedo: Prevent invalid Kconfig state

[PATCH v2] platform/x86/tuxedo: Prevent invalid Kconfig state

[Werner Sembach]

It was possible to create a uncompileable config, because of missing
"Depends on" statements in the new Kconfig of the TUXEDO platform driver.

Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Closes: https://lore.kernel.org/all/a1d9134f-0567-4a53-a1e7-a55cd6b189a9@infradead.org/
---
 drivers/platform/x86/tuxedo/nb04/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/platform/x86/tuxedo/nb04/Kconfig b/drivers/platform/x86/tuxedo/nb04/Kconfig
index 411c46c9a1cf0..9e7a9f9230d1c 100644
--- a/drivers/platform/x86/tuxedo/nb04/Kconfig
+++ b/drivers/platform/x86/tuxedo/nb04/Kconfig
@@ -7,6 +7,8 @@
 
 config TUXEDO_NB04_WMI_AB
 	tristate "TUXEDO NB04 WMI AB Platform Driver"
+	depends on ACPI_WMI
+	depends on HID
 	help
 	  This driver implements the WMI AB device found on TUXEDO notebooks
 	  with board vendor NB04. This enables keyboard backlight control via a
-- 
2.43.0

Re: [PATCH v2] platform/x86/tuxedo: Prevent invalid Kconfig state

[Ilpo Järvinen]

On Mon, 12 May 2025 14:54:32 +0200, Werner Sembach wrote:

> It was possible to create a uncompileable config, because of missing
> "Depends on" statements in the new Kconfig of the TUXEDO platform driver.
> 
> 


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86/tuxedo: Prevent invalid Kconfig state
      commit: 4bba84f62a90a23d780cdad2c320f77d854a6e64

--
 i.

Re: [PATCH v2] platform/x86/tuxedo: Prevent invalid Kconfig state

[Randy Dunlap]

On 5/12/25 5:54 AM, Werner Sembach wrote:
> It was possible to create a uncompileable config, because of missing
> "Depends on" statements in the new Kconfig of the TUXEDO platform driver.
> 
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/all/a1d9134f-0567-4a53-a1e7-a55cd6b189a9@infradead.org/

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.


> ---
>  drivers/platform/x86/tuxedo/nb04/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/tuxedo/nb04/Kconfig b/drivers/platform/x86/tuxedo/nb04/Kconfig
> index 411c46c9a1cf0..9e7a9f9230d1c 100644
> --- a/drivers/platform/x86/tuxedo/nb04/Kconfig
> +++ b/drivers/platform/x86/tuxedo/nb04/Kconfig
> @@ -7,6 +7,8 @@
>  
>  config TUXEDO_NB04_WMI_AB
>  	tristate "TUXEDO NB04 WMI AB Platform Driver"
> +	depends on ACPI_WMI
> +	depends on HID
>  	help
>  	  This driver implements the WMI AB device found on TUXEDO notebooks
>  	  with board vendor NB04. This enables keyboard backlight control via a

-- 
~Randy