* [PATCH v2] platform/x86/tuxedo: Prevent invalid Kconfig state
@ 2025-05-12 12:54 Werner Sembach
2025-05-12 16:43 ` Ilpo Järvinen
2025-05-12 23:18 ` Randy Dunlap
0 siblings, 2 replies; 3+ messages in thread
From: Werner Sembach @ 2025-05-12 12:54 UTC (permalink / raw)
To: rdunlap, sfr, linux-next, W_Armin, Werner Sembach, Hans de Goede,
Ilpo Järvinen
Cc: platform-driver-x86, linux-kernel
It was possible to create a uncompileable config, because of missing
"Depends on" statements in the new Kconfig of the TUXEDO platform driver.
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Closes: https://lore.kernel.org/all/a1d9134f-0567-4a53-a1e7-a55cd6b189a9@infradead.org/
---
drivers/platform/x86/tuxedo/nb04/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/platform/x86/tuxedo/nb04/Kconfig b/drivers/platform/x86/tuxedo/nb04/Kconfig
index 411c46c9a1cf0..9e7a9f9230d1c 100644
--- a/drivers/platform/x86/tuxedo/nb04/Kconfig
+++ b/drivers/platform/x86/tuxedo/nb04/Kconfig
@@ -7,6 +7,8 @@
config TUXEDO_NB04_WMI_AB
tristate "TUXEDO NB04 WMI AB Platform Driver"
+ depends on ACPI_WMI
+ depends on HID
help
This driver implements the WMI AB device found on TUXEDO notebooks
with board vendor NB04. This enables keyboard backlight control via a
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] platform/x86/tuxedo: Prevent invalid Kconfig state
2025-05-12 12:54 [PATCH v2] platform/x86/tuxedo: Prevent invalid Kconfig state Werner Sembach
@ 2025-05-12 16:43 ` Ilpo Järvinen
2025-05-12 23:18 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Ilpo Järvinen @ 2025-05-12 16:43 UTC (permalink / raw)
To: rdunlap, sfr, linux-next, W_Armin, Hans de Goede, Werner Sembach
Cc: platform-driver-x86, linux-kernel
On Mon, 12 May 2025 14:54:32 +0200, Werner Sembach wrote:
> It was possible to create a uncompileable config, because of missing
> "Depends on" statements in the new Kconfig of the TUXEDO platform driver.
>
>
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86/tuxedo: Prevent invalid Kconfig state
commit: 4bba84f62a90a23d780cdad2c320f77d854a6e64
--
i.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] platform/x86/tuxedo: Prevent invalid Kconfig state
2025-05-12 12:54 [PATCH v2] platform/x86/tuxedo: Prevent invalid Kconfig state Werner Sembach
2025-05-12 16:43 ` Ilpo Järvinen
@ 2025-05-12 23:18 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2025-05-12 23:18 UTC (permalink / raw)
To: Werner Sembach, sfr, linux-next, W_Armin, Hans de Goede,
Ilpo Järvinen
Cc: platform-driver-x86, linux-kernel
On 5/12/25 5:54 AM, Werner Sembach wrote:
> It was possible to create a uncompileable config, because of missing
> "Depends on" statements in the new Kconfig of the TUXEDO platform driver.
>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/all/a1d9134f-0567-4a53-a1e7-a55cd6b189a9@infradead.org/
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/platform/x86/tuxedo/nb04/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/platform/x86/tuxedo/nb04/Kconfig b/drivers/platform/x86/tuxedo/nb04/Kconfig
> index 411c46c9a1cf0..9e7a9f9230d1c 100644
> --- a/drivers/platform/x86/tuxedo/nb04/Kconfig
> +++ b/drivers/platform/x86/tuxedo/nb04/Kconfig
> @@ -7,6 +7,8 @@
>
> config TUXEDO_NB04_WMI_AB
> tristate "TUXEDO NB04 WMI AB Platform Driver"
> + depends on ACPI_WMI
> + depends on HID
> help
> This driver implements the WMI AB device found on TUXEDO notebooks
> with board vendor NB04. This enables keyboard backlight control via a
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-12 23:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-12 12:54 [PATCH v2] platform/x86/tuxedo: Prevent invalid Kconfig state Werner Sembach
2025-05-12 16:43 ` Ilpo Järvinen
2025-05-12 23:18 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®