[PATCH] Revert "platform/x86: alienware-wmi-wmax: Add G-Mode support to Alienware m16 R1"

[PATCH] Revert "platform/x86: alienware-wmi-wmax: Add G-Mode support to Alienware m16 R1"

[Kurt Borja]

This reverts commit 5ff79cabb23a2f14d2ed29e9596aec908905a0e6.

Although the Alienware m16 R1 AMD model supports G-Mode, it actually has
a lower power ceiling than plain "performance" profile, which results in
lower performance.

Reported-by: Cihan Ozakca <cozakca@outlook.com>
Cc: stable@vger.kernel.org # 6.15.x
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
Hi all,

Contrary to (my) intuition, imitating Windows behavior actually results
in LOWER performance.

I was having second thoughts about this revert because users will notice
that "performance" not longer turns on the G-Mode key found in this
laptop. Some users may think this is actually a regression, but IMO
lower performance is worse.
---
 drivers/platform/x86/dell/alienware-wmi-wmax.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/dell/alienware-wmi-wmax.c b/drivers/platform/x86/dell/alienware-wmi-wmax.c
index c42f9228b0b255fe962b735ac96486824e83945f..20ec122a9fe0571a1ecd2ccf630615564ab30481 100644
--- a/drivers/platform/x86/dell/alienware-wmi-wmax.c
+++ b/drivers/platform/x86/dell/alienware-wmi-wmax.c
@@ -119,7 +119,7 @@ static const struct dmi_system_id awcc_dmi_table[] __initconst = {
 			DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "Alienware m16 R1 AMD"),
 		},
-		.driver_data = &g_series_quirks,
+		.driver_data = &generic_quirks,
 	},
 	{
 		.ident = "Alienware m16 R2",

---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250611-m16-rev-8109b82dee30
-- 
 ~ Kurt

Re: [PATCH] Revert "platform/x86: alienware-wmi-wmax: Add G-Mode support to Alienware m16 R1"

[Ilpo Järvinen]

On Wed, 11 Jun 2025 18:30:40 -0300, Kurt Borja wrote:

> This reverts commit 5ff79cabb23a2f14d2ed29e9596aec908905a0e6.
> 
> Although the Alienware m16 R1 AMD model supports G-Mode, it actually has
> a lower power ceiling than plain "performance" profile, which results in
> lower performance.
> 
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] Revert "platform/x86: alienware-wmi-wmax: Add G-Mode support to Alienware m16 R1"
      commit: e2468dc700743683e1d1793bbd855e2536fd3de2

--
 i.

Re: [PATCH] Revert "platform/x86: alienware-wmi-wmax: Add G-Mode support to Alienware m16 R1"

[Konstantin Kharlamov]

On Wed, 2025-06-11 at 18:30 -0300, Kurt Borja wrote:
> This reverts commit 5ff79cabb23a2f14d2ed29e9596aec908905a0e6.
> 
> Although the Alienware m16 R1 AMD model supports G-Mode, it actually
> has
> a lower power ceiling than plain "performance" profile, which results
> in
> lower performance.
> 
> Reported-by: Cihan Ozakca <cozakca@outlook.com>
> Cc: stable@vger.kernel.org # 6.15.x
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
> Hi all,
> 
> Contrary to (my) intuition, imitating Windows behavior actually
> results
> in LOWER performance.
> 
> I was having second thoughts about this revert because users will
> notice
> that "performance" not longer turns on the G-Mode key found in this
> laptop. Some users may think this is actually a regression, but IMO
> lower performance is worse.
> ---
>  drivers/platform/x86/dell/alienware-wmi-wmax.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/dell/alienware-wmi-wmax.c
> b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> index
> c42f9228b0b255fe962b735ac96486824e83945f..20ec122a9fe0571a1ecd2ccf630
> 615564ab30481 100644
> --- a/drivers/platform/x86/dell/alienware-wmi-wmax.c
> +++ b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> @@ -119,7 +119,7 @@ static const struct dmi_system_id
> awcc_dmi_table[] __initconst = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Alienware m16
> R1 AMD"),
>  		},
> -		.driver_data = &g_series_quirks,
> +		.driver_data = &generic_quirks,
>  	},
>  	{
>  		.ident = "Alienware m16 R2",

I think, at least a code comment explaining the situation is warranted
(or maybe even a print on keypress or both), because otherwise sometime
in the future other people may try to add the functional back, and then
yet other people may again revert it, regressing things back and forth.