From: "tip-bot2 for Sebastian Andrzej Siewior" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Chris Mason <clm@meta.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: locking/urgent] futex: Temporary disable FUTEX_PRIVATE_HASH
Date: Tue, 01 Jul 2025 13:13:03 -0000 [thread overview]
Message-ID: <175137558397.406.5841065111175109427.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250630145034.8JnINEaS@linutronix.de>
The following commit has been merged into the locking/urgent branch of tip:
Commit-ID: 9a57c3773152a3ff2c35cc8325e088d011c9f83b
Gitweb: https://git.kernel.org/tip/9a57c3773152a3ff2c35cc8325e088d011c9f83b
Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
AuthorDate: Mon, 30 Jun 2025 16:50:34 +02:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Tue, 01 Jul 2025 15:02:05 +02:00
futex: Temporary disable FUTEX_PRIVATE_HASH
Chris Mason reported a performance regression on big iron. Reports of
this kind were usually reported as part of a micro benchmark but Chris'
test did mimic his real workload. This makes it a real regression.
The root cause is rcuref_get() which is invoked during each futex
operation. If all threads of an application do this simultaneously then
it leads to cache line bouncing and the performance drops.
Disable FUTEX_PRIVATE_HASH entirely for this cycle. The performance
regression will be addressed in the following cycle enabling the option
again.
Closes: https://lore.kernel.org/all/3ad05298-351e-4d61-9972-ca45a0a50e33@meta.com/
Reported-by: Chris Mason <clm@meta.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20250630145034.8JnINEaS@linutronix.de
---
init/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/init/Kconfig b/init/Kconfig
index af4c2f0..666783e 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1716,9 +1716,13 @@ config FUTEX_PI
depends on FUTEX && RT_MUTEXES
default y
+#
+# marked broken for performance reasons; gives us one more cycle to sort things out.
+#
config FUTEX_PRIVATE_HASH
bool
depends on FUTEX && !BASE_SMALL && MMU
+ depends on BROKEN
default y
config FUTEX_MPOL
next prev parent reply other threads:[~2025-07-01 13:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 19:00 futex performance regression from "futex: Allow automatic allocation of process wide futex hash" Chris Mason
2025-06-04 9:28 ` Sebastian Andrzej Siewior
2025-06-04 15:48 ` Chris Mason
2025-06-04 20:08 ` Sebastian Andrzej Siewior
2025-06-06 0:55 ` Chris Mason
2025-06-06 7:06 ` Sebastian Andrzej Siewior
2025-06-06 21:06 ` Chris Mason
2025-06-06 22:17 ` Chris Mason
2025-06-24 19:01 ` Peter Zijlstra
2025-06-26 11:01 ` Chris Mason
2025-06-26 13:17 ` Peter Zijlstra
2025-06-26 13:50 ` Sebastian Andrzej Siewior
2025-06-27 11:04 ` Peter Zijlstra
2025-06-27 12:14 ` Sebastian Andrzej Siewior
2025-06-30 14:50 ` [PATCH] futex: Temporary disable FUTEX_PRIVATE_HASH Sebastian Andrzej Siewior
2025-07-01 13:13 ` tip-bot2 for Sebastian Andrzej Siewior [this message]
2025-07-16 1:34 ` kernel test robot
2025-06-26 13:48 ` futex performance regression from "futex: Allow automatic allocation of process wide futex hash" Sebastian Andrzej Siewior
2025-06-26 14:36 ` Peter Zijlstra
2025-06-27 12:24 ` Sebastian Andrzej Siewior
2025-06-27 22:48 ` Tim Chen
2025-06-28 8:23 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175137558397.406.5841065111175109427.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=clm@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®