From: Peter Zijlstra <peterz@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Chris Mason <clm@meta.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: futex performance regression from "futex: Allow automatic allocation of process wide futex hash"
Date: Fri, 27 Jun 2025 13:04:57 +0200 [thread overview]
Message-ID: <20250627110457.GA1613200@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250626135034.18sab4Xp@linutronix.de>
On Thu, Jun 26, 2025 at 03:50:34PM +0200, Sebastian Andrzej Siewior wrote:
> On 2025-06-26 15:17:15 [+0200], Peter Zijlstra wrote:
> > > I'd vote for defaulting to global for one more release.
> >
> > Probably best to do that; means we don't have to rush crazy code :-)
>
> If we do that, that means we need to ensure that the private hash is not
> deployed while a thread is created and the prctl() function can only
> work create the private hash if the application is single threaded.
I was thinking something like so..
---
diff --git a/init/Kconfig b/init/Kconfig
index af4c2f085455..666783eb50ab 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1716,9 +1716,13 @@ config FUTEX_PI
depends on FUTEX && RT_MUTEXES
default y
+#
+# marked broken for performance reasons; gives us one more cycle to sort things out.
+#
config FUTEX_PRIVATE_HASH
bool
depends on FUTEX && !BASE_SMALL && MMU
+ depends on BROKEN
default y
config FUTEX_MPOL
next prev parent reply other threads:[~2025-06-27 11:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 19:00 Chris Mason
2025-06-04 9:28 ` Sebastian Andrzej Siewior
2025-06-04 15:48 ` Chris Mason
2025-06-04 20:08 ` Sebastian Andrzej Siewior
2025-06-06 0:55 ` Chris Mason
2025-06-06 7:06 ` Sebastian Andrzej Siewior
2025-06-06 21:06 ` Chris Mason
2025-06-06 22:17 ` Chris Mason
2025-06-24 19:01 ` Peter Zijlstra
2025-06-26 11:01 ` Chris Mason
2025-06-26 13:17 ` Peter Zijlstra
2025-06-26 13:50 ` Sebastian Andrzej Siewior
2025-06-27 11:04 ` Peter Zijlstra [this message]
2025-06-27 12:14 ` Sebastian Andrzej Siewior
2025-06-30 14:50 ` [PATCH] futex: Temporary disable FUTEX_PRIVATE_HASH Sebastian Andrzej Siewior
2025-07-01 13:13 ` [tip: locking/urgent] " tip-bot2 for Sebastian Andrzej Siewior
2025-07-16 1:34 ` [PATCH] " kernel test robot
2025-06-26 13:48 ` futex performance regression from "futex: Allow automatic allocation of process wide futex hash" Sebastian Andrzej Siewior
2025-06-26 14:36 ` Peter Zijlstra
2025-06-27 12:24 ` Sebastian Andrzej Siewior
2025-06-27 22:48 ` Tim Chen
2025-06-28 8:23 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250627110457.GA1613200@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=clm@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®