* [PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support
@ 2025-06-23 5:49 Maulik Shah
2025-06-23 6:21 ` neil.armstrong
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Maulik Shah @ 2025-06-23 5:49 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio; +Cc: linux-arm-msm, linux-kernel, Maulik Shah
Register offsets for v3 and v4 versions are backward compatible. Assign v3
offsets for v4 and all higher versions to avoid end up using v2 offsets.
Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
---
drivers/soc/qcom/rpmh-rsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
index cb82e887b51d4401edba713348eed9621622b73b..fdab2b1067dbb13efbbef5cc3ef795a65fc2d6a1 100644
--- a/drivers/soc/qcom/rpmh-rsc.c
+++ b/drivers/soc/qcom/rpmh-rsc.c
@@ -1072,7 +1072,7 @@ static int rpmh_rsc_probe(struct platform_device *pdev)
drv->ver.minor = rsc_id & (MINOR_VER_MASK << MINOR_VER_SHIFT);
drv->ver.minor >>= MINOR_VER_SHIFT;
- if (drv->ver.major == 3)
+ if (drv->ver.major >= 3)
drv->regs = rpmh_rsc_reg_offset_ver_3_0;
else
drv->regs = rpmh_rsc_reg_offset_ver_2_7;
---
base-commit: 5d4809e25903ab8e74034c1f23c787fd26d52934
change-id: 20250623-rsc_v4-ec10a1aadbb8
Best regards,
--
Maulik Shah <maulik.shah@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support
2025-06-23 5:49 [PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support Maulik Shah
@ 2025-06-23 6:21 ` neil.armstrong
2025-06-23 9:29 ` Konrad Dybcio
2025-07-17 4:31 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: neil.armstrong @ 2025-06-23 6:21 UTC (permalink / raw)
To: Maulik Shah, Bjorn Andersson, Konrad Dybcio; +Cc: linux-arm-msm, linux-kernel
On 23/06/2025 07:49, Maulik Shah wrote:
> Register offsets for v3 and v4 versions are backward compatible. Assign v3
> offsets for v4 and all higher versions to avoid end up using v2 offsets.
>
> Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
> ---
> drivers/soc/qcom/rpmh-rsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
> index cb82e887b51d4401edba713348eed9621622b73b..fdab2b1067dbb13efbbef5cc3ef795a65fc2d6a1 100644
> --- a/drivers/soc/qcom/rpmh-rsc.c
> +++ b/drivers/soc/qcom/rpmh-rsc.c
> @@ -1072,7 +1072,7 @@ static int rpmh_rsc_probe(struct platform_device *pdev)
> drv->ver.minor = rsc_id & (MINOR_VER_MASK << MINOR_VER_SHIFT);
> drv->ver.minor >>= MINOR_VER_SHIFT;
>
> - if (drv->ver.major == 3)
> + if (drv->ver.major >= 3)
> drv->regs = rpmh_rsc_reg_offset_ver_3_0;
> else
> drv->regs = rpmh_rsc_reg_offset_ver_2_7;
>
> ---
> base-commit: 5d4809e25903ab8e74034c1f23c787fd26d52934
> change-id: 20250623-rsc_v4-ec10a1aadbb8
>
> Best regards,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support
2025-06-23 5:49 [PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support Maulik Shah
2025-06-23 6:21 ` neil.armstrong
@ 2025-06-23 9:29 ` Konrad Dybcio
2025-07-17 4:31 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2025-06-23 9:29 UTC (permalink / raw)
To: Maulik Shah, Bjorn Andersson, Konrad Dybcio; +Cc: linux-arm-msm, linux-kernel
On 6/23/25 7:49 AM, Maulik Shah wrote:
> Register offsets for v3 and v4 versions are backward compatible. Assign v3
> offsets for v4 and all higher versions to avoid end up using v2 offsets.
>
> Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support
2025-06-23 5:49 [PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support Maulik Shah
2025-06-23 6:21 ` neil.armstrong
2025-06-23 9:29 ` Konrad Dybcio
@ 2025-07-17 4:31 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2025-07-17 4:31 UTC (permalink / raw)
To: Konrad Dybcio, Maulik Shah; +Cc: linux-arm-msm, linux-kernel
On Mon, 23 Jun 2025 11:19:43 +0530, Maulik Shah wrote:
> Register offsets for v3 and v4 versions are backward compatible. Assign v3
> offsets for v4 and all higher versions to avoid end up using v2 offsets.
>
>
Applied, thanks!
[1/1] soc: qcom: rpmh-rsc: Add RSC version 4 support
commit: 84684c57c9cd47b86c883a7170dd68222d97ef13
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-17 4:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-23 5:49 [PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support Maulik Shah
2025-06-23 6:21 ` neil.armstrong
2025-06-23 9:29 ` Konrad Dybcio
2025-07-17 4:31 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®