From: "tip-bot2 for Donghoon Yu" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Donghoon Yu <hoony.yu@samsung.com>,
Youngmin Nam <youngmin.nam@samsung.com>,
Will McVicker <willmcvicker@google.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Ingo Molnar <mingo@kernel.org>, John Stultz <jstultz@google.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/clocksource] clocksource/drivers/exynos_mct: Don't register as a sched_clock on arm64
Date: Fri, 25 Jul 2025 10:31:43 -0000 [thread overview]
Message-ID: <175343950363.1420.13008443070923899875.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250620181719.1399856-3-willmcvicker@google.com>
The following commit has been merged into the timers/clocksource branch of tip:
Commit-ID: 57eac487dfd1d4342812a78138559f9f1d1d5c08
Gitweb: https://git.kernel.org/tip/57eac487dfd1d4342812a78138559f9f1d1d5c08
Author: Donghoon Yu <hoony.yu@samsung.com>
AuthorDate: Fri, 20 Jun 2025 11:17:05 -07:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Fri, 25 Jul 2025 12:05:32 +02:00
clocksource/drivers/exynos_mct: Don't register as a sched_clock on arm64
The MCT register is unfortunately very slow to access, but importantly
does not halt in the c2 idle state. So for ARM64, we can improve
performance by not registering the MCT for sched_clock, allowing the
system to use the faster ARM architected timer for sched_clock instead.
The MCT is still registered as a clocksource, and a clockevent in order
to be a wakeup source for the arch_timer to exit the "c2" idle state.
Since ARM32 SoCs don't have an architected timer, the MCT must continue
to be used for sched_clock. Detailed discussion on this topic can be
found at:
https://lore.kernel.org/linux-samsung-soc/1400188079-21832-1-git-send-email-chirantan@chromium.org/
Original commit from:
https://android.googlesource.com/kernel/gs/+/630817f7080e92c5e0216095ff52f6eb8dd00727
Signed-off-by: Donghoon Yu <hoony.yu@samsung.com>
Signed-off-by: Youngmin Nam <youngmin.nam@samsung.com>
Signed-off-by: Will McVicker <willmcvicker@google.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: John Stultz <jstultz@google.com>
Link: https://lore.kernel.org/r/20250620181719.1399856-3-willmcvicker@google.com
---
drivers/clocksource/exynos_mct.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index da09f46..96361d5 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -219,12 +219,18 @@ static struct clocksource mct_frc = {
.resume = exynos4_frc_resume,
};
+/*
+ * Since ARM devices do not have an architected timer, they need to continue
+ * using the MCT as the main clocksource for timekeeping, sched_clock, and the
+ * delay timer. For AARCH64 SoCs, the architected timer is the preferred
+ * clocksource due to it's superior performance.
+ */
+#if defined(CONFIG_ARM)
static u64 notrace exynos4_read_sched_clock(void)
{
return exynos4_read_count_32();
}
-#if defined(CONFIG_ARM)
static struct delay_timer exynos4_delay_timer;
static cycles_t exynos4_read_current_timer(void)
@@ -250,12 +256,13 @@ static int __init exynos4_clocksource_init(bool frc_shared)
exynos4_delay_timer.read_current_timer = &exynos4_read_current_timer;
exynos4_delay_timer.freq = clk_rate;
register_current_timer_delay(&exynos4_delay_timer);
+
+ sched_clock_register(exynos4_read_sched_clock, 32, clk_rate);
#endif
if (clocksource_register_hz(&mct_frc, clk_rate))
panic("%s: can't register clocksource\n", mct_frc.name);
- sched_clock_register(exynos4_read_sched_clock, 32, clk_rate);
return 0;
}
next prev parent reply other threads:[~2025-07-25 10:31 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 18:17 [PATCH v4 0/6] Add module support for Arm64 Exynos MCT driver Will McVicker
2025-06-20 18:17 ` [PATCH v4 1/6] of/irq: Export of_irq_count for modules Will McVicker
2025-07-23 7:17 ` [tip: timers/clocksource] " tip-bot2 for Will McVicker
2025-07-25 10:31 ` [tip: timers/clocksource] of/irq: Export of_irq_count() " tip-bot2 for Will McVicker
2025-06-20 18:17 ` [PATCH v4 2/6] clocksource/drivers/exynos_mct: Don't register as a sched_clock on arm64 Will McVicker
2025-07-23 7:17 ` [tip: timers/clocksource] " tip-bot2 for Will McVicker
2025-07-24 5:16 ` Ingo Molnar
2025-07-24 5:20 ` Ingo Molnar
2025-07-24 9:25 ` Thomas Gleixner
2025-07-24 10:04 ` Daniel Lezcano
2025-07-25 10:34 ` Ingo Molnar
2025-07-25 13:15 ` Daniel Lezcano
2025-07-29 7:58 ` Daniel Lezcano
2025-07-29 8:58 ` Thomas Gleixner
2025-07-29 9:03 ` Thomas Gleixner
2025-07-29 9:07 ` Krzysztof Kozlowski
2025-07-29 9:13 ` Daniel Lezcano
2025-07-29 16:13 ` Thomas Gleixner
2025-07-29 16:27 ` Daniel Lezcano
2025-07-25 10:31 ` tip-bot2 for Donghoon Yu [this message]
2025-06-20 18:17 ` [PATCH v4 3/6] clocksource/drivers/exynos_mct: Set local timer interrupts as percpu Will McVicker
2025-07-23 7:17 ` [tip: timers/clocksource] " tip-bot2 for Hosung Kim
2025-07-25 10:31 ` tip-bot2 for Hosung Kim
2025-08-26 13:51 ` [PATCH v4 3/6] " Marek Szyprowski
2025-06-20 18:17 ` [PATCH v4 4/6] clocksource/drivers/exynos_mct: Fix uninitialized irq name warning Will McVicker
2025-07-23 7:17 ` [tip: timers/clocksource] " tip-bot2 for Will McVicker
2025-07-25 10:31 ` [tip: timers/clocksource] clocksource/drivers/exynos_mct: Fix uninitialized IRQ " tip-bot2 for Will McVicker
2025-06-20 18:17 ` [PATCH v4 5/6] clocksource/drivers/exynos_mct: Add module support Will McVicker
2025-06-24 13:48 ` Daniel Lezcano
2025-06-24 23:47 ` William McVicker
2025-06-25 9:23 ` Daniel Lezcano
2025-07-15 12:18 ` [PATCH] clocksource/drivers/exynos_mct: Fix section mismatch from the module conversion Daniel Lezcano
2025-07-15 17:23 ` William McVicker
2025-07-18 9:53 ` Arnd Bergmann
2025-07-23 7:17 ` [tip: timers/clocksource] " tip-bot2 for Daniel Lezcano
2025-07-25 8:48 ` [PATCH] " Krzysztof Kozlowski
2025-07-25 8:52 ` Krzysztof Kozlowski
2025-07-25 10:31 ` [tip: timers/clocksource] " tip-bot2 for Daniel Lezcano
2025-07-23 7:17 ` [tip: timers/clocksource] clocksource/drivers/exynos_mct: Add module support tip-bot2 for Donghoon Yu
2025-07-25 9:40 ` [PATCH v4 5/6] " Daniel Lezcano
2025-07-25 10:31 ` [tip: timers/clocksource] " tip-bot2 for Donghoon Yu
2025-06-20 18:17 ` [PATCH v4 6/6] arm64: exynos: Drop select CLKSRC_EXYNOS_MCT Will McVicker
2025-07-23 7:17 ` [tip: timers/clocksource] " tip-bot2 for Will McVicker
2025-07-25 10:31 ` tip-bot2 for Will McVicker
2025-07-15 11:03 ` [PATCH v4 0/6] Add module support for Arm64 Exynos MCT driver Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175343950363.1420.13008443070923899875.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=daniel.lezcano@linaro.org \
--cc=hoony.yu@samsung.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=willmcvicker@google.com \
--cc=x86@kernel.org \
--cc=youngmin.nam@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®