* [PATCH v2] ASoC: amd: acp: Adjust pdm gain value
@ 2025-08-21 5:45 Venkata Prasad Potturu
2025-08-21 13:06 ` Mario Limonciello
2025-09-02 11:51 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Venkata Prasad Potturu @ 2025-08-21 5:45 UTC (permalink / raw)
To: broonie, alsa-devel
Cc: Vijendar.Mukunda, Basavaraj.Hiregoudar, Sunil-kumar.Dommati,
syed.sabakareem, Venkata Prasad Potturu, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Mario Limonciello,
open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
open list
Set pdm gain value by setting PDM_MISC_CTRL_MASK value.
To avoid low pdm gain value.
Signed-off-by: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
---
Changes since v1:
- remove pdm gain adjustment using module parameter.
sound/soc/amd/acp/amd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h
index cb8d97122f95..73a028e67246 100644
--- a/sound/soc/amd/acp/amd.h
+++ b/sound/soc/amd/acp/amd.h
@@ -130,7 +130,7 @@
#define PDM_DMA_INTR_MASK 0x10000
#define PDM_DEC_64 0x2
#define PDM_CLK_FREQ_MASK 0x07
-#define PDM_MISC_CTRL_MASK 0x10
+#define PDM_MISC_CTRL_MASK 0x18
#define PDM_ENABLE 0x01
#define PDM_DISABLE 0x00
#define DMA_EN_MASK 0x02
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ASoC: amd: acp: Adjust pdm gain value
2025-08-21 5:45 [PATCH v2] ASoC: amd: acp: Adjust pdm gain value Venkata Prasad Potturu
@ 2025-08-21 13:06 ` Mario Limonciello
2025-09-02 11:51 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mario Limonciello @ 2025-08-21 13:06 UTC (permalink / raw)
To: Venkata Prasad Potturu, broonie, alsa-devel
Cc: Vijendar.Mukunda, Basavaraj.Hiregoudar, Sunil-kumar.Dommati,
syed.sabakareem, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
open list
On 8/21/2025 12:45 AM, Venkata Prasad Potturu wrote:
> Set pdm gain value by setting PDM_MISC_CTRL_MASK value.
> To avoid low pdm gain value.
>
> Signed-off-by: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
> ---
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
>
> Changes since v1:
> - remove pdm gain adjustment using module parameter.
>
> sound/soc/amd/acp/amd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h
> index cb8d97122f95..73a028e67246 100644
> --- a/sound/soc/amd/acp/amd.h
> +++ b/sound/soc/amd/acp/amd.h
> @@ -130,7 +130,7 @@
> #define PDM_DMA_INTR_MASK 0x10000
> #define PDM_DEC_64 0x2
> #define PDM_CLK_FREQ_MASK 0x07
> -#define PDM_MISC_CTRL_MASK 0x10
> +#define PDM_MISC_CTRL_MASK 0x18
> #define PDM_ENABLE 0x01
> #define PDM_DISABLE 0x00
> #define DMA_EN_MASK 0x02
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ASoC: amd: acp: Adjust pdm gain value
2025-08-21 5:45 [PATCH v2] ASoC: amd: acp: Adjust pdm gain value Venkata Prasad Potturu
2025-08-21 13:06 ` Mario Limonciello
@ 2025-09-02 11:51 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2025-09-02 11:51 UTC (permalink / raw)
To: alsa-devel, Venkata Prasad Potturu
Cc: Vijendar.Mukunda, Basavaraj.Hiregoudar, Sunil-kumar.Dommati,
syed.sabakareem, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
Mario Limonciello,
open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
open list
On Thu, 21 Aug 2025 11:15:47 +0530, Venkata Prasad Potturu wrote:
> Set pdm gain value by setting PDM_MISC_CTRL_MASK value.
> To avoid low pdm gain value.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: amd: acp: Adjust pdm gain value
commit: f1d0260362d72f9f454dc1f9db2eeb80cb801f28
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-02 11:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-21 5:45 [PATCH v2] ASoC: amd: acp: Adjust pdm gain value Venkata Prasad Potturu
2025-08-21 13:06 ` Mario Limonciello
2025-09-02 11:51 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®