From: "Rob Herring (Arm)" <robh@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Andy Shevchenko" <andy@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Sean Anderson" <sean.anderson@linux.dev>,
linux-spi@vger.kernel.org,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Michael Hennerich" <michael.hennerich@analog.com>,
linux-kernel@vger.kernel.org, "Mark Brown" <broonie@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
"Conor Dooley" <conor+dt@kernel.org>
Subject: Re: [PATCH v4 2/9] spi: dt-bindings: add spi-{tx,rx}-lane-map properties
Date: Fri, 19 Dec 2025 16:40:19 -0600 [thread overview]
Message-ID: <176618401962.78408.15730875002100053150.robh@kernel.org> (raw)
In-Reply-To: <20251219-spi-add-multi-bus-support-v4-2-145dc5204cd8@baylibre.com>
On Fri, 19 Dec 2025 15:32:10 -0600, David Lechner wrote:
> Add spi-tx-lane-map and spi-rx-lane-map properties to the SPI peripheral
> device tree binding. These properties allow specifying the mapping of
> peripheral data lanes to controller data lanes. This is needed e.g. when
> some lanes are skipped on the controller side so that the controller
> can correctly route data to/from the peripheral.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
>
> v4 changes:
> - This replaces the data-lanes property from the previous revision. Now
> there are separate properties for tx and rx lane maps. And instead of
> being the primary property for determining the number of lanes, this
> is only needed in special cases where the mapping is non-trivial.
> ---
> .../devicetree/bindings/spi/spi-peripheral-props.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/andestech,ae350-spi.example.dtb: spi@f0b00000 (andestech,ae350-spi): flash@0:spi-rx-bus-width: [4] is not one of [1, 4]
from schema $id: http://devicetree.org/schemas/spi/andestech,ae350-spi.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/andestech,ae350-spi.example.dtb: spi@f0b00000 (andestech,ae350-spi): flash@0:spi-tx-bus-width: [4] is not one of [1, 4]
from schema $id: http://devicetree.org/schemas/spi/andestech,ae350-spi.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20251219-spi-add-multi-bus-support-v4-2-145dc5204cd8@baylibre.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-12-19 22:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 21:32 [PATCH v4 0/9] spi: add multi-lane support David Lechner
2025-12-19 21:32 ` [PATCH v4 1/9] spi: dt-bindings: change spi-{rx,tx}-bus-width to arrays David Lechner
2026-01-06 16:36 ` Rob Herring (Arm)
2026-01-08 12:26 ` Marcelo Schmitt
2026-01-11 11:52 ` Jonathan Cameron
2025-12-19 21:32 ` [PATCH v4 2/9] spi: dt-bindings: add spi-{tx,rx}-lane-map properties David Lechner
2025-12-19 22:40 ` Rob Herring (Arm) [this message]
2026-01-07 15:57 ` Rob Herring (Arm)
2026-01-08 12:29 ` Marcelo Schmitt
2026-01-08 14:40 ` Rob Herring
2025-12-19 21:32 ` [PATCH v4 3/9] spi: support controllers with multiple data lanes David Lechner
2025-12-27 15:16 ` Andy Shevchenko
2026-01-12 17:01 ` David Lechner
2025-12-27 17:18 ` Jonathan Cameron
2025-12-19 21:32 ` [PATCH v4 4/9] spi: add multi_lane_mode field to struct spi_transfer David Lechner
2025-12-27 15:14 ` Andy Shevchenko
2026-01-12 17:10 ` David Lechner
2025-12-19 21:32 ` [PATCH v4 5/9] spi: Documentation: add page on multi-lane support David Lechner
2026-01-08 12:40 ` Marcelo Schmitt
2026-01-08 15:57 ` David Lechner
2026-01-08 12:44 ` Marcelo Schmitt
2026-01-08 15:56 ` David Lechner
2026-01-08 16:43 ` Marcelo Schmitt
2026-01-08 17:22 ` David Lechner
2025-12-19 21:32 ` [PATCH v4 6/9] spi: dt-bindings: adi,axi-spi-engine: add " David Lechner
2026-01-06 16:36 ` Rob Herring (Arm)
2025-12-19 21:32 ` [PATCH v4 7/9] spi: axi-spi-engine: support SPI_MULTI_LANE_MODE_STRIPE David Lechner
2026-01-08 12:45 ` Marcelo Schmitt
2025-12-19 21:32 ` [PATCH v4 8/9] dt-bindings: iio: adc: adi,ad7380: add spi-rx-bus-width property David Lechner
2026-01-06 16:37 ` Rob Herring (Arm)
2025-12-19 21:32 ` [PATCH v4 9/9] iio: adc: ad7380: add support for multiple SPI lanes David Lechner
2026-01-08 12:46 ` Marcelo Schmitt
2026-01-11 11:57 ` [PATCH v4 0/9] spi: add multi-lane support Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176618401962.78408.15730875002100053150.robh@kernel.org \
--to=robh@kernel.org \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®