mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: linux-iio@vger.kernel.org, "Andy Shevchenko" <andy@kernel.org>,
	devicetree@vger.kernel.org, "Nuno Sá" <nuno.sa@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Sean Anderson" <sean.anderson@linux.dev>,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	"Michael Hennerich" <michael.hennerich@analog.com>,
	"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
	"Mark Brown" <broonie@kernel.org>
Subject: Re: [PATCH v4 1/9] spi: dt-bindings: change spi-{rx,tx}-bus-width to arrays
Date: Tue, 6 Jan 2026 10:36:13 -0600	[thread overview]
Message-ID: <176771732187.2212863.8498767353794540092.robh@kernel.org> (raw)
In-Reply-To: <20251219-spi-add-multi-bus-support-v4-1-145dc5204cd8@baylibre.com>


On Fri, 19 Dec 2025 15:32:09 -0600, David Lechner wrote:
> Change spi-rx-bus-width and spi-tx-bus-width properties from single
> uint32 values to arrays of uint32 values. This allows describing SPI
> peripherals connected to controllers that have multiple data lanes for
> receiving or transmitting two or more words in parallel.
> 
> Each index in the array corresponds to a physical data lane (one or more
> wires depending on the bus width). Additional mapping properties will be
> needed in cases where a lane on the controller or peripheral is skipped.
> 
> Bindings that make use of this property are updated in the same commit
> to avoid validation errors.
> 
> The adi,ad4030 binding can now better describe the chips multi-lane
> capabilities, so that binding is refined and gets a new example.
> 
> Converting from single uint32 to array of uint32 does not break .dts/
> .dtb files since there is no difference between specifying a single
> uint32 value and an array with a single uint32 value in devicetree.
> 
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> 
> v4 changes:
> - New patch to replace data-lanes property patch.
> 
> In v3, Rob suggested possibly splitting the spi-controller.yaml file
> to have a way to make most SPI controllers have maxItems: 1 for these
> properties. I would like to avoid that because it doesn't seem scalable,
> e.g. if we need another similar split in the future, the number of
> combinations would grow exponentially (factorially?). I have an idea to
> instead do this using $dynamicAnchor and $dynamicRef, but dt-schema
> doesn't currently support that. So I propose we do the best we can for
> now with the current dt-schema and make further improvements later.
> 
> Also, in v3, I suggested that we could have leading 0s in the arrays
> to indicate unused lanes. But after further consideration, I think it's
> better to have separate lane-mapping properties for that purpose. It
> will be easier to explain and parse and be a bit more flexible that way.
> ---
>  .../bindings/display/panel/sitronix,st7789v.yaml   |  5 +--
>  .../devicetree/bindings/iio/adc/adi,ad4030.yaml    | 42 +++++++++++++++++++++-
>  .../devicetree/bindings/iio/adc/adi,ad4695.yaml    |  5 +--
>  .../bindings/spi/allwinner,sun4i-a10-spi.yaml      |  6 ++--
>  .../bindings/spi/allwinner,sun6i-a31-spi.yaml      |  6 ++--
>  .../bindings/spi/nvidia,tegra210-quad.yaml         |  6 ++--
>  .../bindings/spi/spi-peripheral-props.yaml         | 26 ++++++++++----
>  7 files changed, 79 insertions(+), 17 deletions(-)
> 

You'll need to add spi/andestech,ae350-spi.yaml which is only in Mark's 
tree, but otherwise:

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


  reply	other threads:[~2026-01-06 16:36 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19 21:32 [PATCH v4 0/9] spi: add multi-lane support David Lechner
2025-12-19 21:32 ` [PATCH v4 1/9] spi: dt-bindings: change spi-{rx,tx}-bus-width to arrays David Lechner
2026-01-06 16:36   ` Rob Herring (Arm) [this message]
2026-01-08 12:26   ` Marcelo Schmitt
2026-01-11 11:52   ` Jonathan Cameron
2025-12-19 21:32 ` [PATCH v4 2/9] spi: dt-bindings: add spi-{tx,rx}-lane-map properties David Lechner
2025-12-19 22:40   ` Rob Herring (Arm)
2026-01-07 15:57   ` Rob Herring (Arm)
2026-01-08 12:29   ` Marcelo Schmitt
2026-01-08 14:40     ` Rob Herring
2025-12-19 21:32 ` [PATCH v4 3/9] spi: support controllers with multiple data lanes David Lechner
2025-12-27 15:16   ` Andy Shevchenko
2026-01-12 17:01     ` David Lechner
2025-12-27 17:18   ` Jonathan Cameron
2025-12-19 21:32 ` [PATCH v4 4/9] spi: add multi_lane_mode field to struct spi_transfer David Lechner
2025-12-27 15:14   ` Andy Shevchenko
2026-01-12 17:10     ` David Lechner
2025-12-19 21:32 ` [PATCH v4 5/9] spi: Documentation: add page on multi-lane support David Lechner
2026-01-08 12:40   ` Marcelo Schmitt
2026-01-08 15:57     ` David Lechner
2026-01-08 12:44   ` Marcelo Schmitt
2026-01-08 15:56     ` David Lechner
2026-01-08 16:43       ` Marcelo Schmitt
2026-01-08 17:22         ` David Lechner
2025-12-19 21:32 ` [PATCH v4 6/9] spi: dt-bindings: adi,axi-spi-engine: add " David Lechner
2026-01-06 16:36   ` Rob Herring (Arm)
2025-12-19 21:32 ` [PATCH v4 7/9] spi: axi-spi-engine: support SPI_MULTI_LANE_MODE_STRIPE David Lechner
2026-01-08 12:45   ` Marcelo Schmitt
2025-12-19 21:32 ` [PATCH v4 8/9] dt-bindings: iio: adc: adi,ad7380: add spi-rx-bus-width property David Lechner
2026-01-06 16:37   ` Rob Herring (Arm)
2025-12-19 21:32 ` [PATCH v4 9/9] iio: adc: ad7380: add support for multiple SPI lanes David Lechner
2026-01-08 12:46   ` Marcelo Schmitt
2026-01-11 11:57 ` [PATCH v4 0/9] spi: add multi-lane support Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176771732187.2212863.8498767353794540092.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andy@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marcelo.schmitt@analog.com \
    --cc=michael.hennerich@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=sean.anderson@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®