[PATCH 0/3] Enable analog audio support on J721S2 EVM

[PATCH 0/3] Enable analog audio support on J721S2 EVM

[Moteen Shah]

This patch series, adds support for analog audio on J721S2 EVM

Earlier version of the patchset sent upstream[0] was rejected as
its dependency[1], which resolves the DTBS check errors introduced
by [0] also got rejected on the grounds of ABI breakage.

Another solution to fix the DTBS check errors introduced by [0] is
to modify the ti,j721e-system-controller.yaml binding to allow
audio-refclk as clock-controller child. This is done in the first
patch of this series.

Test log: https://gist.github.com/Jamm02/64b1af5b8829c47f1a2c5ace93204982

[0]: https://lore.kernel.org/linux-arm-kernel/20250604104656.38752-1-j-choudhary@ti.com/
[1]: https://lore.kernel.org/all/20250603095609.33569-4-j-choudhary@ti.com/

Jayesh Choudhary (2):
  arm64: dts: ti: k3-j721s2-main: Add audio_refclk node
  arm64: dts: ti: k3-j721s2-common-proc-board: Enable analog audio
    support

Moteen Shah (1):
  ti,j721e-system-controller.yaml: Allow audio-refclk as
    clock-controller child

 .../soc/ti/ti,j721e-system-controller.yaml    |   6 +-
 .../dts/ti/k3-j721s2-common-proc-board.dts    | 131 ++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi    |   9 ++
 3 files changed, 144 insertions(+), 2 deletions(-)

-- 
2.34.1

[PATCH 1/3] ti,j721e-system-controller.yaml: Allow audio-refclk as clock-controller child

[Moteen Shah]

The ti,j721e-system-controller binding currently only allows
clock-controller@ child nodes to reference the ti,am654-ehrpwm-tbclk
schema. However, the system controller on J721S2 also contains audio
reference clock controllers (ti,am62-audio-refclk) that use the same
clock-controller@XXXX naming pattern.

Hence, extend the clock-controller pattern to accept either ehrpwm-tbclk
or audio-refclk schemas using a oneOf constraint.

Signed-off-by: Moteen Shah <m-shah@ti.com>
---
 .../bindings/soc/ti/ti,j721e-system-controller.yaml         | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
index f3bd0be3b279..d5d84a8f1257 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
@@ -53,9 +53,11 @@ patternProperties:
 
   "^clock-controller@[0-9a-f]+$":
     type: object
-    $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
+    oneOf:
+      - $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
+      - $ref: /schemas/clock/ti,am62-audio-refclk.yaml#
     description:
-      Clock provider for TI EHRPWM nodes.
+      Clock provider for TI EHRPWM or Audio Reference Clock nodes.
 
   "phy@[0-9a-f]+$":
     type: object
-- 
2.34.1

Re: [PATCH 1/3] ti,j721e-system-controller.yaml: Allow audio-refclk as clock-controller child

[Rob Herring (Arm)]

On Mon, 12 Jan 2026 16:15:34 +0530, Moteen Shah wrote:
> The ti,j721e-system-controller binding currently only allows
> clock-controller@ child nodes to reference the ti,am654-ehrpwm-tbclk
> schema. However, the system controller on J721S2 also contains audio
> reference clock controllers (ti,am62-audio-refclk) that use the same
> clock-controller@XXXX naming pattern.
> 
> Hence, extend the clock-controller pattern to accept either ehrpwm-tbclk
> or audio-refclk schemas using a oneOf constraint.
> 
> Signed-off-by: Moteen Shah <m-shah@ti.com>
> ---
>  .../bindings/soc/ti/ti,j721e-system-controller.yaml         | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

[PATCH 2/3] arm64: dts: ti: k3-j721s2-main: Add audio_refclk node

[Moteen Shah]

From: Jayesh Choudhary <j-choudhary@ti.com>

On J721S2 SoC, the AUDIO_REFCLK1 can be used as input to external
peripherals when configured through CTRL_MMR.
Add audio_refclk1 node which would be used as system clock for
audio codec PCM3168A.

Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
Signed-off-by: Moteen Shah <m-shah@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
index 80c51b11ac9f..3ecc7c973205 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
@@ -75,6 +75,15 @@ ehrpwm_tbclk: clock-controller@140 {
 			reg = <0x140 0x18>;
 			#clock-cells = <1>;
 		};
+
+		audio_refclk1: clock-controller@42e4 {
+			compatible = "ti,am62-audio-refclk";
+			reg = <0x42e4 0x4>;
+			clocks = <&k3_clks 157 299>;
+			assigned-clocks = <&k3_clks 157 299>;
+			assigned-clock-parents = <&k3_clks 157 328>;
+			#clock-cells = <0>;
+		};
 	};
 
 	main_ehrpwm0: pwm@3000000 {
-- 
2.34.1

Re: [PATCH 2/3] arm64: dts: ti: k3-j721s2-main: Add audio_refclk node

[Hari Prasath]

On 12/01/26 4:15 pm, Moteen Shah wrote:
> From: Jayesh Choudhary <j-choudhary@ti.com>
> 
> On J721S2 SoC, the AUDIO_REFCLK1 can be used as input to external
> peripherals when configured through CTRL_MMR.
> Add audio_refclk1 node which would be used as system clock for
> audio codec PCM3168A.
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> Signed-off-by: Moteen Shah <m-shah@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 

Reviewed-by: Hari Prasath Gujulan Elango <gehariprasath@ti.com>

> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> index 80c51b11ac9f..3ecc7c973205 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> @@ -75,6 +75,15 @@ ehrpwm_tbclk: clock-controller@140 {
>   			reg = <0x140 0x18>;
>   			#clock-cells = <1>;
>   		};
> +
> +		audio_refclk1: clock-controller@42e4 {
> +			compatible = "ti,am62-audio-refclk";
> +			reg = <0x42e4 0x4>;
> +			clocks = <&k3_clks 157 299>;
> +			assigned-clocks = <&k3_clks 157 299>;
> +			assigned-clock-parents = <&k3_clks 157 328>;
> +			#clock-cells = <0>;
> +		};
>   	};
>   
>   	main_ehrpwm0: pwm@3000000 {

[PATCH 3/3] arm64: dts: ti: k3-j721s2-common-proc-board: Enable analog audio support

[Moteen Shah]

From: Jayesh Choudhary <j-choudhary@ti.com>

The audio support on J721S2-EVM is using PCM3168A codec
connected to McASP4 serializers.

- Add the nodes for sound-card, audio codec, MAIN_I2C3 and
  McASP4.
- Add pinmux for I2C3, McASP4, AUDIO_EXT_REFCLK1 and
  WKUP_GPIO_0.
- Add necessary GPIO hogs to route the MAIN_I2C3 lines and
  McASP serializer.
- Add idle-state as 1 in mux0 and mux1 to route McASP signals

Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
Signed-off-by: Moteen Shah <m-shah@ti.com>
---
 .../dts/ti/k3-j721s2-common-proc-board.dts    | 131 ++++++++++++++++++
 1 file changed, 131 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
index 4fea99519113..d9269a16956c 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
@@ -150,6 +150,28 @@ transceiver4: can-phy4 {
 		standby-gpios = <&exp_som 7 GPIO_ACTIVE_HIGH>;
 		mux-states = <&mux1 1>;
 	};
+
+	codec_audio: sound {
+		compatible = "ti,j7200-cpb-audio";
+		model = "j721e-cpb";
+
+		ti,cpb-mcasp = <&mcasp4>;
+		ti,cpb-codec = <&pcm3168a_1>;
+
+		clocks = <&k3_clks 213 0>, <&k3_clks 213 1>,
+			 <&k3_clks 157 299>, <&k3_clks 157 328>;
+		clock-names = "cpb-mcasp-auxclk", "cpb-mcasp-auxclk-48000",
+			      "cpb-codec-scki", "cpb-codec-scki-48000";
+	};
+
+	i2c_mux: mux-controller-2 {
+		compatible = "gpio-mux";
+		#mux-state-cells = <1>;
+		mux-gpios = <&wkup_gpio0 54 GPIO_ACTIVE_HIGH>;
+		idle-state = <1>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&main_i2c3_mux_pins_default>;
+	};
 };
 
 &main_pmx0 {
@@ -224,6 +246,22 @@ J721S2_IOPAD(0x03c, PIN_INPUT, 0) /* (U27) MCASP0_AFSX.MCAN5_RX */
 			J721S2_IOPAD(0x038, PIN_OUTPUT, 0) /* (AB28) MCASP0_ACLKX.MCAN5_TX */
 		>;
 	};
+
+	mcasp4_pins_default: mcasp4-default-pins {
+		pinctrl-single,pins = <
+			J721S2_IOPAD(0x0c8, PIN_OUTPUT_PULLDOWN, 1) /* (AD28) MCASP4_ACLKX */
+			J721S2_IOPAD(0x06c, PIN_OUTPUT_PULLDOWN, 1) /* (V26) MCASP4_AFSX */
+			J721S2_IOPAD(0x068, PIN_INPUT_PULLDOWN, 1) /* (U28) MCASP4_AXR1 */
+			J721S2_IOPAD(0x0c4, PIN_OUTPUT_PULLDOWN, 1) /* (AB26) MCASP4_AXR2 */
+			J721S2_IOPAD(0x070, PIN_OUTPUT_PULLDOWN, 1) /* (R27) MCASP4_AXR3 */
+		>;
+	};
+
+	audio_ext_refclk1_pins_default: audio-ext-refclk1-default-pins {
+		pinctrl-single,pins = <
+			J721S2_IOPAD(0x078, PIN_OUTPUT, 1) /* (Y25) MCAN2_RX.AUDIO_EXT_REFCLK1 */
+		>;
+	};
 };
 
 &wkup_pmx2 {
@@ -321,6 +359,12 @@ J721S2_WKUP_IOPAD(0x104, PIN_INPUT, 0) /* (N26) MCU_ADC1_AIN6 */
 			J721S2_WKUP_IOPAD(0x108, PIN_INPUT, 0) /* (N27) MCU_ADC1_AIN7 */
 		>;
 	};
+
+	main_i2c3_mux_pins_default: main-i2c3-mux-default-pins {
+		pinctrl-single,pins = <
+			J721S2_WKUP_IOPAD(0x038, PIN_OUTPUT, 7) /* (B27) WKUP_GPIO0_54 */
+		>;
+	};
 };
 
 &wkup_pmx1 {
@@ -396,6 +440,22 @@ exp2: gpio@22 {
 				  "MLB_MUX_SEL", "MCAN_MUX_SEL", "MCASP2/SPI3_MUX_SEL", "PCIe_CLKREQn_MUX_SEL",
 				  "CDCI2_RSTZ", "ENET_EXP_PWRDN", "ENET_EXP_RESETZ", "ENET_I2CMUX_SEL",
 				  "ENET_EXP_SPARE2", "M2PCIE_RTSZ", "USER_INPUT1", "USER_LED1", "USER_LED2";
+
+		p09-hog {
+			/* P09 - MCASP/TRACE_MUX_S0 */
+			gpio-hog;
+			gpios = <9 GPIO_ACTIVE_HIGH>;
+			output-low;
+			line-name = "MCASP/TRACE_MUX_S0";
+		};
+
+		p10-hog {
+			/* P10 - MCASP/TRACE_MUX_S1 */
+			gpio-hog;
+			gpios = <10 GPIO_ACTIVE_HIGH>;
+			output-high;
+			line-name = "MCASP/TRACE_MUX_S1";
+		};
 	};
 };
 
@@ -657,3 +717,74 @@ &dphy_tx0 {
 &dsi0 {
 	status = "okay";
 };
+
+&mux0 {
+	idle-state = <0>;
+};
+
+&mux1 {
+	idle-state = <0>;
+};
+
+&exp_som {
+	p03-hog {
+		/* P03 - CANUART_MUX_SEL1 */
+		gpio-hog;
+		gpios = <3 GPIO_ACTIVE_HIGH>;
+		output-high;
+		line-name = "CANUART_MUX_SEL1";
+	};
+};
+
+&k3_clks {
+	/* Confiure AUDIO_EXT_REFCLK1 pin as output */
+	pinctrl-names = "default";
+	pinctrl-0 = <&audio_ext_refclk1_pins_default>;
+};
+
+&main_i2c3 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&main_i2c3_pins_default>;
+	clock-frequency = <400000>;
+	mux-states = <&i2c_mux 1>;
+
+	exp3: gpio@20 {
+		compatible = "ti,tca6408";
+		reg = <0x20>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	pcm3168a_1: audio-codec@44 {
+		compatible = "ti,pcm3168a";
+		reg = <0x44>;
+		#sound-dai-cells = <1>;
+		reset-gpios = <&exp3 0 GPIO_ACTIVE_LOW>;
+		/* C_AUDIO_REFCLK1 -> MCAN2_RX (Y25) */
+		clocks = <&audio_refclk1>;
+		clock-names = "scki";
+		VDD1-supply = <&vsys_3v3>;
+		VDD2-supply = <&vsys_3v3>;
+		VCCAD1-supply = <&vsys_5v0>;
+		VCCAD2-supply = <&vsys_5v0>;
+		VCCDA1-supply = <&vsys_5v0>;
+		VCCDA2-supply = <&vsys_5v0>;
+	};
+};
+
+&mcasp4 {
+	status = "okay";
+	#sound-dai-cells = <0>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&mcasp4_pins_default>;
+	op-mode = <0>;          /* MCASP_IIS_MODE */
+	tdm-slots = <2>;
+	auxclk-fs-ratio = <256>;
+	serial-dir = <	/* 0: INACTIVE, 1: TX, 2: RX */
+		0 2 1 1
+		0 0 0 0
+		0 0 0 0
+		0 0 0 0
+	>;
+};
-- 
2.34.1

Re: [PATCH 3/3] arm64: dts: ti: k3-j721s2-common-proc-board: Enable analog audio support

[Hari Prasath]

On 12/01/26 4:15 pm, Moteen Shah wrote:
> From: Jayesh Choudhary <j-choudhary@ti.com>
> 
> The audio support on J721S2-EVM is using PCM3168A codec
> connected to McASP4 serializers.
> 
> - Add the nodes for sound-card, audio codec, MAIN_I2C3 and
>    McASP4.
> - Add pinmux for I2C3, McASP4, AUDIO_EXT_REFCLK1 and
>    WKUP_GPIO_0.
> - Add necessary GPIO hogs to route the MAIN_I2C3 lines and
>    McASP serializer.
> - Add idle-state as 1 in mux0 and mux1 to route McASP signals
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> Signed-off-by: Moteen Shah <m-shah@ti.com>
> ---
Looks good,
Reviewed-by: Hari Prasath Gujulan Elango <gehariprasath@ti.com>

>   .../dts/ti/k3-j721s2-common-proc-board.dts    | 131 ++++++++++++++++++
>   1 file changed, 131 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> index 4fea99519113..d9269a16956c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> @@ -150,6 +150,28 @@ transceiver4: can-phy4 {
>   		standby-gpios = <&exp_som 7 GPIO_ACTIVE_HIGH>;
>   		mux-states = <&mux1 1>;
>   	};
> +
> +	codec_audio: sound {
> +		compatible = "ti,j7200-cpb-audio";
> +		model = "j721e-cpb";
> +
> +		ti,cpb-mcasp = <&mcasp4>;
> +		ti,cpb-codec = <&pcm3168a_1>;
> +
> +		clocks = <&k3_clks 213 0>, <&k3_clks 213 1>,
> +			 <&k3_clks 157 299>, <&k3_clks 157 328>;
> +		clock-names = "cpb-mcasp-auxclk", "cpb-mcasp-auxclk-48000",
> +			      "cpb-codec-scki", "cpb-codec-scki-48000";
> +	};
> +
> +	i2c_mux: mux-controller-2 {
> +		compatible = "gpio-mux";
> +		#mux-state-cells = <1>;
> +		mux-gpios = <&wkup_gpio0 54 GPIO_ACTIVE_HIGH>;
> +		idle-state = <1>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&main_i2c3_mux_pins_default>;
> +	};
>   };
>   
>   &main_pmx0 {
> @@ -224,6 +246,22 @@ J721S2_IOPAD(0x03c, PIN_INPUT, 0) /* (U27) MCASP0_AFSX.MCAN5_RX */
>   			J721S2_IOPAD(0x038, PIN_OUTPUT, 0) /* (AB28) MCASP0_ACLKX.MCAN5_TX */
>   		>;
>   	};
> +
> +	mcasp4_pins_default: mcasp4-default-pins {
> +		pinctrl-single,pins = <
> +			J721S2_IOPAD(0x0c8, PIN_OUTPUT_PULLDOWN, 1) /* (AD28) MCASP4_ACLKX */
> +			J721S2_IOPAD(0x06c, PIN_OUTPUT_PULLDOWN, 1) /* (V26) MCASP4_AFSX */
> +			J721S2_IOPAD(0x068, PIN_INPUT_PULLDOWN, 1) /* (U28) MCASP4_AXR1 */
> +			J721S2_IOPAD(0x0c4, PIN_OUTPUT_PULLDOWN, 1) /* (AB26) MCASP4_AXR2 */
> +			J721S2_IOPAD(0x070, PIN_OUTPUT_PULLDOWN, 1) /* (R27) MCASP4_AXR3 */
> +		>;
> +	};
> +
> +	audio_ext_refclk1_pins_default: audio-ext-refclk1-default-pins {
> +		pinctrl-single,pins = <
> +			J721S2_IOPAD(0x078, PIN_OUTPUT, 1) /* (Y25) MCAN2_RX.AUDIO_EXT_REFCLK1 */
> +		>;
> +	};
>   };
>   
>   &wkup_pmx2 {
> @@ -321,6 +359,12 @@ J721S2_WKUP_IOPAD(0x104, PIN_INPUT, 0) /* (N26) MCU_ADC1_AIN6 */
>   			J721S2_WKUP_IOPAD(0x108, PIN_INPUT, 0) /* (N27) MCU_ADC1_AIN7 */
>   		>;
>   	};
> +
> +	main_i2c3_mux_pins_default: main-i2c3-mux-default-pins {
> +		pinctrl-single,pins = <
> +			J721S2_WKUP_IOPAD(0x038, PIN_OUTPUT, 7) /* (B27) WKUP_GPIO0_54 */
> +		>;
> +	};
>   };
>   
>   &wkup_pmx1 {
> @@ -396,6 +440,22 @@ exp2: gpio@22 {
>   				  "MLB_MUX_SEL", "MCAN_MUX_SEL", "MCASP2/SPI3_MUX_SEL", "PCIe_CLKREQn_MUX_SEL",
>   				  "CDCI2_RSTZ", "ENET_EXP_PWRDN", "ENET_EXP_RESETZ", "ENET_I2CMUX_SEL",
>   				  "ENET_EXP_SPARE2", "M2PCIE_RTSZ", "USER_INPUT1", "USER_LED1", "USER_LED2";
> +
> +		p09-hog {
> +			/* P09 - MCASP/TRACE_MUX_S0 */
> +			gpio-hog;
> +			gpios = <9 GPIO_ACTIVE_HIGH>;
> +			output-low;
> +			line-name = "MCASP/TRACE_MUX_S0";
> +		};
> +
> +		p10-hog {
> +			/* P10 - MCASP/TRACE_MUX_S1 */
> +			gpio-hog;
> +			gpios = <10 GPIO_ACTIVE_HIGH>;
> +			output-high;
> +			line-name = "MCASP/TRACE_MUX_S1";
> +		};
>   	};
>   };
>   
> @@ -657,3 +717,74 @@ &dphy_tx0 {
>   &dsi0 {
>   	status = "okay";
>   };
> +
> +&mux0 {
> +	idle-state = <0>;
> +};
> +
> +&mux1 {
> +	idle-state = <0>;
> +};
> +
> +&exp_som {
> +	p03-hog {
> +		/* P03 - CANUART_MUX_SEL1 */
> +		gpio-hog;
> +		gpios = <3 GPIO_ACTIVE_HIGH>;
> +		output-high;
> +		line-name = "CANUART_MUX_SEL1";
> +	};
> +};
> +
> +&k3_clks {
> +	/* Confiure AUDIO_EXT_REFCLK1 pin as output */
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&audio_ext_refclk1_pins_default>;
> +};
> +
> +&main_i2c3 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&main_i2c3_pins_default>;
> +	clock-frequency = <400000>;
> +	mux-states = <&i2c_mux 1>;
> +
> +	exp3: gpio@20 {
> +		compatible = "ti,tca6408";
> +		reg = <0x20>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +
> +	pcm3168a_1: audio-codec@44 {
> +		compatible = "ti,pcm3168a";
> +		reg = <0x44>;
> +		#sound-dai-cells = <1>;
> +		reset-gpios = <&exp3 0 GPIO_ACTIVE_LOW>;
> +		/* C_AUDIO_REFCLK1 -> MCAN2_RX (Y25) */
> +		clocks = <&audio_refclk1>;
> +		clock-names = "scki";
> +		VDD1-supply = <&vsys_3v3>;
> +		VDD2-supply = <&vsys_3v3>;
> +		VCCAD1-supply = <&vsys_5v0>;
> +		VCCAD2-supply = <&vsys_5v0>;
> +		VCCDA1-supply = <&vsys_5v0>;
> +		VCCDA2-supply = <&vsys_5v0>;
> +	};
> +};
> +
> +&mcasp4 {
> +	status = "okay";
> +	#sound-dai-cells = <0>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&mcasp4_pins_default>;
> +	op-mode = <0>;          /* MCASP_IIS_MODE */
> +	tdm-slots = <2>;
> +	auxclk-fs-ratio = <256>;
> +	serial-dir = <	/* 0: INACTIVE, 1: TX, 2: RX */
> +		0 2 1 1
> +		0 0 0 0
> +		0 0 0 0
> +		0 0 0 0
> +	>;
> +};

Re: [PATCH 3/3] arm64: dts: ti: k3-j721s2-common-proc-board: Enable analog audio support

[Nishanth Menon]

On 16:15-20260112, Moteen Shah wrote:
> From: Jayesh Choudhary <j-choudhary@ti.com>
> 
> The audio support on J721S2-EVM is using PCM3168A codec
> connected to McASP4 serializers.
> 
> - Add the nodes for sound-card, audio codec, MAIN_I2C3 and
>   McASP4.
> - Add pinmux for I2C3, McASP4, AUDIO_EXT_REFCLK1 and
>   WKUP_GPIO_0.
> - Add necessary GPIO hogs to route the MAIN_I2C3 lines and
>   McASP serializer.
> - Add idle-state as 1 in mux0 and mux1 to route McASP signals
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> Signed-off-by: Moteen Shah <m-shah@ti.com>
> ---
>  .../dts/ti/k3-j721s2-common-proc-board.dts    | 131 ++++++++++++++++++
>  1 file changed, 131 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> index 4fea99519113..d9269a16956c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> @@ -150,6 +150,28 @@ transceiver4: can-phy4 {
>  		standby-gpios = <&exp_som 7 GPIO_ACTIVE_HIGH>;
>  		mux-states = <&mux1 1>;
>  	};
> +
> +	codec_audio: sound {
> +		compatible = "ti,j7200-cpb-audio";
> +		model = "j721e-cpb";
> +
> +		ti,cpb-mcasp = <&mcasp4>;
> +		ti,cpb-codec = <&pcm3168a_1>;
> +
> +		clocks = <&k3_clks 213 0>, <&k3_clks 213 1>,
> +			 <&k3_clks 157 299>, <&k3_clks 157 328>;
> +		clock-names = "cpb-mcasp-auxclk", "cpb-mcasp-auxclk-48000",
> +			      "cpb-codec-scki", "cpb-codec-scki-48000";
> +	};
> +
> +	i2c_mux: mux-controller-2 {

There is just a single i2c_mux on processor board/evm? if not, might
be good to set this as i2c_mux0 or appropriate naming?

> +		compatible = "gpio-mux";
> +		#mux-state-cells = <1>;
> +		mux-gpios = <&wkup_gpio0 54 GPIO_ACTIVE_HIGH>;
> +		idle-state = <1>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&main_i2c3_mux_pins_default>;
> +	};
>  };
>  
>  &main_pmx0 {
> @@ -224,6 +246,22 @@ J721S2_IOPAD(0x03c, PIN_INPUT, 0) /* (U27) MCASP0_AFSX.MCAN5_RX */
>  			J721S2_IOPAD(0x038, PIN_OUTPUT, 0) /* (AB28) MCASP0_ACLKX.MCAN5_TX */
>  		>;
>  	};
> +
> +	mcasp4_pins_default: mcasp4-default-pins {
> +		pinctrl-single,pins = <
> +			J721S2_IOPAD(0x0c8, PIN_OUTPUT_PULLDOWN, 1) /* (AD28) MCASP4_ACLKX */
> +			J721S2_IOPAD(0x06c, PIN_OUTPUT_PULLDOWN, 1) /* (V26) MCASP4_AFSX */
> +			J721S2_IOPAD(0x068, PIN_INPUT_PULLDOWN, 1) /* (U28) MCASP4_AXR1 */
> +			J721S2_IOPAD(0x0c4, PIN_OUTPUT_PULLDOWN, 1) /* (AB26) MCASP4_AXR2 */
> +			J721S2_IOPAD(0x070, PIN_OUTPUT_PULLDOWN, 1) /* (R27) MCASP4_AXR3 */
> +		>;
> +	};
> +
> +	audio_ext_refclk1_pins_default: audio-ext-refclk1-default-pins {
> +		pinctrl-single,pins = <
> +			J721S2_IOPAD(0x078, PIN_OUTPUT, 1) /* (Y25) MCAN2_RX.AUDIO_EXT_REFCLK1 */
> +		>;
> +	};
>  };
>  
>  &wkup_pmx2 {
> @@ -321,6 +359,12 @@ J721S2_WKUP_IOPAD(0x104, PIN_INPUT, 0) /* (N26) MCU_ADC1_AIN6 */
>  			J721S2_WKUP_IOPAD(0x108, PIN_INPUT, 0) /* (N27) MCU_ADC1_AIN7 */
>  		>;
>  	};
> +
> +	main_i2c3_mux_pins_default: main-i2c3-mux-default-pins {
> +		pinctrl-single,pins = <
> +			J721S2_WKUP_IOPAD(0x038, PIN_OUTPUT, 7) /* (B27) WKUP_GPIO0_54 */
> +		>;
> +	};
>  };
>  
>  &wkup_pmx1 {
> @@ -396,6 +440,22 @@ exp2: gpio@22 {
>  				  "MLB_MUX_SEL", "MCAN_MUX_SEL", "MCASP2/SPI3_MUX_SEL", "PCIe_CLKREQn_MUX_SEL",
>  				  "CDCI2_RSTZ", "ENET_EXP_PWRDN", "ENET_EXP_RESETZ", "ENET_I2CMUX_SEL",
>  				  "ENET_EXP_SPARE2", "M2PCIE_RTSZ", "USER_INPUT1", "USER_LED1", "USER_LED2";
> +
> +		p09-hog {
> +			/* P09 - MCASP/TRACE_MUX_S0 */
> +			gpio-hog;
> +			gpios = <9 GPIO_ACTIVE_HIGH>;
> +			output-low;
> +			line-name = "MCASP/TRACE_MUX_S0";
> +		};
> +
> +		p10-hog {
> +			/* P10 - MCASP/TRACE_MUX_S1 */
> +			gpio-hog;
> +			gpios = <10 GPIO_ACTIVE_HIGH>;
> +			output-high;
> +			line-name = "MCASP/TRACE_MUX_S1";
> +		};

We loose JTAG Trace?

>  	};
>  };
>  
> @@ -657,3 +717,74 @@ &dphy_tx0 {
>  &dsi0 {
>  	status = "okay";
>  };
> +
> +&mux0 {
> +	idle-state = <0>;
> +};
> +
> +&mux1 {
> +	idle-state = <0>;

Commit says:
- Add idle-state as 1 in mux0 and mux1 to route McASP signals

you are adding idle-state = <0> here - which is correct? why?

> +};
> +
> +&exp_som {
> +	p03-hog {
> +		/* P03 - CANUART_MUX_SEL1 */

and we loose CAN? or UART -> not sure I understand this change and why
is it related to audio?

> +		gpio-hog;
> +		gpios = <3 GPIO_ACTIVE_HIGH>;
> +		output-high;
> +		line-name = "CANUART_MUX_SEL1";
> +	};
> +};
> +
> +&k3_clks {
> +	/* Confiure AUDIO_EXT_REFCLK1 pin as output */

I bet you did'nt run checkpatch --strict --codespell.. :)
s/Confiure/Configure

> +	pinctrl-names = "default";
> +	pinctrl-0 = <&audio_ext_refclk1_pins_default>;
> +};
> +
> +&main_i2c3 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&main_i2c3_pins_default>;
> +	clock-frequency = <400000>;
> +	mux-states = <&i2c_mux 1>;
> +
> +	exp3: gpio@20 {
> +		compatible = "ti,tca6408";
> +		reg = <0x20>;
> +		gpio-controller;
> +		#gpio-cells = <2>;

gpio-line-names please

> +	};
> +
> +	pcm3168a_1: audio-codec@44 {
> +		compatible = "ti,pcm3168a";
> +		reg = <0x44>;
> +		#sound-dai-cells = <1>;
> +		reset-gpios = <&exp3 0 GPIO_ACTIVE_LOW>;
> +		/* C_AUDIO_REFCLK1 -> MCAN2_RX (Y25) */

What is this comment pertinent to?

> +		clocks = <&audio_refclk1>;
> +		clock-names = "scki";
> +		VDD1-supply = <&vsys_3v3>;
> +		VDD2-supply = <&vsys_3v3>;
> +		VCCAD1-supply = <&vsys_5v0>;
> +		VCCAD2-supply = <&vsys_5v0>;
> +		VCCDA1-supply = <&vsys_5v0>;
> +		VCCDA2-supply = <&vsys_5v0>;
> +	};
> +};
> +
> +&mcasp4 {
> +	status = "okay";
> +	#sound-dai-cells = <0>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&mcasp4_pins_default>;
> +	op-mode = <0>;          /* MCASP_IIS_MODE */
> +	tdm-slots = <2>;
> +	auxclk-fs-ratio = <256>;
> +	serial-dir = <	/* 0: INACTIVE, 1: TX, 2: RX */
> +		0 2 1 1
> +		0 0 0 0
> +		0 0 0 0
> +		0 0 0 0
> +	>;
> +};
> -- 
> 2.34.1
> 
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource

Re: [PATCH 3/3] arm64: dts: ti: k3-j721s2-common-proc-board: Enable analog audio support

[Moteen Shah]

Hey Nishanth,

Thanks for the reviews.

On 16/01/26 18:34, Nishanth Menon wrote:
> On 16:15-20260112, Moteen Shah wrote:
>> From: Jayesh Choudhary <j-choudhary@ti.com>
>>
>> The audio support on J721S2-EVM is using PCM3168A codec
>> connected to McASP4 serializers.
>>
>> - Add the nodes for sound-card, audio codec, MAIN_I2C3 and
>>    McASP4.
>> - Add pinmux for I2C3, McASP4, AUDIO_EXT_REFCLK1 and
>>    WKUP_GPIO_0.
>> - Add necessary GPIO hogs to route the MAIN_I2C3 lines and
>>    McASP serializer.
>> - Add idle-state as 1 in mux0 and mux1 to route McASP signals
>>
>> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
>> Signed-off-by: Moteen Shah <m-shah@ti.com>
>> ---
>>   .../dts/ti/k3-j721s2-common-proc-board.dts    | 131 ++++++++++++++++++
>>   1 file changed, 131 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> index 4fea99519113..d9269a16956c 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> @@ -150,6 +150,28 @@ transceiver4: can-phy4 {
>>   		standby-gpios = <&exp_som 7 GPIO_ACTIVE_HIGH>;
>>   		mux-states = <&mux1 1>;
>>   	};
>> +
>> +	codec_audio: sound {
>> +		compatible = "ti,j7200-cpb-audio";
>> +		model = "j721e-cpb";
>> +
>> +		ti,cpb-mcasp = <&mcasp4>;
>> +		ti,cpb-codec = <&pcm3168a_1>;
>> +
>> +		clocks = <&k3_clks 213 0>, <&k3_clks 213 1>,
>> +			 <&k3_clks 157 299>, <&k3_clks 157 328>;
>> +		clock-names = "cpb-mcasp-auxclk", "cpb-mcasp-auxclk-48000",
>> +			      "cpb-codec-scki", "cpb-codec-scki-48000";
>> +	};
>> +
>> +	i2c_mux: mux-controller-2 {
> There is just a single i2c_mux on processor board/evm? if not, might
> be good to set this as i2c_mux0 or appropriate naming?

There are others as well, will rename this to i2c_mux0

>
>> +		compatible = "gpio-mux";
>> +		#mux-state-cells = <1>;
>> +		mux-gpios = <&wkup_gpio0 54 GPIO_ACTIVE_HIGH>;
>> +		idle-state = <1>;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&main_i2c3_mux_pins_default>;
>> +	};
>>   };
>>   
>>   &main_pmx0 {
>> @@ -224,6 +246,22 @@ J721S2_IOPAD(0x03c, PIN_INPUT, 0) /* (U27) MCASP0_AFSX.MCAN5_RX */
>>   			J721S2_IOPAD(0x038, PIN_OUTPUT, 0) /* (AB28) MCASP0_ACLKX.MCAN5_TX */
>>   		>;
>>   	};
>> +
>> +	mcasp4_pins_default: mcasp4-default-pins {
>> +		pinctrl-single,pins = <
>> +			J721S2_IOPAD(0x0c8, PIN_OUTPUT_PULLDOWN, 1) /* (AD28) MCASP4_ACLKX */
>> +			J721S2_IOPAD(0x06c, PIN_OUTPUT_PULLDOWN, 1) /* (V26) MCASP4_AFSX */
>> +			J721S2_IOPAD(0x068, PIN_INPUT_PULLDOWN, 1) /* (U28) MCASP4_AXR1 */
>> +			J721S2_IOPAD(0x0c4, PIN_OUTPUT_PULLDOWN, 1) /* (AB26) MCASP4_AXR2 */
>> +			J721S2_IOPAD(0x070, PIN_OUTPUT_PULLDOWN, 1) /* (R27) MCASP4_AXR3 */
>> +		>;
>> +	};
>> +
>> +	audio_ext_refclk1_pins_default: audio-ext-refclk1-default-pins {
>> +		pinctrl-single,pins = <
>> +			J721S2_IOPAD(0x078, PIN_OUTPUT, 1) /* (Y25) MCAN2_RX.AUDIO_EXT_REFCLK1 */
>> +		>;
>> +	};
>>   };
>>   
>>   &wkup_pmx2 {
>> @@ -321,6 +359,12 @@ J721S2_WKUP_IOPAD(0x104, PIN_INPUT, 0) /* (N26) MCU_ADC1_AIN6 */
>>   			J721S2_WKUP_IOPAD(0x108, PIN_INPUT, 0) /* (N27) MCU_ADC1_AIN7 */
>>   		>;
>>   	};
>> +
>> +	main_i2c3_mux_pins_default: main-i2c3-mux-default-pins {
>> +		pinctrl-single,pins = <
>> +			J721S2_WKUP_IOPAD(0x038, PIN_OUTPUT, 7) /* (B27) WKUP_GPIO0_54 */
>> +		>;
>> +	};
>>   };
>>   
>>   &wkup_pmx1 {
>> @@ -396,6 +440,22 @@ exp2: gpio@22 {
>>   				  "MLB_MUX_SEL", "MCAN_MUX_SEL", "MCASP2/SPI3_MUX_SEL", "PCIe_CLKREQn_MUX_SEL",
>>   				  "CDCI2_RSTZ", "ENET_EXP_PWRDN", "ENET_EXP_RESETZ", "ENET_I2CMUX_SEL",
>>   				  "ENET_EXP_SPARE2", "M2PCIE_RTSZ", "USER_INPUT1", "USER_LED1", "USER_LED2";
>> +
>> +		p09-hog {
>> +			/* P09 - MCASP/TRACE_MUX_S0 */
>> +			gpio-hog;
>> +			gpios = <9 GPIO_ACTIVE_HIGH>;
>> +			output-low;
>> +			line-name = "MCASP/TRACE_MUX_S0";
>> +		};
>> +
>> +		p10-hog {
>> +			/* P10 - MCASP/TRACE_MUX_S1 */
>> +			gpio-hog;
>> +			gpios = <10 GPIO_ACTIVE_HIGH>;
>> +			output-high;
>> +			line-name = "MCASP/TRACE_MUX_S1";
>> +		};
> We loose JTAG Trace?

That is true, will pivot to using the dtbo method instead, out of box we 
still want the JTAG trace to be active

>
>>   	};
>>   };
>>   
>> @@ -657,3 +717,74 @@ &dphy_tx0 {
>>   &dsi0 {
>>   	status = "okay";
>>   };
>> +
>> +&mux0 {
>> +	idle-state = <0>;
>> +};
>> +
>> +&mux1 {
>> +	idle-state = <0>;
> Commit says:
> - Add idle-state as 1 in mux0 and mux1 to route McASP signals
>
> you are adding idle-state = <0> here - which is correct? why?

I will fix the commit msg in the revision, the state should be 0 for the 
sound card to get registered.

>
>> +};
>> +
>> +&exp_som {
>> +	p03-hog {
>> +		/* P03 - CANUART_MUX_SEL1 */
> and we loose CAN? or UART -> not sure I understand this change and why
> is it related to audio?

I checked the schematics[0] of the SoM and seems like it is irrelevant, 
I'll drop this in the revision.


>
>> +		gpio-hog;
>> +		gpios = <3 GPIO_ACTIVE_HIGH>;
>> +		output-high;
>> +		line-name = "CANUART_MUX_SEL1";
>> +	};
>> +};
>> +
>> +&k3_clks {
>> +	/* Confiure AUDIO_EXT_REFCLK1 pin as output */
> I bet you did'nt run checkpatch --strict --codespell.. :)
> s/Confiure/Configure

Didn't run it with codespell, will rectify in the revision, apologies.

>
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&audio_ext_refclk1_pins_default>;
>> +};
>> +
>> +&main_i2c3 {
>> +	status = "okay";
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&main_i2c3_pins_default>;
>> +	clock-frequency = <400000>;
>> +	mux-states = <&i2c_mux 1>;
>> +
>> +	exp3: gpio@20 {
>> +		compatible = "ti,tca6408";
>> +		reg = <0x20>;
>> +		gpio-controller;
>> +		#gpio-cells = <2>;
> gpio-line-names please

Noted

[0] https://www.ti.com/lit/zip/SPRR439

Regards,
Moteen


>
>> +	};
>> +
>> +	pcm3168a_1: audio-codec@44 {
>> +		compatible = "ti,pcm3168a";
>> +		reg = <0x44>;
>> +		#sound-dai-cells = <1>;
>> +		reset-gpios = <&exp3 0 GPIO_ACTIVE_LOW>;
>> +		/* C_AUDIO_REFCLK1 -> MCAN2_RX (Y25) */
> What is this comment pertinent to?
>
>> +		clocks = <&audio_refclk1>;
>> +		clock-names = "scki";
>> +		VDD1-supply = <&vsys_3v3>;
>> +		VDD2-supply = <&vsys_3v3>;
>> +		VCCAD1-supply = <&vsys_5v0>;
>> +		VCCAD2-supply = <&vsys_5v0>;
>> +		VCCDA1-supply = <&vsys_5v0>;
>> +		VCCDA2-supply = <&vsys_5v0>;
>> +	};
>> +};
>> +
>> +&mcasp4 {
>> +	status = "okay";
>> +	#sound-dai-cells = <0>;
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&mcasp4_pins_default>;
>> +	op-mode = <0>;          /* MCASP_IIS_MODE */
>> +	tdm-slots = <2>;
>> +	auxclk-fs-ratio = <256>;
>> +	serial-dir = <	/* 0: INACTIVE, 1: TX, 2: RX */
>> +		0 2 1 1
>> +		0 0 0 0
>> +		0 0 0 0
>> +		0 0 0 0
>> +	>;
>> +};
>> -- 
>> 2.34.1
>>
>>