* Re: [PATCH] dt-bindings: Fix I2C bus node names in examples
2026-01-14 8:13 [PATCH] dt-bindings: Fix I2C bus node names in examples Krzysztof Kozlowski
@ 2026-01-14 8:30 ` AngeloGioacchino Del Regno
2026-01-14 8:33 ` Laurent Pinchart
2026-01-15 18:56 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-01-14 8:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Laurent Pinchart, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Bjorn Andersson, Tianping Fang, devicetree,
linux-kernel, linux-media, linux-usb
Il 14/01/26 09:13, Krzysztof Kozlowski ha scritto:
> I2C bus node names are expected to be just "i2c", if there is just one
> such node in given example. Replace remaining bad examples with
> scripted:
>
> git grep -l '\si2c[0-9] {' Documentation/devicetree/ | xargs sed -i -e 's/i2c[0-9] {/i2c {/'
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>
> Like Rob's commit 20a72af11f41 ("dt-bindings: Fix SPI and I2C bus node
> names in examples"). I checked also for SPI.
>
> Rebased on Rob's tree - can you pick it up directly? Applies also on
> linux-next, so I do not expect conflicts.
> ---
> .../bindings/embedded-controller/lenovo,yoga-c630-ec.yaml | 2 +-
> Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml | 2 +-
> Documentation/devicetree/bindings/usb/ite,it5205.yaml | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml
> index a029b38e8dc0..c88fbd6ad940 100644
> --- a/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml
> +++ b/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml
> @@ -50,7 +50,7 @@ additionalProperties: false
> examples:
> - |+
> #include <dt-bindings/interrupt-controller/irq.h>
> - i2c1 {
> + i2c {
> clock-frequency = <400000>;
>
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> index a89f740214f7..dffd23ca4839 100644
> --- a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> @@ -95,7 +95,7 @@ examples:
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/media/video-interfaces.h>
>
> - i2c0 {
> + i2c {
> #address-cells = <1>;
> #size-cells = <0>;
>
> diff --git a/Documentation/devicetree/bindings/usb/ite,it5205.yaml b/Documentation/devicetree/bindings/usb/ite,it5205.yaml
> index 889710733de5..045fcb41ac4b 100644
> --- a/Documentation/devicetree/bindings/usb/ite,it5205.yaml
> +++ b/Documentation/devicetree/bindings/usb/ite,it5205.yaml
> @@ -49,7 +49,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/interrupt-controller/irq.h>
> - i2c2 {
> + i2c {
> #address-cells = <1>;
> #size-cells = <0>;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: Fix I2C bus node names in examples
2026-01-14 8:13 [PATCH] dt-bindings: Fix I2C bus node names in examples Krzysztof Kozlowski
2026-01-14 8:30 ` AngeloGioacchino Del Regno
@ 2026-01-14 8:33 ` Laurent Pinchart
2026-01-15 18:56 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2026-01-14 8:33 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Mauro Carvalho Chehab, Greg Kroah-Hartman, Bjorn Andersson,
Del Regno, Tianping Fang, devicetree, linux-kernel, linux-media,
linux-usb
On Wed, Jan 14, 2026 at 09:13:23AM +0100, Krzysztof Kozlowski wrote:
> I2C bus node names are expected to be just "i2c", if there is just one
> such node in given example. Replace remaining bad examples with
> scripted:
>
> git grep -l '\si2c[0-9] {' Documentation/devicetree/ | xargs sed -i -e 's/i2c[0-9] {/i2c {/'
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> Like Rob's commit 20a72af11f41 ("dt-bindings: Fix SPI and I2C bus node
> names in examples"). I checked also for SPI.
>
> Rebased on Rob's tree - can you pick it up directly? Applies also on
> linux-next, so I do not expect conflicts.
> ---
> .../bindings/embedded-controller/lenovo,yoga-c630-ec.yaml | 2 +-
> Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml | 2 +-
> Documentation/devicetree/bindings/usb/ite,it5205.yaml | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml
> index a029b38e8dc0..c88fbd6ad940 100644
> --- a/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml
> +++ b/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml
> @@ -50,7 +50,7 @@ additionalProperties: false
> examples:
> - |+
> #include <dt-bindings/interrupt-controller/irq.h>
> - i2c1 {
> + i2c {
> clock-frequency = <400000>;
>
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> index a89f740214f7..dffd23ca4839 100644
> --- a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> @@ -95,7 +95,7 @@ examples:
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/media/video-interfaces.h>
>
> - i2c0 {
> + i2c {
> #address-cells = <1>;
> #size-cells = <0>;
>
> diff --git a/Documentation/devicetree/bindings/usb/ite,it5205.yaml b/Documentation/devicetree/bindings/usb/ite,it5205.yaml
> index 889710733de5..045fcb41ac4b 100644
> --- a/Documentation/devicetree/bindings/usb/ite,it5205.yaml
> +++ b/Documentation/devicetree/bindings/usb/ite,it5205.yaml
> @@ -49,7 +49,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/interrupt-controller/irq.h>
> - i2c2 {
> + i2c {
> #address-cells = <1>;
> #size-cells = <0>;
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: Fix I2C bus node names in examples
2026-01-14 8:13 [PATCH] dt-bindings: Fix I2C bus node names in examples Krzysztof Kozlowski
2026-01-14 8:30 ` AngeloGioacchino Del Regno
2026-01-14 8:33 ` Laurent Pinchart
@ 2026-01-15 18:56 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2026-01-15 18:56 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, Del Regno, devicetree, linux-usb,
Laurent Pinchart, Tianping Fang, Greg Kroah-Hartman,
Bjorn Andersson, linux-media, Mauro Carvalho Chehab,
linux-kernel, Conor Dooley
On Wed, 14 Jan 2026 09:13:23 +0100, Krzysztof Kozlowski wrote:
> I2C bus node names are expected to be just "i2c", if there is just one
> such node in given example. Replace remaining bad examples with
> scripted:
>
> git grep -l '\si2c[0-9] {' Documentation/devicetree/ | xargs sed -i -e 's/i2c[0-9] {/i2c {/'
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> ---
>
> Like Rob's commit 20a72af11f41 ("dt-bindings: Fix SPI and I2C bus node
> names in examples"). I checked also for SPI.
>
> Rebased on Rob's tree - can you pick it up directly? Applies also on
> linux-next, so I do not expect conflicts.
> ---
> .../bindings/embedded-controller/lenovo,yoga-c630-ec.yaml | 2 +-
> Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml | 2 +-
> Documentation/devicetree/bindings/usb/ite,it5205.yaml | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread